Message ID | 20211209172537.641755-2-richard.purdie@linuxfoundation.org |
---|---|
State | Accepted, archived |
Commit | 3dea562e9d615384cc5e786eff46ac1f8f41e18e |
Headers | show |
Series | [1/4] binutils: Drop mips gold patch | expand |
On Thu, Dec 9, 2021 at 9:25 AM Richard Purdie <richard.purdie@linuxfoundation.org> wrote: > > This adds useful detail from the orginal commit. > > Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org> > --- > ...1-fix-the-incorrect-assembling-for-ppc-wait-mnemonic.patch | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/meta/recipes-devtools/binutils/binutils/0011-fix-the-incorrect-assembling-for-ppc-wait-mnemonic.patch b/meta/recipes-devtools/binutils/binutils/0011-fix-the-incorrect-assembling-for-ppc-wait-mnemonic.patch > index 389232c1e3e..a271f55ea1a 100644 > --- a/meta/recipes-devtools/binutils/binutils/0011-fix-the-incorrect-assembling-for-ppc-wait-mnemonic.patch > +++ b/meta/recipes-devtools/binutils/binutils/0011-fix-the-incorrect-assembling-for-ppc-wait-mnemonic.patch > @@ -3,6 +3,10 @@ From: Zhenhua Luo <zhenhua.luo@nxp.com> > Date: Sat, 11 Jun 2016 22:08:29 -0500 > Subject: [PATCH] fix the incorrect assembling for ppc wait mnemonic > > +The wait mnemonic for ppc targets is incorrectly assembled into 0x7c00003c due > +to duplicated address definition with waitasec instruction. The issue causes > +kernel boot calltrace for ppc targets when wait instruction is executed. This patch bothers me a bit. This either is upstream bug or it is not. So it should be perhaps forwarded upstream and if it is still needed and accepted that will be good. otherwise we should drop it. > + > Signed-off-by: Zhenhua Luo <zhenhua.luo@nxp.com> > > Upstream-Status: Pending > -- > 2.32.0 > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#159463): https://lists.openembedded.org/g/openembedded-core/message/159463 > Mute This Topic: https://lists.openembedded.org/mt/87616746/1997914 > Group Owner: openembedded-core+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [raj.khem@gmail.com] > -=-=-=-=-=-=-=-=-=-=-=- >
On Thu, 2021-12-09 at 09:31 -0800, Khem Raj wrote: > On Thu, Dec 9, 2021 at 9:25 AM Richard Purdie > <richard.purdie@linuxfoundation.org> wrote: > > > > This adds useful detail from the orginal commit. > > > > Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org> > > --- > > ...1-fix-the-incorrect-assembling-for-ppc-wait-mnemonic.patch | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/meta/recipes-devtools/binutils/binutils/0011-fix-the-incorrect-assembling-for-ppc-wait-mnemonic.patch b/meta/recipes-devtools/binutils/binutils/0011-fix-the-incorrect-assembling-for-ppc-wait-mnemonic.patch > > index 389232c1e3e..a271f55ea1a 100644 > > --- a/meta/recipes-devtools/binutils/binutils/0011-fix-the-incorrect-assembling-for-ppc-wait-mnemonic.patch > > +++ b/meta/recipes-devtools/binutils/binutils/0011-fix-the-incorrect-assembling-for-ppc-wait-mnemonic.patch > > @@ -3,6 +3,10 @@ From: Zhenhua Luo <zhenhua.luo@nxp.com> > > Date: Sat, 11 Jun 2016 22:08:29 -0500 > > Subject: [PATCH] fix the incorrect assembling for ppc wait mnemonic > > > > +The wait mnemonic for ppc targets is incorrectly assembled into 0x7c00003c due > > +to duplicated address definition with waitasec instruction. The issue causes > > +kernel boot calltrace for ppc targets when wait instruction is executed. > > This patch bothers me a bit. This either is upstream bug or it is not. > So it should be perhaps forwarded upstream and if it is still needed > and accepted that will be good. > otherwise we should drop it. Yes, that is why I wanted to add the description as it helps with the context and a specific test. I think we need to clean up a few of the binutils patches and share with upstream, see what is said, this is one of them. I obviously saw others I thought we should remove for various reasons :) Cheers, Richard
diff --git a/meta/recipes-devtools/binutils/binutils/0011-fix-the-incorrect-assembling-for-ppc-wait-mnemonic.patch b/meta/recipes-devtools/binutils/binutils/0011-fix-the-incorrect-assembling-for-ppc-wait-mnemonic.patch index 389232c1e3e..a271f55ea1a 100644 --- a/meta/recipes-devtools/binutils/binutils/0011-fix-the-incorrect-assembling-for-ppc-wait-mnemonic.patch +++ b/meta/recipes-devtools/binutils/binutils/0011-fix-the-incorrect-assembling-for-ppc-wait-mnemonic.patch @@ -3,6 +3,10 @@ From: Zhenhua Luo <zhenhua.luo@nxp.com> Date: Sat, 11 Jun 2016 22:08:29 -0500 Subject: [PATCH] fix the incorrect assembling for ppc wait mnemonic +The wait mnemonic for ppc targets is incorrectly assembled into 0x7c00003c due +to duplicated address definition with waitasec instruction. The issue causes +kernel boot calltrace for ppc targets when wait instruction is executed. + Signed-off-by: Zhenhua Luo <zhenhua.luo@nxp.com> Upstream-Status: Pending
This adds useful detail from the orginal commit. Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org> --- ...1-fix-the-incorrect-assembling-for-ppc-wait-mnemonic.patch | 4 ++++ 1 file changed, 4 insertions(+)