[1/4] binutils: Drop mips gold patch

Message ID 20211209172537.641755-1-richard.purdie@linuxfoundation.org
State Accepted, archived
Commit 3c230c70f28aef21ae986679d783551832b4e3fa
Headers show
Series [1/4] binutils: Drop mips gold patch | expand

Commit Message

Richard Purdie Dec. 9, 2021, 5:25 p.m. UTC
As mentioned in a followup to the patch upstream:

https://sourceware.org/legacy-ml/binutils/2016-08/msg00215.html

"With 2.16.1, --enable-gold is just ignored when building on mips"

so we don't need the patch since 2.16.1.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---
 .../binutils/binutils-2.37.inc                |  1 -
 .../0012-Detect-64-bit-MIPS-targets.patch     | 47 -------------------
 2 files changed, 48 deletions(-)
 delete mode 100644 meta/recipes-devtools/binutils/binutils/0012-Detect-64-bit-MIPS-targets.patch

Comments

Khem Raj Dec. 9, 2021, 5:28 p.m. UTC | #1
looks good.

On Thu, Dec 9, 2021 at 9:25 AM Richard Purdie
<richard.purdie@linuxfoundation.org> wrote:
>
> As mentioned in a followup to the patch upstream:
>
> https://sourceware.org/legacy-ml/binutils/2016-08/msg00215.html
>
> "With 2.16.1, --enable-gold is just ignored when building on mips"
>
> so we don't need the patch since 2.16.1.
>
> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> ---
>  .../binutils/binutils-2.37.inc                |  1 -
>  .../0012-Detect-64-bit-MIPS-targets.patch     | 47 -------------------
>  2 files changed, 48 deletions(-)
>  delete mode 100644 meta/recipes-devtools/binutils/binutils/0012-Detect-64-bit-MIPS-targets.patch
>
> diff --git a/meta/recipes-devtools/binutils/binutils-2.37.inc b/meta/recipes-devtools/binutils/binutils-2.37.inc
> index 8f91c6460d7..a3e0fbc769d 100644
> --- a/meta/recipes-devtools/binutils/binutils-2.37.inc
> +++ b/meta/recipes-devtools/binutils/binutils-2.37.inc
> @@ -29,7 +29,6 @@ SRC_URI = "\
>       file://0009-Change-default-emulation-for-mips64-linux.patch \
>       file://0010-Add-support-for-Netlogic-XLP.patch \
>       file://0011-fix-the-incorrect-assembling-for-ppc-wait-mnemonic.patch \
> -     file://0012-Detect-64-bit-MIPS-targets.patch \
>       file://0013-Use-libtool-2.4.patch \
>       file://0014-Fix-rpath-in-libtool-when-sysroot-is-enabled.patch \
>       file://0015-sync-with-OE-libtool-changes.patch \
> diff --git a/meta/recipes-devtools/binutils/binutils/0012-Detect-64-bit-MIPS-targets.patch b/meta/recipes-devtools/binutils/binutils/0012-Detect-64-bit-MIPS-targets.patch
> deleted file mode 100644
> index 04f81c66718..00000000000
> --- a/meta/recipes-devtools/binutils/binutils/0012-Detect-64-bit-MIPS-targets.patch
> +++ /dev/null
> @@ -1,47 +0,0 @@
> -From 02374940dd34fddd2b04624af3f23e01f9cb81cd Mon Sep 17 00:00:00 2001
> -From: Khem Raj <raj.khem@gmail.com>
> -Date: Fri, 31 Mar 2017 11:42:03 -0700
> -Subject: [PATCH] Detect 64-bit MIPS targets
> -
> -Add mips64 target triplets and default to N64
> -
> -Upstream-Status: Submitted
> -https://sourceware.org/ml/binutils/2016-08/msg00048.html
> -
> -Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ----
> - gold/configure.tgt | 14 ++++++++++++++
> - 1 file changed, 14 insertions(+)
> -
> -diff --git a/gold/configure.tgt b/gold/configure.tgt
> -index cac0866e628..24fbf641456 100644
> ---- a/gold/configure.tgt
> -+++ b/gold/configure.tgt
> -@@ -153,6 +153,13 @@ aarch64*-*)
> -  targ_big_endian=false
> -  targ_extra_big_endian=true
> -  ;;
> -+mips*64*el*-*-*|mips*64*le*-*-*)
> -+ targ_obj=mips
> -+ targ_machine=EM_MIPS_RS3_LE
> -+ targ_size=64
> -+ targ_big_endian=false
> -+ targ_extra_big_endian=true
> -+ ;;
> - mips*el*-*-*|mips*le*-*-*)
> -  targ_obj=mips
> -  targ_machine=EM_MIPS_RS3_LE
> -@@ -160,6 +167,13 @@ mips*el*-*-*|mips*le*-*-*)
> -  targ_big_endian=false
> -  targ_extra_big_endian=true
> -  ;;
> -+mips*64*-*-*)
> -+ targ_obj=mips
> -+ targ_machine=EM_MIPS
> -+ targ_size=64
> -+ targ_big_endian=true
> -+ targ_extra_big_endian=false
> -+ ;;
> - mips*-*-*)
> -  targ_obj=mips
> -  targ_machine=EM_MIPS
> --
> 2.32.0
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#159464): https://lists.openembedded.org/g/openembedded-core/message/159464
> Mute This Topic: https://lists.openembedded.org/mt/87616747/1997914
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [raj.khem@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>

Patch

diff --git a/meta/recipes-devtools/binutils/binutils-2.37.inc b/meta/recipes-devtools/binutils/binutils-2.37.inc
index 8f91c6460d7..a3e0fbc769d 100644
--- a/meta/recipes-devtools/binutils/binutils-2.37.inc
+++ b/meta/recipes-devtools/binutils/binutils-2.37.inc
@@ -29,7 +29,6 @@  SRC_URI = "\
      file://0009-Change-default-emulation-for-mips64-linux.patch \
      file://0010-Add-support-for-Netlogic-XLP.patch \
      file://0011-fix-the-incorrect-assembling-for-ppc-wait-mnemonic.patch \
-     file://0012-Detect-64-bit-MIPS-targets.patch \
      file://0013-Use-libtool-2.4.patch \
      file://0014-Fix-rpath-in-libtool-when-sysroot-is-enabled.patch \
      file://0015-sync-with-OE-libtool-changes.patch \
diff --git a/meta/recipes-devtools/binutils/binutils/0012-Detect-64-bit-MIPS-targets.patch b/meta/recipes-devtools/binutils/binutils/0012-Detect-64-bit-MIPS-targets.patch
deleted file mode 100644
index 04f81c66718..00000000000
--- a/meta/recipes-devtools/binutils/binutils/0012-Detect-64-bit-MIPS-targets.patch
+++ /dev/null
@@ -1,47 +0,0 @@ 
-From 02374940dd34fddd2b04624af3f23e01f9cb81cd Mon Sep 17 00:00:00 2001
-From: Khem Raj <raj.khem@gmail.com>
-Date: Fri, 31 Mar 2017 11:42:03 -0700
-Subject: [PATCH] Detect 64-bit MIPS targets
-
-Add mips64 target triplets and default to N64
-
-Upstream-Status: Submitted
-https://sourceware.org/ml/binutils/2016-08/msg00048.html
-
-Signed-off-by: Khem Raj <raj.khem@gmail.com>
----
- gold/configure.tgt | 14 ++++++++++++++
- 1 file changed, 14 insertions(+)
-
-diff --git a/gold/configure.tgt b/gold/configure.tgt
-index cac0866e628..24fbf641456 100644
---- a/gold/configure.tgt
-+++ b/gold/configure.tgt
-@@ -153,6 +153,13 @@ aarch64*-*)
-  targ_big_endian=false
-  targ_extra_big_endian=true
-  ;;
-+mips*64*el*-*-*|mips*64*le*-*-*)
-+ targ_obj=mips
-+ targ_machine=EM_MIPS_RS3_LE
-+ targ_size=64
-+ targ_big_endian=false
-+ targ_extra_big_endian=true
-+ ;;
- mips*el*-*-*|mips*le*-*-*)
-  targ_obj=mips
-  targ_machine=EM_MIPS_RS3_LE
-@@ -160,6 +167,13 @@ mips*el*-*-*|mips*le*-*-*)
-  targ_big_endian=false
-  targ_extra_big_endian=true
-  ;;
-+mips*64*-*-*)
-+ targ_obj=mips
-+ targ_machine=EM_MIPS
-+ targ_size=64
-+ targ_big_endian=true
-+ targ_extra_big_endian=false
-+ ;;
- mips*-*-*)
-  targ_obj=mips
-  targ_machine=EM_MIPS