| Message ID | 20230517080639.9336-2-brgl@bgdev.pl |
|---|---|
| State | New |
| Headers | show |
| Series | python3: fix run-time dependencies | expand |
On 2023-05-17 04:06, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > > Add missing RDEPENDS for this package. > > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > --- > meta/recipes-devtools/python/python-async.inc | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/meta/recipes-devtools/python/python-async.inc b/meta/recipes-devtools/python/python-async.inc > index fde864601c..53f8d79361 100644 > --- a/meta/recipes-devtools/python/python-async.inc > +++ b/meta/recipes-devtools/python/python-async.inc > @@ -9,6 +9,9 @@ inherit pypi > SRC_URI[md5sum] = "9b06b5997de2154f3bc0273f80bcef6b" > SRC_URI[sha256sum] = "ac6894d876e45878faae493b0cf61d0e28ec417334448ac0a6ea2229d8343051" > > -RDEPENDS:${PN} += "${PYTHON_PN}-threading" > +RDEPENDS:${PN} += " \ > + python3-logging \ > + python3-threading \ > +" > > BBCLASSEXTEND = "native nativesdk" This is an OK change, but the recipe should arguably be removed from oe-core instead, given that it 1) hasn't been updated in 9 years and has been abandoned in favor of alternatives by the maintainer, and 2) doesn't appear to be a dependency for anything else in oe-core or meta-openembedded. - Trevor > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#181450): https://lists.openembedded.org/g/openembedded-core/message/181450 > Mute This Topic: https://lists.openembedded.org/mt/98943997/7611679 > Group Owner: openembedded-core+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [tgamblin@baylibre.com] > -=-=-=-=-=-=-=-=-=-=-=- >
On Wed, May 17, 2023 at 6:15 PM Trevor Gamblin <tgamblin@baylibre.com> wrote: > > > On 2023-05-17 04:06, Bartosz Golaszewski wrote: > > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > > > > Add missing RDEPENDS for this package. > > > > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > > --- > > meta/recipes-devtools/python/python-async.inc | 5 ++++- > > 1 file changed, 4 insertions(+), 1 deletion(-) > > > > diff --git a/meta/recipes-devtools/python/python-async.inc b/meta/recipes-devtools/python/python-async.inc > > index fde864601c..53f8d79361 100644 > > --- a/meta/recipes-devtools/python/python-async.inc > > +++ b/meta/recipes-devtools/python/python-async.inc > > @@ -9,6 +9,9 @@ inherit pypi > > SRC_URI[md5sum] = "9b06b5997de2154f3bc0273f80bcef6b" > > SRC_URI[sha256sum] = "ac6894d876e45878faae493b0cf61d0e28ec417334448ac0a6ea2229d8343051" > > > > -RDEPENDS:${PN} += "${PYTHON_PN}-threading" > > +RDEPENDS:${PN} += " \ > > + python3-logging \ > > + python3-threading \ > > +" > > > > BBCLASSEXTEND = "native nativesdk" > > This is an OK change, but the recipe should arguably be removed from > oe-core instead, given that it 1) hasn't been updated in 9 years and has > been abandoned in favor of alternatives by the maintainer, and 2) > doesn't appear to be a dependency for anything else in oe-core or > meta-openembedded. > > - Trevor > I admit I didn't really pay attention to how well maintained the packages are, just fixed their run-time dependencies. I have nothing against removing this. This is precisely why I split the series into individual patches - some may be skipped while others go upstream. Bart
diff --git a/meta/recipes-devtools/python/python-async.inc b/meta/recipes-devtools/python/python-async.inc index fde864601c..53f8d79361 100644 --- a/meta/recipes-devtools/python/python-async.inc +++ b/meta/recipes-devtools/python/python-async.inc @@ -9,6 +9,9 @@ inherit pypi SRC_URI[md5sum] = "9b06b5997de2154f3bc0273f80bcef6b" SRC_URI[sha256sum] = "ac6894d876e45878faae493b0cf61d0e28ec417334448ac0a6ea2229d8343051" -RDEPENDS:${PN} += "${PYTHON_PN}-threading" +RDEPENDS:${PN} += " \ + python3-logging \ + python3-threading \ +" BBCLASSEXTEND = "native nativesdk"