| Message ID | 20220929080536.5400-1-kai.kang@windriver.com |
|---|---|
| State | Accepted, archived |
| Commit | 30630b0e61835278a2e06262560de67c7a867ff6 |
| Headers | show |
| Series | binutils: another way to clear GPROFNG_ALTS for clang and musl | expand |
Fixes my builds, thanks Kai. Ross > On 29 Sep 2022, at 09:05, kai via lists.openembedded.org <kai.kang=windriver.com@lists.openembedded.org> wrote: > > From: Kai Kang <kai.kang@windriver.com> > > It disables gprofng for toolchain clang and libc musl, so GPROFNG_ALTS > should be cleared for them. But override 'toolchain-clang' is applied > before overrides 'TRANSLATED_TARGET_ARCH' such as x86-64, then > GPROFNG_ALTS is still set and not cleared. > > Apply overrides 'toolchain-clang' and 'libc-musl' for GPROFNGS rather > than GPROFNG_ALTS to make it work as expected. > > Signed-off-by: Kai Kang <kai.kang@windriver.com> > --- > meta/recipes-devtools/binutils/binutils.inc | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/meta/recipes-devtools/binutils/binutils.inc b/meta/recipes-devtools/binutils/binutils.inc > index 4dde387a8a..98acf0a222 100644 > --- a/meta/recipes-devtools/binutils/binutils.inc > +++ b/meta/recipes-devtools/binutils/binutils.inc > @@ -44,15 +44,16 @@ GPROFNGS = " \ > gp-display-text \ > gprofng \ > " > + > +# it disables gprofng for clang and musl in the bb file > +GPROFNGS:toolchain-clang = "" > +GPROFNGS:libc-musl = "" > + > GPROFNG_ALTS ?= "" > GPROFNG_ALTS:x86 = "${GPROFNGS}" > GPROFNG_ALTS:x86-64 = "${GPROFNGS}" > GPROFNG_ALTS:aarch64 = "${GPROFNGS}" > > -# it disables gprofng for clang and musl in the bb file > -GPROFNG_ALTS:toolchain-clang = "" > -GPROFNG_ALTS:libc-musl = "" > - > LDGOLD_ALTS ?= "ld.gold dwp" > LDGOLD_ALTS:riscv64 = "" > LDGOLD_ALTS:riscv32 = "" > -- > 2.17.1 > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#171173): https://lists.openembedded.org/g/openembedded-core/message/171173 > Mute This Topic: https://lists.openembedded.org/mt/93990044/6875888 > Group Owner: openembedded-core+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [ross.burton@arm.com] > -=-=-=-=-=-=-=-=-=-=-=- >
diff --git a/meta/recipes-devtools/binutils/binutils.inc b/meta/recipes-devtools/binutils/binutils.inc index 4dde387a8a..98acf0a222 100644 --- a/meta/recipes-devtools/binutils/binutils.inc +++ b/meta/recipes-devtools/binutils/binutils.inc @@ -44,15 +44,16 @@ GPROFNGS = " \ gp-display-text \ gprofng \ " + +# it disables gprofng for clang and musl in the bb file +GPROFNGS:toolchain-clang = "" +GPROFNGS:libc-musl = "" + GPROFNG_ALTS ?= "" GPROFNG_ALTS:x86 = "${GPROFNGS}" GPROFNG_ALTS:x86-64 = "${GPROFNGS}" GPROFNG_ALTS:aarch64 = "${GPROFNGS}" -# it disables gprofng for clang and musl in the bb file -GPROFNG_ALTS:toolchain-clang = "" -GPROFNG_ALTS:libc-musl = "" - LDGOLD_ALTS ?= "ld.gold dwp" LDGOLD_ALTS:riscv64 = "" LDGOLD_ALTS:riscv32 = ""