[meta-networking,2/2] wpantund: Add missing dependency on boost

Message ID 20220419152216.3810783-2-raj.khem@gmail.com
State New
Headers show
Series [meta-oe,1/2] libcereal: Link libatomics with gcc as well | expand

Commit Message

Khem Raj April 19, 2022, 3:22 p.m. UTC
Fixes
checking for boost/signals2/signal.hpp... no
configure: error: Unable to find a usable implementation of boost::signals2 (not even our internal copy)

Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
 meta-networking/recipes-connectivity/openthread/wpantund_git.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Stefan Schmidt April 21, 2022, 11:14 a.m. UTC | #1
Hello Khem.

On 19.04.22 17:22, Khem Raj wrote:
> Fixes
> checking for boost/signals2/signal.hpp... no
> configure: error: Unable to find a usable implementation of boost::signals2 (not even our internal copy)
> 
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
>   meta-networking/recipes-connectivity/openthread/wpantund_git.bb | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta-networking/recipes-connectivity/openthread/wpantund_git.bb b/meta-networking/recipes-connectivity/openthread/wpantund_git.bb
> index bb444d04f5..a7fcc202a4 100644
> --- a/meta-networking/recipes-connectivity/openthread/wpantund_git.bb
> +++ b/meta-networking/recipes-connectivity/openthread/wpantund_git.bb
> @@ -11,7 +11,7 @@ LIC_FILES_CHKSUM = "file://LICENSE;md5=e7820bc7f7d1638a6b54fc2e8d7fb103 \
>                       file://third_party/openthread/LICENSE;md5=543b6fe90ec5901a683320a36390c65f \
>                       file://third_party/pt/LICENSE;md5=dcd598b69cad786beea33da7b1ae14b7 \
>                       "
> -DEPENDS = "autoconf-archive dbus readline"
> +DEPENDS = "autoconf-archive dbus readline boost"
>   SRCREV = "0fb1f57e4224e2df3e630e146702bfcf63fbf07a"
>   PV = "0.07.01+git${SRCPV}"

LGTM

JFYI the project does have an internal copy of boost in the 
third_party/boost sub-folder (can be enabled by --with-boost=internal), 
but given its age I agree that we should rely on newer boost versions 
coming through OE.

regards
Stefan Schmidt

Patch

diff --git a/meta-networking/recipes-connectivity/openthread/wpantund_git.bb b/meta-networking/recipes-connectivity/openthread/wpantund_git.bb
index bb444d04f5..a7fcc202a4 100644
--- a/meta-networking/recipes-connectivity/openthread/wpantund_git.bb
+++ b/meta-networking/recipes-connectivity/openthread/wpantund_git.bb
@@ -11,7 +11,7 @@  LIC_FILES_CHKSUM = "file://LICENSE;md5=e7820bc7f7d1638a6b54fc2e8d7fb103 \
                     file://third_party/openthread/LICENSE;md5=543b6fe90ec5901a683320a36390c65f \
                     file://third_party/pt/LICENSE;md5=dcd598b69cad786beea33da7b1ae14b7 \
                     "
-DEPENDS = "autoconf-archive dbus readline"
+DEPENDS = "autoconf-archive dbus readline boost"
 SRCREV = "0fb1f57e4224e2df3e630e146702bfcf63fbf07a"
 PV = "0.07.01+git${SRCPV}"