Message ID | 20220309165840.267657-1-clemens.terasa@garz-fricke.com |
---|---|
State | New |
Headers | show |
Series | [meta-python,dunfell] python3-fasteners: Revert new override syntax | expand |
On Wed, Mar 9, 2022 at 8:58 AM Clemens Terasa via lists.openembedded.org <clemens.terasa=garz-fricke.com@lists.openembedded.org> wrote: > > Commit 7889158dcd187546fc5e99fd81d0779cad3e8d17 introduces a regression, > breaking a dunfell build. It adds a variable override of RDEPENDS with > the new colon based syntax, that was introduced with honister but is > incompatible with dunfell. > > Fix this by using the plain old underscore syntax. > > Signed-off-by: Clemens Terasa <clemens.terasa@garz-fricke.com> > --- > meta-python/recipes-devtools/python/python3-fasteners_0.16.3.bb | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meta-python/recipes-devtools/python/python3-fasteners_0.16.3.bb b/meta-python/recipes-devtools/python/python3-fasteners_0.16.3.bb > index 1ba2c6f20..7ebaa4590 100644 > --- a/meta-python/recipes-devtools/python/python3-fasteners_0.16.3.bb > +++ b/meta-python/recipes-devtools/python/python3-fasteners_0.16.3.bb > @@ -8,7 +8,7 @@ SRC_URI[sha256sum] = "b1ab4e5adfbc28681ce44b3024421c4f567e705cc3963c732bf1cba334 > > inherit pypi setuptools3 > > -RDEPENDS:${PN} += "\ > +RDEPENDS_${PN} += "\ perhaps you can try with latest dunfell release of bitbake and see if you still see the issue. > ${PYTHON_PN}-logging \ > ${PYTHON_PN}-fcntl \ > " > -- > 2.25.1 > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#95908): https://lists.openembedded.org/g/openembedded-devel/message/95908 > Mute This Topic: https://lists.openembedded.org/mt/89666632/1997914 > Group Owner: openembedded-devel+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [raj.khem@gmail.com] > -=-=-=-=-=-=-=-=-=-=-=- >
You are total right, my bad. I checked out the poky dunfell-23.0.11 tag, however, the BBSERVER was still running in the background and thus using the old bitbake. But shouldn't meta-openembedded be as compatible as possible? I am sure this habe been discussed dozens of times and I am ignorantly not researching enough. At least in this case I do not see a compelling cause to use the new override style, that might potentially break older poky/newer oe combinations. Nevertheless, this is a non-issue for me now and the patch can be discarded.
On Wed, Mar 9, 2022 at 11:19 PM Clemens Terasa via lists.openembedded.org <clemens.terasa=garz-fricke.com@lists.openembedded.org> wrote: > > You are total right, my bad. > > I checked out the poky dunfell-23.0.11 tag, however, the BBSERVER was still running in the background and thus using the old bitbake. > > But shouldn't meta-openembedded be as compatible as possible? I am sure this habe been discussed dozens of times and I am ignorantly not researching enough. > At least in this case I do not see a compelling cause to use the new override style, that might potentially break older poky/newer oe combinations. > meta-openembedded does not get tagged for point releases, so its left upto end users to integrate it with a given point release, however maintainers always make sure that latest release branch work with latest core branch tip. > Nevertheless, this is a non-issue for me now and the patch can be discarded. > > > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#95920): https://lists.openembedded.org/g/openembedded-devel/message/95920 > Mute This Topic: https://lists.openembedded.org/mt/89666632/1997914 > Group Owner: openembedded-devel+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [raj.khem@gmail.com] > -=-=-=-=-=-=-=-=-=-=-=- >
diff --git a/meta-python/recipes-devtools/python/python3-fasteners_0.16.3.bb b/meta-python/recipes-devtools/python/python3-fasteners_0.16.3.bb index 1ba2c6f20..7ebaa4590 100644 --- a/meta-python/recipes-devtools/python/python3-fasteners_0.16.3.bb +++ b/meta-python/recipes-devtools/python/python3-fasteners_0.16.3.bb @@ -8,7 +8,7 @@ SRC_URI[sha256sum] = "b1ab4e5adfbc28681ce44b3024421c4f567e705cc3963c732bf1cba334 inherit pypi setuptools3 -RDEPENDS:${PN} += "\ +RDEPENDS_${PN} += "\ ${PYTHON_PN}-logging \ ${PYTHON_PN}-fcntl \ "
Commit 7889158dcd187546fc5e99fd81d0779cad3e8d17 introduces a regression, breaking a dunfell build. It adds a variable override of RDEPENDS with the new colon based syntax, that was introduced with honister but is incompatible with dunfell. Fix this by using the plain old underscore syntax. Signed-off-by: Clemens Terasa <clemens.terasa@garz-fricke.com> --- meta-python/recipes-devtools/python/python3-fasteners_0.16.3.bb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)