dev-manual: update example from kernel.bbclass

Message ID 20220214161732.15475-1-ceggers@arri.de
State New
Headers show
Series dev-manual: update example from kernel.bbclass | expand

Commit Message

Christian Eggers Feb. 14, 2022, 4:17 p.m. UTC
Since f7485646534e ("kernel: provide virtual/kernel for all kernels"),
all recipes which inherit kernel.bbclass provide "virtual/kernel",
independent of the value of `KERNEL_PACKAGE_NAME`.

Signed-off-by: Christian Eggers <ceggers@arri.de>
---
 documentation/dev-manual/common-tasks.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Quentin Schulz Feb. 14, 2022, 4:24 p.m. UTC | #1
Hi Christian,

On 2/14/22 17:17, Christian Eggers wrote:
> Since f7485646534e ("kernel: provide virtual/kernel for all kernels"),
> all recipes which inherit kernel.bbclass provide "virtual/kernel",
> independent of the value of `KERNEL_PACKAGE_NAME`.
> 
> Signed-off-by: Christian Eggers <ceggers@arri.de>
> ---
>   documentation/dev-manual/common-tasks.rst | 2 +-

Documentation patches have a different mailing list:
docs@lists.yoctoproject.org

I've added it to the Cc recipients now so there's probably no need to 
resend this patch :)

Reviewed-by: Quentin Schulz <foss+yocto@0leil.net>

Thanks!
Quentin

>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/documentation/dev-manual/common-tasks.rst b/documentation/dev-manual/common-tasks.rst
> index d35b590ee185..1856d4c3ad53 100644
> --- a/documentation/dev-manual/common-tasks.rst
> +++ b/documentation/dev-manual/common-tasks.rst
> @@ -2114,7 +2114,7 @@ statement that essentially identifies itself as being able to provide
>   ``virtual/kernel``. Here is one way through the
>   :ref:`kernel <ref-classes-kernel>` class::
>   
> -   PROVIDES += "${@ "virtual/kernel" if (d.getVar("KERNEL_PACKAGE_NAME") == "kernel") else "" }"
> +   PROVIDES += "virtual/kernel"
>   
>   Any recipe that inherits the :ref:`kernel <ref-classes-kernel>` class is
>   going to utilize a :term:`PROVIDES` statement that identifies that recipe as
> 
> 
> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#161720): https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.openembedded.org_g_openembedded-2Dcore_message_161720&d=DwIFaQ&c=_sEr5x9kUWhuk4_nFwjJtA&r=LYjLexDn7rXIzVmkNPvw5ymA1XTSqHGq8yBP6m6qZZ4njZguQhZhkI_-172IIy1t&m=salAEUm68GxBGyubcIEZm7DlS2JuU299YHtwFVvdku4TXcRTz7k6L98QiNORDzyn&s=yb7bX1jX1xE8QIx_Y-4hA2wxpHIzvQ-R0z7PhOjKg0U&e=
> Mute This Topic: https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.openembedded.org_mt_89139800_6293953&d=DwIFaQ&c=_sEr5x9kUWhuk4_nFwjJtA&r=LYjLexDn7rXIzVmkNPvw5ymA1XTSqHGq8yBP6m6qZZ4njZguQhZhkI_-172IIy1t&m=salAEUm68GxBGyubcIEZm7DlS2JuU299YHtwFVvdku4TXcRTz7k6L98QiNORDzyn&s=rqOLvOISOuPJeW8U1uMkNgMKxm2zqe0rVzTY65ZS8tQ&e=
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.openembedded.org_g_openembedded-2Dcore_unsub&d=DwIFaQ&c=_sEr5x9kUWhuk4_nFwjJtA&r=LYjLexDn7rXIzVmkNPvw5ymA1XTSqHGq8yBP6m6qZZ4njZguQhZhkI_-172IIy1t&m=salAEUm68GxBGyubcIEZm7DlS2JuU299YHtwFVvdku4TXcRTz7k6L98QiNORDzyn&s=hHHCrO6CSCWViAWJPJVnjLNTDeJOH1UeVVwObe-282Y&e=  [quentin.schulz@theobroma-systems.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
Michael Opdenacker Feb. 14, 2022, 5:10 p.m. UTC | #2
On 2/14/22 17:24, Quentin Schulz wrote:
> Hi Christian,
>
> On 2/14/22 17:17, Christian Eggers wrote:
>> Since f7485646534e ("kernel: provide virtual/kernel for all kernels"),
>> all recipes which inherit kernel.bbclass provide "virtual/kernel",
>> independent of the value of `KERNEL_PACKAGE_NAME`.
>>
>> Signed-off-by: Christian Eggers <ceggers@arri.de>
>> ---
>>   documentation/dev-manual/common-tasks.rst | 2 +-
>
> Documentation patches have a different mailing list:
> docs@lists.yoctoproject.org
>
> I've added it to the Cc recipients now so there's probably no need to
> resend this patch :)
>
> Reviewed-by: Quentin Schulz <foss+yocto@0leil.net>


Indeed. Thanks to Quentin´s review I merged your patch into the
"master-next" branch of the yocto-docs repository.
Many thanks for the update!
Michael.

Patch

diff --git a/documentation/dev-manual/common-tasks.rst b/documentation/dev-manual/common-tasks.rst
index d35b590ee185..1856d4c3ad53 100644
--- a/documentation/dev-manual/common-tasks.rst
+++ b/documentation/dev-manual/common-tasks.rst
@@ -2114,7 +2114,7 @@  statement that essentially identifies itself as being able to provide
 ``virtual/kernel``. Here is one way through the
 :ref:`kernel <ref-classes-kernel>` class::
 
-   PROVIDES += "${@ "virtual/kernel" if (d.getVar("KERNEL_PACKAGE_NAME") == "kernel") else "" }"
+   PROVIDES += "virtual/kernel"
 
 Any recipe that inherits the :ref:`kernel <ref-classes-kernel>` class is
 going to utilize a :term:`PROVIDES` statement that identifies that recipe as