diff mbox series

create-spdx: Ensure it is clear where the message comes from

Message ID 20230925132919.1910323-1-richard.purdie@linuxfoundation.org
State Accepted, archived
Commit ddcf15134b5ec4bf4c728156461c2e45194d71ca
Headers show
Series create-spdx: Ensure it is clear where the message comes from | expand

Commit Message

Richard Purdie Sept. 25, 2023, 1:29 p.m. UTC
This message can appear in do_rootfs and the users tend to think this is
some kind of packaging issue. Add SPDX to the message so users like me
think in the right direction.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---
 meta/classes/create-spdx-2.2.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Bruce Ashfield Sept. 25, 2023, 1:33 p.m. UTC | #1
On Mon, Sep 25, 2023 at 9:29 AM Richard Purdie <
richard.purdie@linuxfoundation.org> wrote:

> This message can appear in do_rootfs and the users tend to think this is
> some kind of packaging issue. Add SPDX to the message so users like me
> think in the right direction.
>

This user definitely did!

Although hard to trigger, I know this will save a poor soul some time if
they do manage to hit the condition.

Bruce



>
> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> ---
>  meta/classes/create-spdx-2.2.bbclass | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/classes/create-spdx-2.2.bbclass
> b/meta/classes/create-spdx-2.2.bbclass
> index 885f07a1f87..3ee1b7ee0d8 100644
> --- a/meta/classes/create-spdx-2.2.bbclass
> +++ b/meta/classes/create-spdx-2.2.bbclass
> @@ -1031,7 +1031,7 @@ def combine_spdx(d, rootfs_name, rootfs_deploydir,
> rootfs_spdxid, packages, spdx
>
>      for name in sorted(packages.keys()):
>          if name not in providers:
> -            bb.fatal("Unable to find provider for '%s'" % name)
> +            bb.fatal("Unable to find SPDX provider for '%s'" % name)
>
>          pkg_name, pkg_hashfn = providers[name]
>
> --
> 2.39.2
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#188189):
> https://lists.openembedded.org/g/openembedded-core/message/188189
> Mute This Topic: https://lists.openembedded.org/mt/101573796/1050810
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [
> bruce.ashfield@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
>
diff mbox series

Patch

diff --git a/meta/classes/create-spdx-2.2.bbclass b/meta/classes/create-spdx-2.2.bbclass
index 885f07a1f87..3ee1b7ee0d8 100644
--- a/meta/classes/create-spdx-2.2.bbclass
+++ b/meta/classes/create-spdx-2.2.bbclass
@@ -1031,7 +1031,7 @@  def combine_spdx(d, rootfs_name, rootfs_deploydir, rootfs_spdxid, packages, spdx
 
     for name in sorted(packages.keys()):
         if name not in providers:
-            bb.fatal("Unable to find provider for '%s'" % name)
+            bb.fatal("Unable to find SPDX provider for '%s'" % name)
 
         pkg_name, pkg_hashfn = providers[name]