Message ID | 20230920054733.2852549-1-raj.khem@gmail.com |
---|---|
State | New |
Headers | show |
Series | gettext: Disable error_at_line detection for musl | expand |
On Tue, 2023-09-19 at 22:47 -0700, Khem Raj wrote: > Signed-off-by: Khem Raj <raj.khem@gmail.com> > --- > meta/recipes-core/gettext/gettext_0.22.bb | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/meta/recipes-core/gettext/gettext_0.22.bb b/meta/recipes-core/gettext/gettext_0.22.bb > index f5290ac0e44..91db6627748 100644 > --- a/meta/recipes-core/gettext/gettext_0.22.bb > +++ b/meta/recipes-core/gettext/gettext_0.22.bb > @@ -53,6 +53,7 @@ EXTRA_OECONF:append:class-target = " \ > gt_cv_locale_de_utf8=de_DE \ > gt_cv_locale_de=de_DE.ISO-8859-1 \ > " > +EXTRA_OECONF:append:libc-musl = " ac_cv_lib_error_at_line=no" > > PACKAGECONFIG ??= "croco glib libxml" > PACKAGECONFIG:class-native = "" Is this something which should be in the musl site file? Cheers, Richard
On Wed, Sep 20, 2023 at 12:54 AM Richard Purdie < richard.purdie@linuxfoundation.org> wrote: > On Tue, 2023-09-19 at 22:47 -0700, Khem Raj wrote: > > Signed-off-by: Khem Raj <raj.khem@gmail.com> > > --- > > meta/recipes-core/gettext/gettext_0.22.bb | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/meta/recipes-core/gettext/gettext_0.22.bb > b/meta/recipes-core/gettext/gettext_0.22.bb > > index f5290ac0e44..91db6627748 100644 > > --- a/meta/recipes-core/gettext/gettext_0.22.bb > > +++ b/meta/recipes-core/gettext/gettext_0.22.bb > > @@ -53,6 +53,7 @@ EXTRA_OECONF:append:class-target = " \ > > gt_cv_locale_de_utf8=de_DE \ > > gt_cv_locale_de=de_DE.ISO-8859-1 \ > > " > > +EXTRA_OECONF:append:libc-musl = " ac_cv_lib_error_at_line=no" > > > > PACKAGECONFIG ??= "croco glib libxml" > > PACKAGECONFIG:class-native = "" > > Is this something which should be in the musl site file? I was thinking on same lines but then I wanted to see how many packages would need it. It seems it’s packaged using gnulib that need it but then not all. Adding to site files is a bigger hammer I want to see the length and breadth of its impact I will refactor the bsd-headers patch to keep the error.h a bit more > > Cheers, > > Richard >
On Wed, 2023-09-20 at 07:46 -0700, Khem Raj wrote: > > > On Wed, Sep 20, 2023 at 12:54 AM Richard Purdie > <richard.purdie@linuxfoundation.org> wrote: > > On Tue, 2023-09-19 at 22:47 -0700, Khem Raj wrote: > > > Signed-off-by: Khem Raj <raj.khem@gmail.com> > > > --- > > > meta/recipes-core/gettext/gettext_0.22.bb | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/meta/recipes-core/gettext/gettext_0.22.bb > > > b/meta/recipes-core/gettext/gettext_0.22.bb > > > index f5290ac0e44..91db6627748 100644 > > > --- a/meta/recipes-core/gettext/gettext_0.22.bb > > > +++ b/meta/recipes-core/gettext/gettext_0.22.bb > > > @@ -53,6 +53,7 @@ EXTRA_OECONF:append:class-target = " \ > > > gt_cv_locale_de_utf8=de_DE \ > > > gt_cv_locale_de=de_DE.ISO-8859-1 \ > > > " > > > +EXTRA_OECONF:append:libc-musl = " ac_cv_lib_error_at_line=no" > > > > > > PACKAGECONFIG ??= "croco glib libxml" > > > PACKAGECONFIG:class-native = "" > > > > Is this something which should be in the musl site file? > > > > > I was thinking on same lines but then I wanted to see how many > packages would need it. It seems it’s packaged using gnulib that need > it but then not all. Adding to site files is a bigger hammer I want > to see the length and breadth of its impact > > I will refactor the bsd-headers patch to keep the error.h a bit more > I think the site file does make more sense for this. Given I know you heard my comments yesterday about stabilising for release, if you're going to send "test" changes like this could you please at least note that in the commit message? I really could do without debugging things for people at this point in the release cycle. Cheers, Richard
diff --git a/meta/recipes-core/gettext/gettext_0.22.bb b/meta/recipes-core/gettext/gettext_0.22.bb index f5290ac0e44..91db6627748 100644 --- a/meta/recipes-core/gettext/gettext_0.22.bb +++ b/meta/recipes-core/gettext/gettext_0.22.bb @@ -53,6 +53,7 @@ EXTRA_OECONF:append:class-target = " \ gt_cv_locale_de_utf8=de_DE \ gt_cv_locale_de=de_DE.ISO-8859-1 \ " +EXTRA_OECONF:append:libc-musl = " ac_cv_lib_error_at_line=no" PACKAGECONFIG ??= "croco glib libxml" PACKAGECONFIG:class-native = ""
Signed-off-by: Khem Raj <raj.khem@gmail.com> --- meta/recipes-core/gettext/gettext_0.22.bb | 1 + 1 file changed, 1 insertion(+)