Message ID | 20230906151247.312252-1-ross.burton@arm.com |
---|---|
State | Accepted, archived |
Commit | b29028a12cfa6747ba83e63e03e4ec9c8064c667 |
Headers | show |
Series | glib-2.0: explicitly enable strlcpy() | expand |
On Wed, Sep 6, 2023 at 8:12 AM Ross Burton <ross.burton@arm.com> wrote: > > From: Ross Burton <ross.burton@arm.com> > > We have glibc 2.38 which added strlcpy(), so enable the use of it > explicitly in the Meson cross file for when the target doesn't support > qemu-usermode (which will result in the default of not using it). will this be effective for non-target variants too ? In that case we may not have glibc 2.38 on all distros yet. > > Signed-off-by: Ross Burton <ross.burton@arm.com> > --- > meta/recipes-core/glib-2.0/glib-2.0/meson.cross.d/common-glibc | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/meta/recipes-core/glib-2.0/glib-2.0/meson.cross.d/common-glibc b/meta/recipes-core/glib-2.0/glib-2.0/meson.cross.d/common-glibc > index c4648f58c78..3049e5116ec 100644 > --- a/meta/recipes-core/glib-2.0/glib-2.0/meson.cross.d/common-glibc > +++ b/meta/recipes-core/glib-2.0/glib-2.0/meson.cross.d/common-glibc > @@ -3,3 +3,4 @@ have_c99_vsnprintf = true > have_c99_snprintf = true > have_unix98_printf = true > va_val_copy = true > +have_strlcpy = true > -- > 2.34.1 > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#187319): https://lists.openembedded.org/g/openembedded-core/message/187319 > Mute This Topic: https://lists.openembedded.org/mt/101194848/1997914 > Group Owner: openembedded-core+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [raj.khem@gmail.com] > -=-=-=-=-=-=-=-=-=-=-=- >
On 6 Sep 2023, at 18:30, Khem Raj <raj.khem@gmail.com> wrote: > > On Wed, Sep 6, 2023 at 8:12 AM Ross Burton <ross.burton@arm.com> wrote: >> >> From: Ross Burton <ross.burton@arm.com> >> >> We have glibc 2.38 which added strlcpy(), so enable the use of it >> explicitly in the Meson cross file for when the target doesn't support >> qemu-usermode (which will result in the default of not using it). > > will this be effective for non-target variants too ? In that case we > may not have > glibc 2.38 on all distros yet. The extra cross file logic is not used in native builds. Ross
On Wed, Sep 6, 2023 at 11:07 AM Ross Burton <Ross.Burton@arm.com> wrote: > On 6 Sep 2023, at 18:30, Khem Raj <raj.khem@gmail.com> wrote: > > > > On Wed, Sep 6, 2023 at 8:12 AM Ross Burton <ross.burton@arm.com> wrote: > >> > >> From: Ross Burton <ross.burton@arm.com> > >> > >> We have glibc 2.38 which added strlcpy(), so enable the use of it > >> explicitly in the Meson cross file for when the target doesn't support > >> qemu-usermode (which will result in the default of not using it). > > > > will this be effective for non-target variants too ? In that case we > > may not have > > glibc 2.38 on all distros yet. > > The extra cross file logic is not used in native builds. Superb and I checked that this is already set for musl cross file so all good > > Ross
diff --git a/meta/recipes-core/glib-2.0/glib-2.0/meson.cross.d/common-glibc b/meta/recipes-core/glib-2.0/glib-2.0/meson.cross.d/common-glibc index c4648f58c78..3049e5116ec 100644 --- a/meta/recipes-core/glib-2.0/glib-2.0/meson.cross.d/common-glibc +++ b/meta/recipes-core/glib-2.0/glib-2.0/meson.cross.d/common-glibc @@ -3,3 +3,4 @@ have_c99_vsnprintf = true have_c99_snprintf = true have_unix98_printf = true va_val_copy = true +have_strlcpy = true