diff mbox series

[meta-oe,PATCHv3] xsetroot: upgrade 1.1.2 -> 1.1.3

Message ID 20231208074344.24233-1-alperyasinak1@gmail.com
State Accepted, archived
Headers show
Series [meta-oe,PATCHv3] xsetroot: upgrade 1.1.2 -> 1.1.3 | expand

Commit Message

Alper Ak Dec. 8, 2023, 7:43 a.m. UTC
Changelog:

* gitlab CI: stop requiring Signed-off-by in commits
* Handle -Wsign-compare warnings
* Variable scope reductions as recommended by cppcheck
* Build xz tarballs instead of bzip2
* CI: add a basic build test
* Update configure.ac bug URL for gitlab migration
* Update README for gitlab migration

Signed-off-by: alperak <alperyasinak1@gmail.com>
---
 v2, used xz instead of gz
 v3, added lixmu package to fix build issue

 .../xorg-app/{xsetroot_1.1.2.bb => xsetroot_1.1.3.bb}       | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
 rename meta-oe/recipes-graphics/xorg-app/{xsetroot_1.1.2.bb => xsetroot_1.1.3.bb} (66%)

Comments

Ross Burton Dec. 8, 2023, 10:25 a.m. UTC | #1
On 8 Dec 2023, at 07:43, Alper Ak via lists.openembedded.org <alperyasinak1=gmail.com@lists.openembedded.org> wrote:
> 
> Changelog:
> 
> * gitlab CI: stop requiring Signed-off-by in commits
> * Handle -Wsign-compare warnings
> * Variable scope reductions as recommended by cppcheck
> * Build xz tarballs instead of bzip2
> * CI: add a basic build test
> * Update configure.ac bug URL for gitlab migration
> * Update README for gitlab migration
> 
> Signed-off-by: alperak <alperyasinak1@gmail.com>
> ---
> v2, used xz instead of gz
> v3, added lixmu package to fix build issue

This is odd. 

Nothing in the changelog to suggest a new dependency (and the classic xorg apps haven’t been touched for literally a decade now). So did the old recipe not build either, or did something else change (like new xbitmaps dropped the libxmu dependency, so it wasn’t pulled in).

Ross
diff mbox series

Patch

diff --git a/meta-oe/recipes-graphics/xorg-app/xsetroot_1.1.2.bb b/meta-oe/recipes-graphics/xorg-app/xsetroot_1.1.3.bb
similarity index 66%
rename from meta-oe/recipes-graphics/xorg-app/xsetroot_1.1.2.bb
rename to meta-oe/recipes-graphics/xorg-app/xsetroot_1.1.3.bb
index a9a8acf05..7e909f90c 100644
--- a/meta-oe/recipes-graphics/xorg-app/xsetroot_1.1.2.bb
+++ b/meta-oe/recipes-graphics/xorg-app/xsetroot_1.1.3.bb
@@ -7,7 +7,7 @@  SECTION = "x11/app"
 LICENSE = "MIT"
 LIC_FILES_CHKSUM = "file://COPYING;md5=6ea29dbee22324787c061f039e0529de"
 
-DEPENDS += "xbitmaps libxcursor"
+DEPENDS += "xbitmaps libxcursor libxmu"
 
-SRC_URI[md5sum] = "5fe769c8777a6e873ed1305e4ce2c353"
-SRC_URI[sha256sum] = "10c442ba23591fb5470cea477a0aa5f679371f4f879c8387a1d9d05637ae417c"
+SRC_URI_EXT = "xz"
+SRC_URI[sha256sum] = "6081b45a9eb4426e045d259d1e144b32417fb635e5b96aa90647365ac96638d1"