diff mbox series

[3/6] firewalld: add features_check on gobject-introspection-data

Message ID 20230524171438.122588-3-ross.burton@arm.com
State Under Review
Headers show
Series [1/6] python3-pydbus-manager: remove obsolete recipe | expand

Commit Message

Ross Burton May 24, 2023, 5:14 p.m. UTC
From: Ross Burton <ross.burton@arm.com>

This project uses gobject-introspection, so depend on the DISTRO_FEATURE.

Signed-off-by: Ross Burton <ross.burton@arm.com>
---
 .../recipes-connectivity/firewalld/firewalld_1.2.0.bb         | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Khem Raj May 24, 2023, 11:07 p.m. UTC | #1
I see some more fallouts with this

https://autobuilder.yoctoproject.org/typhoon/#/builders/88/builds/2772

On Wed, May 24, 2023 at 10:14 AM Ross Burton <ross.burton@arm.com> wrote:
>
> From: Ross Burton <ross.burton@arm.com>
>
> This project uses gobject-introspection, so depend on the DISTRO_FEATURE.
>
> Signed-off-by: Ross Burton <ross.burton@arm.com>
> ---
>  .../recipes-connectivity/firewalld/firewalld_1.2.0.bb         | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/meta-networking/dynamic-layers/meta-python/recipes-connectivity/firewalld/firewalld_1.2.0.bb b/meta-networking/dynamic-layers/meta-python/recipes-connectivity/firewalld/firewalld_1.2.0.bb
> index 987cc640e1..8efbd39f74 100644
> --- a/meta-networking/dynamic-layers/meta-python/recipes-connectivity/firewalld/firewalld_1.2.0.bb
> +++ b/meta-networking/dynamic-layers/meta-python/recipes-connectivity/firewalld/firewalld_1.2.0.bb
> @@ -15,7 +15,9 @@ SRC_URI[sha256sum] = "28fd90e88bda0dfd460f370f353474811b2e295d7eb27f0d7d18ffa3d7
>  # glib-2.0-native is needed for GSETTINGS_RULES autoconf macro from gsettings.m4
>  DEPENDS = "intltool-native glib-2.0-native nftables"
>
> -inherit gettext autotools-brokensep bash-completion pkgconfig python3native python3-dir gsettings systemd update-rc.d ptest
> +inherit gettext autotools-brokensep bash-completion pkgconfig python3native python3-dir gsettings systemd update-rc.d ptest features_check
> +
> +REQUIRED_DISTRO_FEATURES = "gobject-introspection"
>
>  PACKAGECONFIG ??= "${@bb.utils.filter('DISTRO_FEATURES', 'systemd', d)}"
>  PACKAGECONFIG[systemd] = "--with-systemd-unitdir=${systemd_system_unitdir},--disable-systemd"
> --
> 2.34.1
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#102787): https://lists.openembedded.org/g/openembedded-devel/message/102787
> Mute This Topic: https://lists.openembedded.org/mt/99113395/1997914
> Group Owner: openembedded-devel+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [raj.khem@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
Ross Burton May 25, 2023, 12:14 p.m. UTC | #2
I did a world build with G-I disabled, patch bomb sent.

Ross

> On 25 May 2023, at 00:07, Khem Raj <raj.khem@gmail.com> wrote:
> 
> I see some more fallouts with this
> 
> https://autobuilder.yoctoproject.org/typhoon/#/builders/88/builds/2772
> 
> On Wed, May 24, 2023 at 10:14 AM Ross Burton <ross.burton@arm.com> wrote:
>> 
>> From: Ross Burton <ross.burton@arm.com>
>> 
>> This project uses gobject-introspection, so depend on the DISTRO_FEATURE.
>> 
>> Signed-off-by: Ross Burton <ross.burton@arm.com>
>> ---
>> .../recipes-connectivity/firewalld/firewalld_1.2.0.bb         | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>> 
>> diff --git a/meta-networking/dynamic-layers/meta-python/recipes-connectivity/firewalld/firewalld_1.2.0.bb b/meta-networking/dynamic-layers/meta-python/recipes-connectivity/firewalld/firewalld_1.2.0.bb
>> index 987cc640e1..8efbd39f74 100644
>> --- a/meta-networking/dynamic-layers/meta-python/recipes-connectivity/firewalld/firewalld_1.2.0.bb
>> +++ b/meta-networking/dynamic-layers/meta-python/recipes-connectivity/firewalld/firewalld_1.2.0.bb
>> @@ -15,7 +15,9 @@ SRC_URI[sha256sum] = "28fd90e88bda0dfd460f370f353474811b2e295d7eb27f0d7d18ffa3d7
>> # glib-2.0-native is needed for GSETTINGS_RULES autoconf macro from gsettings.m4
>> DEPENDS = "intltool-native glib-2.0-native nftables"
>> 
>> -inherit gettext autotools-brokensep bash-completion pkgconfig python3native python3-dir gsettings systemd update-rc.d ptest
>> +inherit gettext autotools-brokensep bash-completion pkgconfig python3native python3-dir gsettings systemd update-rc.d ptest features_check
>> +
>> +REQUIRED_DISTRO_FEATURES = "gobject-introspection"
>> 
>> PACKAGECONFIG ??= "${@bb.utils.filter('DISTRO_FEATURES', 'systemd', d)}"
>> PACKAGECONFIG[systemd] = "--with-systemd-unitdir=${systemd_system_unitdir},--disable-systemd"
>> --
>> 2.34.1
>> 
>> 
>> -=-=-=-=-=-=-=-=-=-=-=-
>> Links: You receive all messages sent to this group.
>> View/Reply Online (#102787): https://lists.openembedded.org/g/openembedded-devel/message/102787
>> Mute This Topic: https://lists.openembedded.org/mt/99113395/1997914
>> Group Owner: openembedded-devel+owner@lists.openembedded.org
>> Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [raj.khem@gmail.com]
>> -=-=-=-=-=-=-=-=-=-=-=-
Martin Jansa May 25, 2023, 7:02 p.m. UTC | #3
Thanks, now I see only the dbusmock in oe-core issue in my world builds.

On Thu, May 25, 2023 at 2:15 PM Ross Burton <ross.burton@arm.com> wrote:

> I did a world build with G-I disabled, patch bomb sent.
>
> Ross
>
> > On 25 May 2023, at 00:07, Khem Raj <raj.khem@gmail.com> wrote:
> >
> > I see some more fallouts with this
> >
> > https://autobuilder.yoctoproject.org/typhoon/#/builders/88/builds/2772
> >
> > On Wed, May 24, 2023 at 10:14 AM Ross Burton <ross.burton@arm.com>
> wrote:
> >>
> >> From: Ross Burton <ross.burton@arm.com>
> >>
> >> This project uses gobject-introspection, so depend on the
> DISTRO_FEATURE.
> >>
> >> Signed-off-by: Ross Burton <ross.burton@arm.com>
> >> ---
> >> .../recipes-connectivity/firewalld/firewalld_1.2.0.bb         | 4 +++-
> >> 1 file changed, 3 insertions(+), 1 deletion(-)
> >>
> >> diff --git
> a/meta-networking/dynamic-layers/meta-python/recipes-connectivity/firewalld/
> firewalld_1.2.0.bb
> b/meta-networking/dynamic-layers/meta-python/recipes-connectivity/firewalld/
> firewalld_1.2.0.bb
> >> index 987cc640e1..8efbd39f74 100644
> >> ---
> a/meta-networking/dynamic-layers/meta-python/recipes-connectivity/firewalld/
> firewalld_1.2.0.bb
> >> +++
> b/meta-networking/dynamic-layers/meta-python/recipes-connectivity/firewalld/
> firewalld_1.2.0.bb
> >> @@ -15,7 +15,9 @@ SRC_URI[sha256sum] =
> "28fd90e88bda0dfd460f370f353474811b2e295d7eb27f0d7d18ffa3d7
> >> # glib-2.0-native is needed for GSETTINGS_RULES autoconf macro from
> gsettings.m4
> >> DEPENDS = "intltool-native glib-2.0-native nftables"
> >>
> >> -inherit gettext autotools-brokensep bash-completion pkgconfig
> python3native python3-dir gsettings systemd update-rc.d ptest
> >> +inherit gettext autotools-brokensep bash-completion pkgconfig
> python3native python3-dir gsettings systemd update-rc.d ptest features_check
> >> +
> >> +REQUIRED_DISTRO_FEATURES = "gobject-introspection"
> >>
> >> PACKAGECONFIG ??= "${@bb.utils.filter('DISTRO_FEATURES', 'systemd', d)}"
> >> PACKAGECONFIG[systemd] =
> "--with-systemd-unitdir=${systemd_system_unitdir},--disable-systemd"
> >> --
> >> 2.34.1
> >>
> >>
> >>
>
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#102858):
> https://lists.openembedded.org/g/openembedded-devel/message/102858
> Mute This Topic: https://lists.openembedded.org/mt/99113395/3617156
> Group Owner: openembedded-devel+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [
> Martin.Jansa@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
>
diff mbox series

Patch

diff --git a/meta-networking/dynamic-layers/meta-python/recipes-connectivity/firewalld/firewalld_1.2.0.bb b/meta-networking/dynamic-layers/meta-python/recipes-connectivity/firewalld/firewalld_1.2.0.bb
index 987cc640e1..8efbd39f74 100644
--- a/meta-networking/dynamic-layers/meta-python/recipes-connectivity/firewalld/firewalld_1.2.0.bb
+++ b/meta-networking/dynamic-layers/meta-python/recipes-connectivity/firewalld/firewalld_1.2.0.bb
@@ -15,7 +15,9 @@  SRC_URI[sha256sum] = "28fd90e88bda0dfd460f370f353474811b2e295d7eb27f0d7d18ffa3d7
 # glib-2.0-native is needed for GSETTINGS_RULES autoconf macro from gsettings.m4
 DEPENDS = "intltool-native glib-2.0-native nftables"
 
-inherit gettext autotools-brokensep bash-completion pkgconfig python3native python3-dir gsettings systemd update-rc.d ptest
+inherit gettext autotools-brokensep bash-completion pkgconfig python3native python3-dir gsettings systemd update-rc.d ptest features_check
+
+REQUIRED_DISTRO_FEATURES = "gobject-introspection"
 
 PACKAGECONFIG ??= "${@bb.utils.filter('DISTRO_FEATURES', 'systemd', d)}"
 PACKAGECONFIG[systemd] = "--with-systemd-unitdir=${systemd_system_unitdir},--disable-systemd"