diff mbox series

[meta-python,2/3] python3-django: make 3.2.x as default version

Message ID 20220823172602.212-2-workjagadeesh@gmail.com
State Under Review
Headers show
Series [meta-python,1/3] python3-asgiref: add recipe | expand

Commit Message

Jagadeesh Krishnanjanappa Aug. 23, 2022, 5:26 p.m. UTC
According to https://www.djangoproject.com/download/ python3-django
3.2.x has LTS support upto 2024, hence make it as default version
to build.
Also, add runtime dependency on python3-asgiref as the "django-admin"
script needs asgiref module.

More info: https://bugzilla.yoctoproject.org/show_bug.cgi?id=14888

Signed-off-by: Jagadeesh Krishnanjanappa <workjagadeesh@gmail.com>
---
 .../recipes-devtools/python/python3-django_3.2.12.bb        | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

Comments

Khem Raj Aug. 23, 2022, 6:23 p.m. UTC | #1
On Tue, Aug 23, 2022 at 10:26 AM Jagadeesh Krishnanjanappa
<workjagadeesh@gmail.com> wrote:
>
> According to https://www.djangoproject.com/download/ python3-django
> 3.2.x has LTS support upto 2024, hence make it as default version
> to build.

It seems 2.2 LTS went EOL  on April 11, 2022, can you also send a
patch to remove those recipes while you are here.

> Also, add runtime dependency on python3-asgiref as the "django-admin"
> script needs asgiref module.
>
> More info: https://bugzilla.yoctoproject.org/show_bug.cgi?id=14888
>
> Signed-off-by: Jagadeesh Krishnanjanappa <workjagadeesh@gmail.com>
> ---
>  .../recipes-devtools/python/python3-django_3.2.12.bb        | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/meta-python/recipes-devtools/python/python3-django_3.2.12.bb b/meta-python/recipes-devtools/python/python3-django_3.2.12.bb
> index adbc498bd..17d402d65 100644
> --- a/meta-python/recipes-devtools/python/python3-django_3.2.12.bb
> +++ b/meta-python/recipes-devtools/python/python3-django_3.2.12.bb
> @@ -5,9 +5,5 @@ SRC_URI[sha256sum] = "9772e6935703e59e993960832d66a614cf0233a1c5123bc6224ecc6ad6
>
>  RDEPENDS:${PN} += "\
>      ${PYTHON_PN}-sqlparse \
> +    ${PYTHON_PN}-asgiref \
>  "
> -
> -# Set DEFAULT_PREFERENCE so that the LTS version of django is built by
> -# default. To build the 3.x branch,
> -# PREFERRED_VERSION_python3-django = "3.2.2" can be added to local.conf
> -DEFAULT_PREFERENCE = "-1"
> --
> 2.17.1
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#98398): https://lists.openembedded.org/g/openembedded-devel/message/98398
> Mute This Topic: https://lists.openembedded.org/mt/93209460/1997914
> Group Owner: openembedded-devel+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [raj.khem@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
Jagadeesh Krishnanjanappa Aug. 24, 2022, 2:09 a.m. UTC | #2
On Tue, Aug 23, 2022 at 11:53 PM Khem Raj <raj.khem@gmail.com> wrote:

> On Tue, Aug 23, 2022 at 10:26 AM Jagadeesh Krishnanjanappa
> <workjagadeesh@gmail.com> wrote:
> >
> > According to https://www.djangoproject.com/download/ python3-django
> > 3.2.x has LTS support upto 2024, hence make it as default version
> > to build.
>
> It seems 2.2 LTS went EOL  on April 11, 2022, can you also send a
> patch to remove those recipes while you are here.
>
> Sure. I was planning to send the patch to remove the recipe after these
patches are merged as it should not break the build. Now the patches
are merged and the remove patch is also sent.

Thanks,
Jagadeesh


> > Also, add runtime dependency on python3-asgiref as the "django-admin"
> > script needs asgiref module.
> >
> > More info: https://bugzilla.yoctoproject.org/show_bug.cgi?id=14888
> >
> > Signed-off-by: Jagadeesh Krishnanjanappa <workjagadeesh@gmail.com>
> > ---
> >  .../recipes-devtools/python/python3-django_3.2.12.bb        | 6 +-----
> >  1 file changed, 1 insertion(+), 5 deletions(-)
> >
> > diff --git a/meta-python/recipes-devtools/python/
> python3-django_3.2.12.bb b/meta-python/recipes-devtools/python/
> python3-django_3.2.12.bb
> > index adbc498bd..17d402d65 100644
> > --- a/meta-python/recipes-devtools/python/python3-django_3.2.12.bb
> > +++ b/meta-python/recipes-devtools/python/python3-django_3.2.12.bb
> > @@ -5,9 +5,5 @@ SRC_URI[sha256sum] =
> "9772e6935703e59e993960832d66a614cf0233a1c5123bc6224ecc6ad6
> >
> >  RDEPENDS:${PN} += "\
> >      ${PYTHON_PN}-sqlparse \
> > +    ${PYTHON_PN}-asgiref \
> >  "
> > -
> > -# Set DEFAULT_PREFERENCE so that the LTS version of django is built by
> > -# default. To build the 3.x branch,
> > -# PREFERRED_VERSION_python3-django = "3.2.2" can be added to local.conf
> > -DEFAULT_PREFERENCE = "-1"
> > --
> > 2.17.1
> >
> >
> > -=-=-=-=-=-=-=-=-=-=-=-
> > Links: You receive all messages sent to this group.
> > View/Reply Online (#98398):
> https://lists.openembedded.org/g/openembedded-devel/message/98398
> > Mute This Topic: https://lists.openembedded.org/mt/93209460/1997914
> > Group Owner: openembedded-devel+owner@lists.openembedded.org
> > Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [
> raj.khem@gmail.com]
> > -=-=-=-=-=-=-=-=-=-=-=-
> >
>
diff mbox series

Patch

diff --git a/meta-python/recipes-devtools/python/python3-django_3.2.12.bb b/meta-python/recipes-devtools/python/python3-django_3.2.12.bb
index adbc498bd..17d402d65 100644
--- a/meta-python/recipes-devtools/python/python3-django_3.2.12.bb
+++ b/meta-python/recipes-devtools/python/python3-django_3.2.12.bb
@@ -5,9 +5,5 @@  SRC_URI[sha256sum] = "9772e6935703e59e993960832d66a614cf0233a1c5123bc6224ecc6ad6
 
 RDEPENDS:${PN} += "\
     ${PYTHON_PN}-sqlparse \
+    ${PYTHON_PN}-asgiref \
 "
-
-# Set DEFAULT_PREFERENCE so that the LTS version of django is built by
-# default. To build the 3.x branch, 
-# PREFERRED_VERSION_python3-django = "3.2.2" can be added to local.conf
-DEFAULT_PREFERENCE = "-1"