| Message ID | 20220712091052.21871-1-alex.kiernan@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | [meta-networking,v2] nftables: Upgrade 1.0.2 -> 1.0.4 | expand |
I am seeing new build QA warnings related to python modules see https://autobuilder.yoctoproject.org/typhoon/#/builders/88/builds/1835 On Tue, Jul 12, 2022 at 10:13 AM Alex Kiernan <alex.kiernan@gmail.com> wrote: > > Drop backported patch, switch PACKAGECONFIG assignment to ?= (matches > current practice), add in editline, linenoise CLI options and xtables > option. Switch to --disable-python when building without python to avoid > a configure time warning. > > We can drop UPSTREAM_CHECK_REGEX as the version no longer gets confused > by the 0.099 version which exists. > > Signed-off-by: Alex Kiernan <alex.kiernan@gmail.com> > --- > ...-with-make-check-and-add-AM_CPPFLAGS.patch | 39 ------------------- > .../{nftables_1.0.2.bb => nftables_1.0.4.bb} | 16 ++++---- > 2 files changed, 8 insertions(+), 47 deletions(-) > delete mode 100644 meta-networking/recipes-filter/nftables/nftables/0001-examples-compile-with-make-check-and-add-AM_CPPFLAGS.patch > rename meta-networking/recipes-filter/nftables/{nftables_1.0.2.bb => nftables_1.0.4.bb} (77%) > > diff --git a/meta-networking/recipes-filter/nftables/nftables/0001-examples-compile-with-make-check-and-add-AM_CPPFLAGS.patch b/meta-networking/recipes-filter/nftables/nftables/0001-examples-compile-with-make-check-and-add-AM_CPPFLAGS.patch > deleted file mode 100644 > index 65ab2dfd8c49..000000000000 > --- a/meta-networking/recipes-filter/nftables/nftables/0001-examples-compile-with-make-check-and-add-AM_CPPFLAGS.patch > +++ /dev/null > @@ -1,39 +0,0 @@ > -From 18a08fb7f0443f8bde83393bd6f69e23a04246b3 Mon Sep 17 00:00:00 2001 > -From: Pablo Neira Ayuso <pablo@netfilter.org> > -Date: Tue, 22 Feb 2022 00:56:36 +0100 > -Subject: [PATCH] examples: compile with `make check' and add AM_CPPFLAGS > - > -Compile examples via `make check' like libnftnl does. Use AM_CPPFLAGS to > -specify local headers via -I. > - > -Unfortunately, `make distcheck' did not catch this compile time error in > -my system, since it was using the nftables/libnftables.h file of the > -previous nftables release. > - > -Fixes: 5b364657a35f ("build: missing SUBIRS update") > -Fixes: caf2a6ad2d22 ("examples: add libnftables example program") > -Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org> > - > -Upstream-Status: Backport > -[http://git.netfilter.org/nftables/commit/?id=18a08fb7f0443f8bde83393bd6f69e23a04246b3] > - > -Signed-off-by: Yi Zhao <yi.zhao@windriver.com> > ---- > - examples/Makefile.am | 4 +++- > - 1 file changed, 3 insertions(+), 1 deletion(-) > - > -diff --git a/examples/Makefile.am b/examples/Makefile.am > -index c972170d..3b8b0b67 100644 > ---- a/examples/Makefile.am > -+++ b/examples/Makefile.am > -@@ -1,4 +1,6 @@ > --noinst_PROGRAMS = nft-buffer \ > -+check_PROGRAMS = nft-buffer \ > - nft-json-file > - > -+AM_CPPFLAGS = -I$(top_srcdir)/include > -+ > - LDADD = $(top_builddir)/src/libnftables.la > --- > -2.25.1 > - > diff --git a/meta-networking/recipes-filter/nftables/nftables_1.0.2.bb b/meta-networking/recipes-filter/nftables/nftables_1.0.4.bb > similarity index 77% > rename from meta-networking/recipes-filter/nftables/nftables_1.0.2.bb > rename to meta-networking/recipes-filter/nftables/nftables_1.0.4.bb > index e078be79a1df..e2d0bd66812c 100644 > --- a/meta-networking/recipes-filter/nftables/nftables_1.0.2.bb > +++ b/meta-networking/recipes-filter/nftables/nftables_1.0.4.bb > @@ -6,26 +6,26 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=d1a78fdd879a263a5e0b42d1fc565e79" > DEPENDS = "libmnl libnftnl bison-native \ > ${@bb.utils.contains('PACKAGECONFIG', 'mini-gmp', '', 'gmp', d)}" > > -# Ensure we reject the 0.099 version by matching at least two dots > -UPSTREAM_CHECK_REGEX = "nftables-(?P<pver>\d+(\.\d+){2,}).tar.bz2" > - > SRC_URI = "http://www.netfilter.org/projects/nftables/files/${BP}.tar.bz2 \ > - file://0001-examples-compile-with-make-check-and-add-AM_CPPFLAGS.patch \ > file://run-ptest \ > " > > -SRC_URI[sha256sum] = "0b28a36ffcf4567b841de7bd3f37918b1fed27859eb48bdec51e1f7a83954c02" > +SRC_URI[sha256sum] = "927fb1fea1f685a328c10cf791eb655d7e1ed49d310eea5cb3101dfd8d6cba35" > > inherit autotools manpages pkgconfig ptest > > -PACKAGECONFIG ??= "python readline json" > +PACKAGECONFIG ?= "python readline json" > +PACKAGECONFIG[editline] = "--with-cli=editline, , libedit, , , linenoise readline" > PACKAGECONFIG[json] = "--with-json, --without-json, jansson" > +PACKAGECONFIG[linenoise] = "--with-cli=linenoise, , linenoise, , , editline readline" > PACKAGECONFIG[manpages] = "--enable-man-doc, --disable-man-doc, asciidoc-native" > PACKAGECONFIG[mini-gmp] = "--with-mini-gmp, --without-mini-gmp" > -PACKAGECONFIG[python] = "--enable-python --with-python-bin=${PYTHON}, --with-python-bin="", python3" > -PACKAGECONFIG[readline] = "--with-cli=readline, --without-cli, readline" > +PACKAGECONFIG[python] = "--enable-python --with-python-bin=${PYTHON}, --disable-python, python3" > +PACKAGECONFIG[readline] = "--with-cli=readline, , readline, , , editline linenoise" > PACKAGECONFIG[xtables] = "--with-xtables, --without-xtables, iptables" > > +EXTRA_OECONF = "${@bb.utils.contains_any('PACKAGECONFIG', 'editline linenoise readline', '', '--without-cli', d)}" > + > inherit ${@bb.utils.contains('PACKAGECONFIG', 'python', 'python3native', '', d)} > > RRECOMMENDS:${PN} += "kernel-module-nf-tables" > -- > 2.35.1 > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#97815): https://lists.openembedded.org/g/openembedded-devel/message/97815 > Mute This Topic: https://lists.openembedded.org/mt/92329338/1997914 > Group Owner: openembedded-devel+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [raj.khem@gmail.com] > -=-=-=-=-=-=-=-=-=-=-=- >
I figured sending it was useful, since the buildpaths warning wasn't a regression... but I think I just found the right setup.py incantation to fix that. On Tue, Jul 12, 2022 at 4:21 PM Khem Raj <raj.khem@gmail.com> wrote: > > I am seeing new build QA warnings related to python modules see > > https://autobuilder.yoctoproject.org/typhoon/#/builders/88/builds/1835 > > On Tue, Jul 12, 2022 at 10:13 AM Alex Kiernan <alex.kiernan@gmail.com> wrote: > > > > Drop backported patch, switch PACKAGECONFIG assignment to ?= (matches > > current practice), add in editline, linenoise CLI options and xtables > > option. Switch to --disable-python when building without python to avoid > > a configure time warning. > > > > We can drop UPSTREAM_CHECK_REGEX as the version no longer gets confused > > by the 0.099 version which exists. > > > > Signed-off-by: Alex Kiernan <alex.kiernan@gmail.com> > > --- > > ...-with-make-check-and-add-AM_CPPFLAGS.patch | 39 ------------------- > > .../{nftables_1.0.2.bb => nftables_1.0.4.bb} | 16 ++++---- > > 2 files changed, 8 insertions(+), 47 deletions(-) > > delete mode 100644 meta-networking/recipes-filter/nftables/nftables/0001-examples-compile-with-make-check-and-add-AM_CPPFLAGS.patch > > rename meta-networking/recipes-filter/nftables/{nftables_1.0.2.bb => nftables_1.0.4.bb} (77%) > > > > diff --git a/meta-networking/recipes-filter/nftables/nftables/0001-examples-compile-with-make-check-and-add-AM_CPPFLAGS.patch b/meta-networking/recipes-filter/nftables/nftables/0001-examples-compile-with-make-check-and-add-AM_CPPFLAGS.patch > > deleted file mode 100644 > > index 65ab2dfd8c49..000000000000 > > --- a/meta-networking/recipes-filter/nftables/nftables/0001-examples-compile-with-make-check-and-add-AM_CPPFLAGS.patch > > +++ /dev/null > > @@ -1,39 +0,0 @@ > > -From 18a08fb7f0443f8bde83393bd6f69e23a04246b3 Mon Sep 17 00:00:00 2001 > > -From: Pablo Neira Ayuso <pablo@netfilter.org> > > -Date: Tue, 22 Feb 2022 00:56:36 +0100 > > -Subject: [PATCH] examples: compile with `make check' and add AM_CPPFLAGS > > - > > -Compile examples via `make check' like libnftnl does. Use AM_CPPFLAGS to > > -specify local headers via -I. > > - > > -Unfortunately, `make distcheck' did not catch this compile time error in > > -my system, since it was using the nftables/libnftables.h file of the > > -previous nftables release. > > - > > -Fixes: 5b364657a35f ("build: missing SUBIRS update") > > -Fixes: caf2a6ad2d22 ("examples: add libnftables example program") > > -Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org> > > - > > -Upstream-Status: Backport > > -[http://git.netfilter.org/nftables/commit/?id=18a08fb7f0443f8bde83393bd6f69e23a04246b3] > > - > > -Signed-off-by: Yi Zhao <yi.zhao@windriver.com> > > ---- > > - examples/Makefile.am | 4 +++- > > - 1 file changed, 3 insertions(+), 1 deletion(-) > > - > > -diff --git a/examples/Makefile.am b/examples/Makefile.am > > -index c972170d..3b8b0b67 100644 > > ---- a/examples/Makefile.am > > -+++ b/examples/Makefile.am > > -@@ -1,4 +1,6 @@ > > --noinst_PROGRAMS = nft-buffer \ > > -+check_PROGRAMS = nft-buffer \ > > - nft-json-file > > - > > -+AM_CPPFLAGS = -I$(top_srcdir)/include > > -+ > > - LDADD = $(top_builddir)/src/libnftables.la > > --- > > -2.25.1 > > - > > diff --git a/meta-networking/recipes-filter/nftables/nftables_1.0.2.bb b/meta-networking/recipes-filter/nftables/nftables_1.0.4.bb > > similarity index 77% > > rename from meta-networking/recipes-filter/nftables/nftables_1.0.2.bb > > rename to meta-networking/recipes-filter/nftables/nftables_1.0.4.bb > > index e078be79a1df..e2d0bd66812c 100644 > > --- a/meta-networking/recipes-filter/nftables/nftables_1.0.2.bb > > +++ b/meta-networking/recipes-filter/nftables/nftables_1.0.4.bb > > @@ -6,26 +6,26 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=d1a78fdd879a263a5e0b42d1fc565e79" > > DEPENDS = "libmnl libnftnl bison-native \ > > ${@bb.utils.contains('PACKAGECONFIG', 'mini-gmp', '', 'gmp', d)}" > > > > -# Ensure we reject the 0.099 version by matching at least two dots > > -UPSTREAM_CHECK_REGEX = "nftables-(?P<pver>\d+(\.\d+){2,}).tar.bz2" > > - > > SRC_URI = "http://www.netfilter.org/projects/nftables/files/${BP}.tar.bz2 \ > > - file://0001-examples-compile-with-make-check-and-add-AM_CPPFLAGS.patch \ > > file://run-ptest \ > > " > > > > -SRC_URI[sha256sum] = "0b28a36ffcf4567b841de7bd3f37918b1fed27859eb48bdec51e1f7a83954c02" > > +SRC_URI[sha256sum] = "927fb1fea1f685a328c10cf791eb655d7e1ed49d310eea5cb3101dfd8d6cba35" > > > > inherit autotools manpages pkgconfig ptest > > > > -PACKAGECONFIG ??= "python readline json" > > +PACKAGECONFIG ?= "python readline json" > > +PACKAGECONFIG[editline] = "--with-cli=editline, , libedit, , , linenoise readline" > > PACKAGECONFIG[json] = "--with-json, --without-json, jansson" > > +PACKAGECONFIG[linenoise] = "--with-cli=linenoise, , linenoise, , , editline readline" > > PACKAGECONFIG[manpages] = "--enable-man-doc, --disable-man-doc, asciidoc-native" > > PACKAGECONFIG[mini-gmp] = "--with-mini-gmp, --without-mini-gmp" > > -PACKAGECONFIG[python] = "--enable-python --with-python-bin=${PYTHON}, --with-python-bin="", python3" > > -PACKAGECONFIG[readline] = "--with-cli=readline, --without-cli, readline" > > +PACKAGECONFIG[python] = "--enable-python --with-python-bin=${PYTHON}, --disable-python, python3" > > +PACKAGECONFIG[readline] = "--with-cli=readline, , readline, , , editline linenoise" > > PACKAGECONFIG[xtables] = "--with-xtables, --without-xtables, iptables" > > > > +EXTRA_OECONF = "${@bb.utils.contains_any('PACKAGECONFIG', 'editline linenoise readline', '', '--without-cli', d)}" > > + > > inherit ${@bb.utils.contains('PACKAGECONFIG', 'python', 'python3native', '', d)} > > > > RRECOMMENDS:${PN} += "kernel-module-nf-tables" > > -- > > 2.35.1 > > > > > > -=-=-=-=-=-=-=-=-=-=-=- > > Links: You receive all messages sent to this group. > > View/Reply Online (#97815): https://lists.openembedded.org/g/openembedded-devel/message/97815 > > Mute This Topic: https://lists.openembedded.org/mt/92329338/1997914 > > Group Owner: openembedded-devel+owner@lists.openembedded.org > > Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [raj.khem@gmail.com] > > -=-=-=-=-=-=-=-=-=-=-=- > >
diff --git a/meta-networking/recipes-filter/nftables/nftables/0001-examples-compile-with-make-check-and-add-AM_CPPFLAGS.patch b/meta-networking/recipes-filter/nftables/nftables/0001-examples-compile-with-make-check-and-add-AM_CPPFLAGS.patch deleted file mode 100644 index 65ab2dfd8c49..000000000000 --- a/meta-networking/recipes-filter/nftables/nftables/0001-examples-compile-with-make-check-and-add-AM_CPPFLAGS.patch +++ /dev/null @@ -1,39 +0,0 @@ -From 18a08fb7f0443f8bde83393bd6f69e23a04246b3 Mon Sep 17 00:00:00 2001 -From: Pablo Neira Ayuso <pablo@netfilter.org> -Date: Tue, 22 Feb 2022 00:56:36 +0100 -Subject: [PATCH] examples: compile with `make check' and add AM_CPPFLAGS - -Compile examples via `make check' like libnftnl does. Use AM_CPPFLAGS to -specify local headers via -I. - -Unfortunately, `make distcheck' did not catch this compile time error in -my system, since it was using the nftables/libnftables.h file of the -previous nftables release. - -Fixes: 5b364657a35f ("build: missing SUBIRS update") -Fixes: caf2a6ad2d22 ("examples: add libnftables example program") -Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org> - -Upstream-Status: Backport -[http://git.netfilter.org/nftables/commit/?id=18a08fb7f0443f8bde83393bd6f69e23a04246b3] - -Signed-off-by: Yi Zhao <yi.zhao@windriver.com> ---- - examples/Makefile.am | 4 +++- - 1 file changed, 3 insertions(+), 1 deletion(-) - -diff --git a/examples/Makefile.am b/examples/Makefile.am -index c972170d..3b8b0b67 100644 ---- a/examples/Makefile.am -+++ b/examples/Makefile.am -@@ -1,4 +1,6 @@ --noinst_PROGRAMS = nft-buffer \ -+check_PROGRAMS = nft-buffer \ - nft-json-file - -+AM_CPPFLAGS = -I$(top_srcdir)/include -+ - LDADD = $(top_builddir)/src/libnftables.la --- -2.25.1 - diff --git a/meta-networking/recipes-filter/nftables/nftables_1.0.2.bb b/meta-networking/recipes-filter/nftables/nftables_1.0.4.bb similarity index 77% rename from meta-networking/recipes-filter/nftables/nftables_1.0.2.bb rename to meta-networking/recipes-filter/nftables/nftables_1.0.4.bb index e078be79a1df..e2d0bd66812c 100644 --- a/meta-networking/recipes-filter/nftables/nftables_1.0.2.bb +++ b/meta-networking/recipes-filter/nftables/nftables_1.0.4.bb @@ -6,26 +6,26 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=d1a78fdd879a263a5e0b42d1fc565e79" DEPENDS = "libmnl libnftnl bison-native \ ${@bb.utils.contains('PACKAGECONFIG', 'mini-gmp', '', 'gmp', d)}" -# Ensure we reject the 0.099 version by matching at least two dots -UPSTREAM_CHECK_REGEX = "nftables-(?P<pver>\d+(\.\d+){2,}).tar.bz2" - SRC_URI = "http://www.netfilter.org/projects/nftables/files/${BP}.tar.bz2 \ - file://0001-examples-compile-with-make-check-and-add-AM_CPPFLAGS.patch \ file://run-ptest \ " -SRC_URI[sha256sum] = "0b28a36ffcf4567b841de7bd3f37918b1fed27859eb48bdec51e1f7a83954c02" +SRC_URI[sha256sum] = "927fb1fea1f685a328c10cf791eb655d7e1ed49d310eea5cb3101dfd8d6cba35" inherit autotools manpages pkgconfig ptest -PACKAGECONFIG ??= "python readline json" +PACKAGECONFIG ?= "python readline json" +PACKAGECONFIG[editline] = "--with-cli=editline, , libedit, , , linenoise readline" PACKAGECONFIG[json] = "--with-json, --without-json, jansson" +PACKAGECONFIG[linenoise] = "--with-cli=linenoise, , linenoise, , , editline readline" PACKAGECONFIG[manpages] = "--enable-man-doc, --disable-man-doc, asciidoc-native" PACKAGECONFIG[mini-gmp] = "--with-mini-gmp, --without-mini-gmp" -PACKAGECONFIG[python] = "--enable-python --with-python-bin=${PYTHON}, --with-python-bin="", python3" -PACKAGECONFIG[readline] = "--with-cli=readline, --without-cli, readline" +PACKAGECONFIG[python] = "--enable-python --with-python-bin=${PYTHON}, --disable-python, python3" +PACKAGECONFIG[readline] = "--with-cli=readline, , readline, , , editline linenoise" PACKAGECONFIG[xtables] = "--with-xtables, --without-xtables, iptables" +EXTRA_OECONF = "${@bb.utils.contains_any('PACKAGECONFIG', 'editline linenoise readline', '', '--without-cli', d)}" + inherit ${@bb.utils.contains('PACKAGECONFIG', 'python', 'python3native', '', d)} RRECOMMENDS:${PN} += "kernel-module-nf-tables"
Drop backported patch, switch PACKAGECONFIG assignment to ?= (matches current practice), add in editline, linenoise CLI options and xtables option. Switch to --disable-python when building without python to avoid a configure time warning. We can drop UPSTREAM_CHECK_REGEX as the version no longer gets confused by the 0.099 version which exists. Signed-off-by: Alex Kiernan <alex.kiernan@gmail.com> --- ...-with-make-check-and-add-AM_CPPFLAGS.patch | 39 ------------------- .../{nftables_1.0.2.bb => nftables_1.0.4.bb} | 16 ++++---- 2 files changed, 8 insertions(+), 47 deletions(-) delete mode 100644 meta-networking/recipes-filter/nftables/nftables/0001-examples-compile-with-make-check-and-add-AM_CPPFLAGS.patch rename meta-networking/recipes-filter/nftables/{nftables_1.0.2.bb => nftables_1.0.4.bb} (77%)