diff mbox series

[meta-oe,v3] dnf-plugin-tui: create symlinks from /usr/ to /.

Message ID 1697527418-5791-1-git-send-email-wangmy@fujitsu.com
State Under Review
Headers show
Series [meta-oe,v3] dnf-plugin-tui: create symlinks from /usr/ to /. | expand

Commit Message

Mingyu Wang (Fujitsu) Oct. 17, 2023, 7:23 a.m. UTC
From: Wang Mingyu <wangmy@fujitsu.com>

From Poky 4.3, by default, usrmerge has been enabled.
Some important binaries have been installed to /usr/sbin instead of
/sbin such as init. So it is necessary to create symlinks from /usr/
to /, such as /usr/sbin to /sbin, /usr/bin to /bin.

Signed-off-by: Wang Mingyu <wangmy@fujitsu.com>
---
 meta-oe/recipes-devtools/dnf-plugin-tui/dnf-plugin-tui_git.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Ross Burton Oct. 17, 2023, 9:51 a.m. UTC | #1
Isn’t this what create_merged_usr_symlinks in image.bbclass does?  Why does a DNF plugin need to do this, and not anything else?

Ross

> On 17 Oct 2023, at 08:23, wangmy via lists.openembedded.org <wangmy=fujitsu.com@lists.openembedded.org> wrote:
> 
> From Poky 4.3, by default, usrmerge has been enabled.
> Some important binaries have been installed to /usr/sbin instead of
> /sbin such as init. So it is necessary to create symlinks from /usr/
> to /, such as /usr/sbin to /sbin, /usr/bin to /bin.
> 
> Signed-off-by: Wang Mingyu <wangmy@fujitsu.com>
> ---
> meta-oe/recipes-devtools/dnf-plugin-tui/dnf-plugin-tui_git.bb | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta-oe/recipes-devtools/dnf-plugin-tui/dnf-plugin-tui_git.bb b/meta-oe/recipes-devtools/dnf-plugin-tui/dnf-plugin-tui_git.bb
> index 94023922a2..0709019056 100644
> --- a/meta-oe/recipes-devtools/dnf-plugin-tui/dnf-plugin-tui_git.bb
> +++ b/meta-oe/recipes-devtools/dnf-plugin-tui/dnf-plugin-tui_git.bb
> @@ -4,7 +4,7 @@ LICENSE = "GPL-2.0-only"
> LIC_FILES_CHKSUM = "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263"
> 
> SRC_URI = "git://github.com/ubinux/dnf-plugin-tui.git;branch=master;protocol=https"
> -SRCREV = "83917a3935ac7ce1d8d96e914d96a6679319a336"
> +SRCREV = "baac322a8a6d57e62c703f6ed523152baec18b4f"
> PV = "1.3"
> 
> SRC_URI:append:class-target = " file://oe-remote.repo.sample"
> -- 
> 2.34.1
> 
> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#105550): https://lists.openembedded.org/g/openembedded-devel/message/105550
> Mute This Topic: https://lists.openembedded.org/mt/102013374/6875888
> Group Owner: openembedded-devel+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [ross.burton@arm.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
Mingyu Wang (Fujitsu) Oct. 19, 2023, 6:51 a.m. UTC | #2
> Isn’t this what create_merged_usr_symlinks in image.bbclass does?  Why does
> a DNF plugin need to do this, and not anything else?
Because dnf-plugin-tui is used to created rootfs in any nativesdk environment.
It is not in a bitbake environment, so image.bbclass cannot be used.
  --
Best Regards
---------------------------------------------------
Wang Mingyu
Development Dept.I
Nanjing Fujitsu Nanda Software Tech. Co., Ltd.(FNST) No. 6 Wenzhu Road, Nanjing, 210012, China
TEL: +86+25-86630566-8568
COINS: 79988548
FAX: +86+25-83317685
MAIL: wangmy@fujitsu.com
http://www.fujitsu.com/cn/fnst/

> -----Original Message-----
> From: Ross Burton <Ross.Burton@arm.com>
> Sent: Tuesday, October 17, 2023 5:51 PM
> To: Wang, Mingyu/王 鸣瑜 <wangmy@fujitsu.com>
> Cc: openembedded-devel@lists.openembedded.org
> Subject: Re: [oe] [meta-oe] [PATCH v3] dnf-plugin-tui: create symlinks from /usr/
> to /.
> 
> Isn’t this what create_merged_usr_symlinks in image.bbclass does?  Why does
> a DNF plugin need to do this, and not anything else?
> 
> Ross
> 
> > On 17 Oct 2023, at 08:23, wangmy via lists.openembedded.org
> <wangmy=fujitsu.com@lists.openembedded.org> wrote:
> >
> > From Poky 4.3, by default, usrmerge has been enabled.
> > Some important binaries have been installed to /usr/sbin instead of
> > /sbin such as init. So it is necessary to create symlinks from /usr/
> > to /, such as /usr/sbin to /sbin, /usr/bin to /bin.
> >
> > Signed-off-by: Wang Mingyu <wangmy@fujitsu.com>
> > ---
> > meta-oe/recipes-devtools/dnf-plugin-tui/dnf-plugin-tui_git.bb | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git
> > a/meta-oe/recipes-devtools/dnf-plugin-tui/dnf-plugin-tui_git.bb
> > b/meta-oe/recipes-devtools/dnf-plugin-tui/dnf-plugin-tui_git.bb
> > index 94023922a2..0709019056 100644
> > --- a/meta-oe/recipes-devtools/dnf-plugin-tui/dnf-plugin-tui_git.bb
> > +++ b/meta-oe/recipes-devtools/dnf-plugin-tui/dnf-plugin-tui_git.bb
> > @@ -4,7 +4,7 @@ LICENSE = "GPL-2.0-only"
> > LIC_FILES_CHKSUM =
> "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263"
> >
> > SRC_URI =
> "git://github.com/ubinux/dnf-plugin-tui.git;branch=master;protocol=https"
> > -SRCREV = "83917a3935ac7ce1d8d96e914d96a6679319a336"
> > +SRCREV = "baac322a8a6d57e62c703f6ed523152baec18b4f"
> > PV = "1.3"
> >
> > SRC_URI:append:class-target = " file://oe-remote.repo.sample"
> > --
> > 2.34.1
> >
> >
> > -=-=-=-=-=-=-=-=-=-=-=-
> > Links: You receive all messages sent to this group.
> > View/Reply Online (#105550):
> > https://lists.openembedded.org/g/openembedded-devel/message/105550
> > Mute This Topic: https://lists.openembedded.org/mt/102013374/6875888
> > Group Owner: openembedded-devel+owner@lists.openembedded.org
> > Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub
> > [ross.burton@arm.com]
> > -=-=-=-=-=-=-=-=-=-=-=-
> >
Ross Burton Oct. 19, 2023, 9:05 a.m. UTC | #3
On 19 Oct 2023, at 07:51, Mingyu Wang (Fujitsu) <wangmy@fujitsu.com> wrote:
> 
>> Isn’t this what create_merged_usr_symlinks in image.bbclass does?  Why does
>> a DNF plugin need to do this, and not anything else?
> Because dnf-plugin-tui is used to created rootfs in any nativesdk environment.
> It is not in a bitbake environment, so image.bbclass cannot be used.

Sounds a bit like the symlink creation should be moved into base-files...

Ross
Mingyu Wang (Fujitsu) Oct. 20, 2023, 3:25 a.m. UTC | #4
> Sounds a bit like the symlink creation should be moved into base-files...
Yes, we also think that it should be moved into base-files.

  --
Best Regards
---------------------------------------------------
Wang Mingyu
Development Dept.I
Nanjing Fujitsu Nanda Software Tech. Co., Ltd.(FNST) No. 6 Wenzhu Road, Nanjing, 210012, China
TEL: +86+25-86630566-8568
COINS: 79988548
FAX: +86+25-83317685
MAIL: wangmy@fujitsu.com
http://www.fujitsu.com/cn/fnst/

> -----Original Message-----
> From: Ross Burton <Ross.Burton@arm.com>
> Sent: Thursday, October 19, 2023 5:05 PM
> To: Wang, Mingyu/王 鸣瑜 <wangmy@fujitsu.com>
> Cc: openembedded-devel@lists.openembedded.org
> Subject: Re: [oe] [meta-oe] [PATCH v3] dnf-plugin-tui: create symlinks from /usr/
> to /.
> 
> On 19 Oct 2023, at 07:51, Mingyu Wang (Fujitsu) <wangmy@fujitsu.com>
> wrote:
> >
> >> Isn’t this what create_merged_usr_symlinks in image.bbclass does?
> >> Why does a DNF plugin need to do this, and not anything else?
> > Because dnf-plugin-tui is used to created rootfs in any nativesdk environment.
> > It is not in a bitbake environment, so image.bbclass cannot be used.
> 
> Sounds a bit like the symlink creation should be moved into base-files...
> 
> Ross
Khem Raj Oct. 20, 2023, 4:22 a.m. UTC | #5
On Thu, Oct 19, 2023 at 8:25 PM wangmy <wangmy@fujitsu.com> wrote:
>
> > Sounds a bit like the symlink creation should be moved into base-files...
> Yes, we also think that it should be moved into base-files.

Right until then I will install this patch.

>
>   --
> Best Regards
> ---------------------------------------------------
> Wang Mingyu
> Development Dept.I
> Nanjing Fujitsu Nanda Software Tech. Co., Ltd.(FNST) No. 6 Wenzhu Road, Nanjing, 210012, China
> TEL: +86+25-86630566-8568
> COINS: 79988548
> FAX: +86+25-83317685
> MAIL: wangmy@fujitsu.com
> http://www.fujitsu.com/cn/fnst/
>
> > -----Original Message-----
> > From: Ross Burton <Ross.Burton@arm.com>
> > Sent: Thursday, October 19, 2023 5:05 PM
> > To: Wang, Mingyu/王 鸣瑜 <wangmy@fujitsu.com>
> > Cc: openembedded-devel@lists.openembedded.org
> > Subject: Re: [oe] [meta-oe] [PATCH v3] dnf-plugin-tui: create symlinks from /usr/
> > to /.
> >
> > On 19 Oct 2023, at 07:51, Mingyu Wang (Fujitsu) <wangmy@fujitsu.com>
> > wrote:
> > >
> > >> Isn’t this what create_merged_usr_symlinks in image.bbclass does?
> > >> Why does a DNF plugin need to do this, and not anything else?
> > > Because dnf-plugin-tui is used to created rootfs in any nativesdk environment.
> > > It is not in a bitbake environment, so image.bbclass cannot be used.
> >
> > Sounds a bit like the symlink creation should be moved into base-files...
> >
> > Ross
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#105606): https://lists.openembedded.org/g/openembedded-devel/message/105606
> Mute This Topic: https://lists.openembedded.org/mt/102013374/1997914
> Group Owner: openembedded-devel+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [raj.khem@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
diff mbox series

Patch

diff --git a/meta-oe/recipes-devtools/dnf-plugin-tui/dnf-plugin-tui_git.bb b/meta-oe/recipes-devtools/dnf-plugin-tui/dnf-plugin-tui_git.bb
index 94023922a2..0709019056 100644
--- a/meta-oe/recipes-devtools/dnf-plugin-tui/dnf-plugin-tui_git.bb
+++ b/meta-oe/recipes-devtools/dnf-plugin-tui/dnf-plugin-tui_git.bb
@@ -4,7 +4,7 @@  LICENSE = "GPL-2.0-only"
 LIC_FILES_CHKSUM = "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263"
 
 SRC_URI = "git://github.com/ubinux/dnf-plugin-tui.git;branch=master;protocol=https"
-SRCREV = "83917a3935ac7ce1d8d96e914d96a6679319a336"
+SRCREV = "baac322a8a6d57e62c703f6ed523152baec18b4f"
 PV = "1.3"
 
 SRC_URI:append:class-target = " file://oe-remote.repo.sample"