mbox series

[meta-oe,0/2] glmark2: fix an issue with eglconfig scoring

Message ID 20240305212609.2054938-1-rs@ti.com
Headers show
Series glmark2: fix an issue with eglconfig scoring | expand

Message

Randolph Sapp March 5, 2024, 9:26 p.m. UTC 
From: Randolph Sapp <rs@ti.com>

Backport a patch from the upstream glmark2 package to fix 2 primary issues:

1. Configs with stencil components were ranked unnecessarily low.
2. If the target config was below 0 an optimal config may not be properly
selected.

Randolph Sapp (2):
  glmark2: add upstream patch to not care about stencil config
  glmark2: add the stencil config patch to the package

 ...y-default-don-t-care-about-the-stenc.patch | 103 ++++++++++++++++++
 .../recipes-benchmark/glmark2/glmark2_git.bb  |   1 +
 2 files changed, 104 insertions(+)
 create mode 100644 meta-oe/recipes-benchmark/glmark2/files/0003-GLVisualConfig-By-default-don-t-care-about-the-stenc.patch

Comments

Martin Jansa March 5, 2024, 9:42 p.m. UTC | #1 
Invalid format of Upstream-Status and please squash those 2 commits as
they don't make sense separately.

On Tue, Mar 5, 2024 at 10:26 PM Randolph Sapp via
lists.openembedded.org <rs=ti.com@lists.openembedded.org> wrote:
>
> From: Randolph Sapp <rs@ti.com>
>
> Backport a patch from the upstream glmark2 package to fix 2 primary issues:
>
> 1. Configs with stencil components were ranked unnecessarily low.
> 2. If the target config was below 0 an optimal config may not be properly
> selected.
>
> Randolph Sapp (2):
>   glmark2: add upstream patch to not care about stencil config
>   glmark2: add the stencil config patch to the package
>
>  ...y-default-don-t-care-about-the-stenc.patch | 103 ++++++++++++++++++
>  .../recipes-benchmark/glmark2/glmark2_git.bb  |   1 +
>  2 files changed, 104 insertions(+)
>  create mode 100644 meta-oe/recipes-benchmark/glmark2/files/0003-GLVisualConfig-By-default-don-t-care-about-the-stenc.patch
>
> --
> 2.44.0
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#109133): https://lists.openembedded.org/g/openembedded-devel/message/109133
> Mute This Topic: https://lists.openembedded.org/mt/104754322/3617156
> Group Owner: openembedded-devel+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [martin.jansa@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
Randolph Sapp March 5, 2024, 9:47 p.m. UTC | #2 
On 3/5/24 15:42, Martin Jansa wrote:
> Invalid format of Upstream-Status and please squash those 2 commits as
> they don't make sense separately.
> 
> On Tue, Mar 5, 2024 at 10:26 PM Randolph Sapp via
> lists.openembedded.org <rs=ti.com@lists.openembedded.org> wrote:
>>
>> From: Randolph Sapp <rs@ti.com>
>>
>> Backport a patch from the upstream glmark2 package to fix 2 primary issues:
>>
>> 1. Configs with stencil components were ranked unnecessarily low.
>> 2. If the target config was below 0 an optimal config may not be properly
>> selected.
>>
>> Randolph Sapp (2):
>>    glmark2: add upstream patch to not care about stencil config
>>    glmark2: add the stencil config patch to the package
>>
>>   ...y-default-don-t-care-about-the-stenc.patch | 103 ++++++++++++++++++
>>   .../recipes-benchmark/glmark2/glmark2_git.bb  |   1 +
>>   2 files changed, 104 insertions(+)
>>   create mode 100644 meta-oe/recipes-benchmark/glmark2/files/0003-GLVisualConfig-By-default-don-t-care-about-the-stenc.patch
>>
>> --
>> 2.44.0

Roger. Would the correct status be:

 > Upstream-Status: Backport [5f23d540342ba69e12afeb6a1ac4f6fd36747975]

(Reading the docs I was not aware the brackets were supposed to be 
included...)
Martin Jansa March 6, 2024, 1:52 a.m. UTC | #3 
The QA check in oe-core would tell you that (as well as that the 'S'
in Status needs to be uppercase).

On Tue, Mar 5, 2024 at 10:47 PM Randolph Sapp <rs@ti.com> wrote:
>
> On 3/5/24 15:42, Martin Jansa wrote:
> > Invalid format of Upstream-Status and please squash those 2 commits as
> > they don't make sense separately.
> >
> > On Tue, Mar 5, 2024 at 10:26 PM Randolph Sapp via
> > lists.openembedded.org <rs=ti.com@lists.openembedded.org> wrote:
> >>
> >> From: Randolph Sapp <rs@ti.com>
> >>
> >> Backport a patch from the upstream glmark2 package to fix 2 primary issues:
> >>
> >> 1. Configs with stencil components were ranked unnecessarily low.
> >> 2. If the target config was below 0 an optimal config may not be properly
> >> selected.
> >>
> >> Randolph Sapp (2):
> >>    glmark2: add upstream patch to not care about stencil config
> >>    glmark2: add the stencil config patch to the package
> >>
> >>   ...y-default-don-t-care-about-the-stenc.patch | 103 ++++++++++++++++++
> >>   .../recipes-benchmark/glmark2/glmark2_git.bb  |   1 +
> >>   2 files changed, 104 insertions(+)
> >>   create mode 100644 meta-oe/recipes-benchmark/glmark2/files/0003-GLVisualConfig-By-default-don-t-care-about-the-stenc.patch
> >>
> >> --
> >> 2.44.0
>
> Roger. Would the correct status be:
>
>  > Upstream-Status: Backport [5f23d540342ba69e12afeb6a1ac4f6fd36747975]
>
> (Reading the docs I was not aware the brackets were supposed to be
> included...)