mbox series

[kirkstone,0/2] Add sipconfig.py support to sip3

Message ID 20231202030950.3357721-1-rob.woolley@windriver.com
Headers show
Series Add sipconfig.py support to sip3 | expand

Message

Rob Woolley Dec. 2, 2023, 3:09 a.m. UTC
Some packages in meta-ros, like qt-gui-cpp, need sipconfig.py to be
present in python3-sip3.  Changes are required to ensure that the
sip tools execute successfully and that paths from the host machine
don't get included in the SIP configuration file.

Rob Woolley (2):
  sip3: Add sipconfig.py
  sip3: Add py_ssize_t_clean argument

 ...ean-argument-to-the-module-directive.patch | 17679 ++++++++++++++++
 meta-oe/recipes-devtools/sip/sip3_4.19.23.bb  |    21 +-
 2 files changed, 17699 insertions(+), 1 deletion(-)
 create mode 100644 meta-oe/recipes-devtools/sip/sip3/added-the-py_ssize_t_clean-argument-to-the-module-directive.patch

Comments

akuster808 Dec. 6, 2023, 12:28 p.m. UTC | #1
On 12/1/23 10:09 PM, Rob Woolley via lists.openembedded.org wrote:
> Some packages in meta-ros, like qt-gui-cpp, need sipconfig.py to be
> present in python3-sip3.  Changes are required to ensure that the
> sip tools execute successfully and that paths from the host machine
> don't get included in the SIP configuration file.

Do similar changes need to go into Master?

>
> Rob Woolley (2):
>    sip3: Add sipconfig.py
>    sip3: Add py_ssize_t_clean argument
>
>   ...ean-argument-to-the-module-directive.patch | 17679 ++++++++++++++++
>   meta-oe/recipes-devtools/sip/sip3_4.19.23.bb  |    21 +-
>   2 files changed, 17699 insertions(+), 1 deletion(-)
>   create mode 100644 meta-oe/recipes-devtools/sip/sip3/added-the-py_ssize_t_clean-argument-to-the-module-directive.patch
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#107194): https://lists.openembedded.org/g/openembedded-devel/message/107194
> Mute This Topic: https://lists.openembedded.org/mt/102930497/3616698
> Group Owner: openembedded-devel+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [akuster808@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
Rob Woolley Dec. 6, 2023, 4:57 p.m. UTC | #2
Hi Armin,

Thanks for looking at this.  No, I don't think we need it in master.

Riverbank Computing changed python3-pyqt5 to only support SIP v6. (FYI I sent out a separate pull request to meta-qt5 to update python-pyqt5 to 5.15.7. This version is the last release to use SIP v4; see https://github.com/meta-qt5/meta-qt5/pull/546/commits/a82daf56e9c783c684da98a2996677bc1d7a439e)

Langdale is the last Yocto release with the sip v4.19.23 recipe before we removed it and created a new recipe for SIP v6.  Dunfell and Kirkstone are the only supported releases to still use SIP v4.  I did a test build of Dunfell with a copy of the Kirkstone recipes.  The sip3, sip3-native, qtbase, and python3-pyqt5 tasks all completed successfully.  I am happy to send out a Dunfell patch if you would like me to.

Regards,
Rob


From: akuster808 <akuster808@gmail.com>
Sent: Wednesday, December 6, 2023 7:28 AM
To: Woolley, Rob <Rob.Woolley@windriver.com>; openembedded-devel@lists.openembedded.org <openembedded-devel@lists.openembedded.org>
Cc: raj.khem@gmail.com <raj.khem@gmail.com>; alex.kanavin@gmail.com <alex.kanavin@gmail.com>
Subject: Re: [oe] [kirkstone][PATCH 0/2] Add sipconfig.py support to sip3
 
CAUTION: This email comes from a non Wind River email account!
Do not click links or open attachments unless you recognize the sender and know the content is safe.

On 12/1/23 10:09 PM, Rob Woolley via lists.openembedded.org wrote:
> Some packages in meta-ros, like qt-gui-cpp, need sipconfig.py to be
> present in python3-sip3.  Changes are required to ensure that the
> sip tools execute successfully and that paths from the host machine
> don't get included in the SIP configuration file.

Do similar changes need to go into Master?

>
> Rob Woolley (2):
>    sip3: Add sipconfig.py
>    sip3: Add py_ssize_t_clean argument
>
>   ...ean-argument-to-the-module-directive.patch | 17679 ++++++++++++++++
>   meta-oe/recipes-devtools/sip/sip3_4.19.23.bb  |    21 +-
>   2 files changed, 17699 insertions(+), 1 deletion(-)
>   create mode 100644 meta-oe/recipes-devtools/sip/sip3/added-the-py_ssize_t_clean-argument-to-the-module-directive.patch
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#107194): https://lists.openembedded.org/g/openembedded-devel/message/107194
> Mute This Topic: https://lists.openembedded.org/mt/102930497/3616698
> Group Owner: openembedded-devel+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [akuster808@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
Rob Woolley Dec. 21, 2023, 3:02 p.m. UTC | #3
Hi Armin,

Is there anything else I can provide?  I'm happy to do any additional testing if it helps.

Regards,
Rob