[dunfell,14/14] selftest: skip virgl test on fedora 34 entirely

Message ID 5930e54a9e0c6b023e46b83c4294d6293cdf3f82.1640181998.git.steve@sakoman.com
State Accepted, archived
Commit 1ab7aee542589f6b6c76f8515b4230ce870a8678
Headers show
Series [dunfell,01/14] bluez: fix CVE-2021-0129 | expand

Commit Message

Steve Sakoman Dec. 22, 2021, 2:12 p.m. UTC
With the sdl frontend, qemu isn't able to even boot fully,
so let's skip the test early.

Signed-off-by: Steve Sakoman <steve@sakoman.com>
---
 meta/lib/oeqa/selftest/cases/runtime_test.py | 2 ++
 1 file changed, 2 insertions(+)

Comments

Mittal, Anuj Dec. 23, 2021, 9:19 a.m. UTC | #1
On Wed, 2021-12-22 at 04:12 -1000, Steve Sakoman wrote:
> With the sdl frontend, qemu isn't able to even boot fully,
> so let's skip the test early.

This will fail any time the host has libdrm > 2.4.107 so perhaps that
should be mentioned in the commit message. 

Fedora 34 recently update to 2.4.109.

Thanks,

Anuj

> 
> Signed-off-by: Steve Sakoman <steve@sakoman.com>
> ---
>  meta/lib/oeqa/selftest/cases/runtime_test.py | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/meta/lib/oeqa/selftest/cases/runtime_test.py
> b/meta/lib/oeqa/selftest/cases/runtime_test.py
> index 9e5c3f2878..f5b3ba27a9 100644
> --- a/meta/lib/oeqa/selftest/cases/runtime_test.py
> +++ b/meta/lib/oeqa/selftest/cases/runtime_test.py
> @@ -181,6 +181,8 @@ class TestImage(OESelftestTestCase):
>              self.skipTest('virgl isn\'t working with Centos 7')
>          if distro and distro == 'centos-8':
>              self.skipTest('virgl isn\'t working with Centos 8')
> +        if distro and distro == 'fedora-34':
> +            self.skipTest('virgl isn\'t working with Fedora 34')
>          if distro and distro == 'opensuseleap-15.0':
>              self.skipTest('virgl isn\'t working with Opensuse 15.0')
>  
> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#159959):
> https://lists.openembedded.org/g/openembedded-core/message/159959
> Mute This Topic: https://lists.openembedded.org/mt/87898199/3616702
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe:
> https://lists.openembedded.org/g/openembedded-core/unsub [
> anuj.mittal@intel.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
Steve Sakoman Dec. 23, 2021, 2:41 p.m. UTC | #2
On Wed, Dec 22, 2021 at 11:19 PM Mittal, Anuj <anuj.mittal@intel.com> wrote:
>
> On Wed, 2021-12-22 at 04:12 -1000, Steve Sakoman wrote:
> > With the sdl frontend, qemu isn't able to even boot fully,
> > so let's skip the test early.
>
> This will fail any time the host has libdrm > 2.4.107 so perhaps that
> should be mentioned in the commit message.
>
> Fedora 34 recently update to 2.4.109.

Thanks for reviewing the patches Anuj!

Yes, I can certainly update the commit message.  I had just copied the
commit message from one of the master commits that disabled this test.

Steve

> > Signed-off-by: Steve Sakoman <steve@sakoman.com>
> > ---
> >  meta/lib/oeqa/selftest/cases/runtime_test.py | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/meta/lib/oeqa/selftest/cases/runtime_test.py
> > b/meta/lib/oeqa/selftest/cases/runtime_test.py
> > index 9e5c3f2878..f5b3ba27a9 100644
> > --- a/meta/lib/oeqa/selftest/cases/runtime_test.py
> > +++ b/meta/lib/oeqa/selftest/cases/runtime_test.py
> > @@ -181,6 +181,8 @@ class TestImage(OESelftestTestCase):
> >              self.skipTest('virgl isn\'t working with Centos 7')
> >          if distro and distro == 'centos-8':
> >              self.skipTest('virgl isn\'t working with Centos 8')
> > +        if distro and distro == 'fedora-34':
> > +            self.skipTest('virgl isn\'t working with Fedora 34')
> >          if distro and distro == 'opensuseleap-15.0':
> >              self.skipTest('virgl isn\'t working with Opensuse 15.0')
> >
> >
> > -=-=-=-=-=-=-=-=-=-=-=-
> > Links: You receive all messages sent to this group.
> > View/Reply Online (#159959):
> > https://lists.openembedded.org/g/openembedded-core/message/159959
> > Mute This Topic: https://lists.openembedded.org/mt/87898199/3616702
> > Group Owner: openembedded-core+owner@lists.openembedded.org
> > Unsubscribe:
> > https://lists.openembedded.org/g/openembedded-core/unsub [
> > anuj.mittal@intel.com]
> > -=-=-=-=-=-=-=-=-=-=-=-
> >
>

Patch

diff --git a/meta/lib/oeqa/selftest/cases/runtime_test.py b/meta/lib/oeqa/selftest/cases/runtime_test.py
index 9e5c3f2878..f5b3ba27a9 100644
--- a/meta/lib/oeqa/selftest/cases/runtime_test.py
+++ b/meta/lib/oeqa/selftest/cases/runtime_test.py
@@ -181,6 +181,8 @@  class TestImage(OESelftestTestCase):
             self.skipTest('virgl isn\'t working with Centos 7')
         if distro and distro == 'centos-8':
             self.skipTest('virgl isn\'t working with Centos 8')
+        if distro and distro == 'fedora-34':
+            self.skipTest('virgl isn\'t working with Fedora 34')
         if distro and distro == 'opensuseleap-15.0':
             self.skipTest('virgl isn\'t working with Opensuse 15.0')