| Message ID | 20240423120249.158876-1-iskander.amara@theobroma-systems.com |
|---|---|
| State | New |
| Headers | show |
| Series | linux-firmware: Move 9260 bluetooth firmware to a separate package | expand |
Hi Iskander, linux-firmware storing all firmwware, can you add "Intel AC 9260" in the commit title so we know what we're talking about :) ? On 4/23/24 14:02, Iskander Amara wrote: > In order to use the Intel bluetooth 9260 firmware, we need to """ In order to use Bluetooth on Intel 9260, """ is probably a better wording here? > select linux-firmware-ibt-misc package that brings a lot of fi- > mwares that are, in most cases, irrelevant for the used hardware. > > This adds a new package linux-firmware-ibt-9260 that only inclu- > des Intel 9260 bluetooth chip's firmware. > Would be nice to give the commit in linux-firmware that added the firmware for the Bluetooth part of the Intel AC 9260 to justify this change, c.f.: https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/commit/?h=20220610&id=97339b3a1d3bf3e4c40d679896a27a25fa83765f > Reported-by: Quentin Schulz <quentin.schulz@theobroma-systems.com> > Signed-off-by: Iskander Amara <iskander.amara@theobroma-systems.com> > --- > meta/recipes-kernel/linux-firmware/linux-firmware_20240312.bb | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/meta/recipes-kernel/linux-firmware/linux-firmware_20240312.bb b/meta/recipes-kernel/linux-firmware/linux-firmware_20240312.bb > index ff79bb9b33..dfa387ec11 100644 > --- a/meta/recipes-kernel/linux-firmware/linux-firmware_20240312.bb > +++ b/meta/recipes-kernel/linux-firmware/linux-firmware_20240312.bb > @@ -344,6 +344,7 @@ PACKAGES =+ "${PN}-amphion-vpu-license ${PN}-amphion-vpu \ > ${PN}-ibt-11-5 ${PN}-ibt-12-16 ${PN}-ibt-hw-37-7 ${PN}-ibt-hw-37-8 \ > ${PN}-ibt-17 \ > ${PN}-ibt-20 \ > + ${PN}-ibt-9260 \ > ${PN}-ibt-misc \ > ${PN}-i915-license ${PN}-i915 \ > ${PN}-ice-license ${PN}-ice \ > @@ -1273,6 +1274,7 @@ LICENSE:${PN}-ibt-11-5 = "Firmware-ibt_firmware" > LICENSE:${PN}-ibt-12-16 = "Firmware-ibt_firmware" > LICENSE:${PN}-ibt-17 = "Firmware-ibt_firmware" > LICENSE:${PN}-ibt-20 = "Firmware-ibt_firmware" > +LICENSE:${PN}-ibt-9260 = "Firmware-ibt_firmware" I think we should rather name this ${PN}-ibt-18 to match what seems to be the naming scheme for those packages. If you do, please order everything alphabetically (so above ibt-20 for example). Looking good otherwise. Cheers, Quentin
diff --git a/meta/recipes-kernel/linux-firmware/linux-firmware_20240312.bb b/meta/recipes-kernel/linux-firmware/linux-firmware_20240312.bb index ff79bb9b33..dfa387ec11 100644 --- a/meta/recipes-kernel/linux-firmware/linux-firmware_20240312.bb +++ b/meta/recipes-kernel/linux-firmware/linux-firmware_20240312.bb @@ -344,6 +344,7 @@ PACKAGES =+ "${PN}-amphion-vpu-license ${PN}-amphion-vpu \ ${PN}-ibt-11-5 ${PN}-ibt-12-16 ${PN}-ibt-hw-37-7 ${PN}-ibt-hw-37-8 \ ${PN}-ibt-17 \ ${PN}-ibt-20 \ + ${PN}-ibt-9260 \ ${PN}-ibt-misc \ ${PN}-i915-license ${PN}-i915 \ ${PN}-ice-license ${PN}-ice \ @@ -1273,6 +1274,7 @@ LICENSE:${PN}-ibt-11-5 = "Firmware-ibt_firmware" LICENSE:${PN}-ibt-12-16 = "Firmware-ibt_firmware" LICENSE:${PN}-ibt-17 = "Firmware-ibt_firmware" LICENSE:${PN}-ibt-20 = "Firmware-ibt_firmware" +LICENSE:${PN}-ibt-9260 = "Firmware-ibt_firmware" LICENSE:${PN}-ibt-misc = "Firmware-ibt_firmware" FILES:${PN}-ibt-license = "${nonarch_base_libdir}/firmware/LICENCE.ibt_firmware" @@ -1282,6 +1284,7 @@ FILES:${PN}-ibt-11-5 = "${nonarch_base_libdir}/firmware/intel/ibt-11-5.sfi ${ FILES:${PN}-ibt-12-16 = "${nonarch_base_libdir}/firmware/intel/ibt-12-16.sfi ${nonarch_base_libdir}/firmware/intel/ibt-12-16.ddc" FILES:${PN}-ibt-17 = "${nonarch_base_libdir}/firmware/intel/ibt-17-*.sfi ${nonarch_base_libdir}/firmware/intel/ibt-17-*.ddc" FILES:${PN}-ibt-20 = "${nonarch_base_libdir}/firmware/intel/ibt-20-*.sfi ${nonarch_base_libdir}/firmware/intel/ibt-20-*.ddc" +FILES:${PN}-ibt-9260 = "${nonarch_base_libdir}/firmware/intel/ibt-18-*.sfi ${nonarch_base_libdir}/firmware/intel/ibt-18-*.ddc" FILES:${PN}-ibt-misc = "${nonarch_base_libdir}/firmware/intel/ibt-*" RDEPENDS:${PN}-ibt-hw-37-7 = "${PN}-ibt-license" @@ -1290,6 +1293,7 @@ RDEPENDS:${PN}-ibt-11-5 = "${PN}-ibt-license" RDEPENDS:${PN}-ibt-12-16 = "${PN}-ibt-license" RDEPENDS:${PN}-ibt-17 = "${PN}-ibt-license" RDEPENDS:${PN}-ibt-20 = "${PN}-ibt-license" +RDEPENDS:${PN}-ibt-9260 = "${PN}-ibt-license" RDEPENDS:${PN}-ibt-misc = "${PN}-ibt-license" ALLOW_EMPTY:${PN}-ibt= "1"
In order to use the Intel bluetooth 9260 firmware, we need to select linux-firmware-ibt-misc package that brings a lot of fi- mwares that are, in most cases, irrelevant for the used hardware. This adds a new package linux-firmware-ibt-9260 that only inclu- des Intel 9260 bluetooth chip's firmware. Reported-by: Quentin Schulz <quentin.schulz@theobroma-systems.com> Signed-off-by: Iskander Amara <iskander.amara@theobroma-systems.com> --- meta/recipes-kernel/linux-firmware/linux-firmware_20240312.bb | 4 ++++ 1 file changed, 4 insertions(+)