diff mbox series

devtool: modify: Correct appending of type=git-dependency to URIs

Message ID 20240215221250.1161135-1-pkj@axis.com
State Accepted, archived
Commit 4de0c679e4b1a3cb394f348d625b97ad73f1efe7
Headers show
Series devtool: modify: Correct appending of type=git-dependency to URIs | expand

Commit Message

Peter Kjellerstedt Feb. 15, 2024, 10:12 p.m. UTC 
A missing space when using :append would lead to run-on URIs if there
was no whitespace at the end of the original SRC_URI.

Signed-off-by: Peter Kjellerstedt <peter.kjellerstedt@axis.com>
---
 scripts/lib/devtool/standard.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff mbox series

Patch

diff --git a/scripts/lib/devtool/standard.py b/scripts/lib/devtool/standard.py
index 8fb4b934d4..0243e3bc75 100644
--- a/scripts/lib/devtool/standard.py
+++ b/scripts/lib/devtool/standard.py
@@ -966,7 +966,7 @@  def modify(args, config, basepath, workspace):
             # Assume first entry is main source extracted in ${S} so skip it
             src_uri = src_uri[1::]
 
-            #Add "type=git-dependency" to all non local sources
+            # Add "type=git-dependency" to all non local sources
             for url in src_uri:
                 if not url.startswith('file://') and not 'type=' in url:
                     src_uri_remove.append(url)
@@ -974,7 +974,7 @@  def modify(args, config, basepath, workspace):
 
             if src_uri_remove:
                 f.write('SRC_URI:remove = "%s"\n' % ' '.join(src_uri_remove))
-                f.write('SRC_URI:append = "%s"\n\n' % ' '.join(src_uri_append))
+                f.write('SRC_URI:append = " %s"\n\n' % ' '.join(src_uri_append))
 
             f.write('FILESEXTRAPATHS:prepend := "${THISDIR}/${PN}:"\n')
             # Local files can be modified/tracked in separate subdir under srctree