| Message ID | 20240208111737.6480-1-attila.hannibal@heitec.hu |
|---|---|
| State | New |
| Headers | show |
| Series | gstreamer1.0-omx: remove commercial license flag | expand |
On Thu, 2024-02-08 at 12:17 +0100, Attila Hannibal wrote: > The gstreamer OpenMAX IL plugin is completely LGPL licensed, > the "commercial" marking should be removed. > > Signed-off-by: Attila Hannibal <attila.hannibal@heitec.hu> > --- > meta/recipes-multimedia/gstreamer/gstreamer1.0-omx_1.22.9.bb | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/meta/recipes-multimedia/gstreamer/gstreamer1.0-omx_1.22.9.bb b/meta/recipes-multimedia/gstreamer/gstreamer1.0-omx_1.22.9.bb > index 05d64748bb..fad3714839 100644 > --- a/meta/recipes-multimedia/gstreamer/gstreamer1.0-omx_1.22.9.bb > +++ b/meta/recipes-multimedia/gstreamer/gstreamer1.0-omx_1.22.9.bb > @@ -4,7 +4,6 @@ HOMEPAGE = "http://gstreamer.freedesktop.org/" > SECTION = "multimedia" > > LICENSE = "LGPL-2.1-or-later" > -LICENSE_FLAGS = "commercial" > LIC_FILES_CHKSUM = "file://COPYING;md5=4fbd65380cdd255951079008b364516c \ > file://omx/gstomx.h;beginline=1;endline=21;md5=5c8e1fca32704488e76d2ba9ddfa935f" > This is not about the license of the code but whether you can actually use the codecs in there without some kind of license to do so. Even if code is open source, the algorithms it implements can have other restrictions. Cheers, Richard
Yes, based on the Readme in the gstreamer-omx repo ( https://github.com/GStreamer/gst-omx/blob/master/README) it and its contents are LGPL. In case it uses external codecs, shouldn't the external codecs recipe(s) contain the commercial license flag? Attila On Thu, Feb 8, 2024 at 12:22 PM Richard Purdie < richard.purdie@linuxfoundation.org> wrote: > On Thu, 2024-02-08 at 12:17 +0100, Attila Hannibal wrote: > > The gstreamer OpenMAX IL plugin is completely LGPL licensed, > > the "commercial" marking should be removed. > > > > Signed-off-by: Attila Hannibal <attila.hannibal@heitec.hu> > > --- > > meta/recipes-multimedia/gstreamer/gstreamer1.0-omx_1.22.9.bb | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/meta/recipes-multimedia/gstreamer/ > gstreamer1.0-omx_1.22.9.bb b/meta/recipes-multimedia/gstreamer/ > gstreamer1.0-omx_1.22.9.bb > > index 05d64748bb..fad3714839 100644 > > --- a/meta/recipes-multimedia/gstreamer/gstreamer1.0-omx_1.22.9.bb > > +++ b/meta/recipes-multimedia/gstreamer/gstreamer1.0-omx_1.22.9.bb > > @@ -4,7 +4,6 @@ HOMEPAGE = "http://gstreamer.freedesktop.org/" > > SECTION = "multimedia" > > > > LICENSE = "LGPL-2.1-or-later" > > -LICENSE_FLAGS = "commercial" > > LIC_FILES_CHKSUM = "file://COPYING;md5=4fbd65380cdd255951079008b364516c > \ > > > file://omx/gstomx.h;beginline=1;endline=21;md5=5c8e1fca32704488e76d2ba9ddfa935f" > > > > This is not about the license of the code but whether you can actually > use the codecs in there without some kind of license to do so. > > Even if code is open source, the algorithms it implements can have > other restrictions. > > Cheers, > > Richard > >
I guess it's better to be cautious here. There can be multiple implementations of the codecs, we can't ensure they all have the flag, and gstreamer1.0-omx needs one of them to function, so there's no scenario where the commercial flag would not apply. Alex On Thu, 8 Feb 2024 at 12:31, Attila Hannibal <attila.hannibal@gmail.com> wrote: > > Yes, based on the Readme in the gstreamer-omx repo (https://github.com/GStreamer/gst-omx/blob/master/README) it and its contents are LGPL. > > In case it uses external codecs, shouldn't the external codecs recipe(s) contain the commercial license flag? > > > > Attila > > > On Thu, Feb 8, 2024 at 12:22 PM Richard Purdie <richard.purdie@linuxfoundation.org> wrote: >> >> On Thu, 2024-02-08 at 12:17 +0100, Attila Hannibal wrote: >> > The gstreamer OpenMAX IL plugin is completely LGPL licensed, >> > the "commercial" marking should be removed. >> > >> > Signed-off-by: Attila Hannibal <attila.hannibal@heitec.hu> >> > --- >> > meta/recipes-multimedia/gstreamer/gstreamer1.0-omx_1.22.9.bb | 1 - >> > 1 file changed, 1 deletion(-) >> > >> > diff --git a/meta/recipes-multimedia/gstreamer/gstreamer1.0-omx_1.22.9.bb b/meta/recipes-multimedia/gstreamer/gstreamer1.0-omx_1.22.9.bb >> > index 05d64748bb..fad3714839 100644 >> > --- a/meta/recipes-multimedia/gstreamer/gstreamer1.0-omx_1.22.9.bb >> > +++ b/meta/recipes-multimedia/gstreamer/gstreamer1.0-omx_1.22.9.bb >> > @@ -4,7 +4,6 @@ HOMEPAGE = "http://gstreamer.freedesktop.org/" >> > SECTION = "multimedia" >> > >> > LICENSE = "LGPL-2.1-or-later" >> > -LICENSE_FLAGS = "commercial" >> > LIC_FILES_CHKSUM = "file://COPYING;md5=4fbd65380cdd255951079008b364516c \ >> > file://omx/gstomx.h;beginline=1;endline=21;md5=5c8e1fca32704488e76d2ba9ddfa935f" >> > >> >> This is not about the license of the code but whether you can actually >> use the codecs in there without some kind of license to do so. >> >> Even if code is open source, the algorithms it implements can have >> other restrictions. >> >> Cheers, >> >> Richard >> > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#195138): https://lists.openembedded.org/g/openembedded-core/message/195138 > Mute This Topic: https://lists.openembedded.org/mt/104236817/1686489 > Group Owner: openembedded-core+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [alex.kanavin@gmail.com] > -=-=-=-=-=-=-=-=-=-=-=- >
On 8 Feb 2024, at 11:30, Attila Hannibal via lists.openembedded.org <attila.hannibal=gmail.com@lists.openembedded.org> wrote: > > Yes, based on the Readme in the gstreamer-omx repo (https://github.com/GStreamer/gst-omx/blob/master/README) it and its contents are LGPL. > In case it uses external codecs, shouldn't the external codecs recipe(s) contain the commercial license flag? Arguably, yes. gst-omx just makes calls to OMX and that typically hits hardware, and whether or not you have a license for that isn’t something you can reduce down to “gst-omx has commercial implications”. That said, I struggle to have a strong opinion considering this was merged into GStreamer seven months ago: https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/4976 The next release of GStreamer will not have an OpenMAX plugin. Their recommendation is to just use v4l2 instead. If you’re working on something new, I’d be talking to your vendor about how to handle this moving forward. Ross
diff --git a/meta/recipes-multimedia/gstreamer/gstreamer1.0-omx_1.22.9.bb b/meta/recipes-multimedia/gstreamer/gstreamer1.0-omx_1.22.9.bb index 05d64748bb..fad3714839 100644 --- a/meta/recipes-multimedia/gstreamer/gstreamer1.0-omx_1.22.9.bb +++ b/meta/recipes-multimedia/gstreamer/gstreamer1.0-omx_1.22.9.bb @@ -4,7 +4,6 @@ HOMEPAGE = "http://gstreamer.freedesktop.org/" SECTION = "multimedia" LICENSE = "LGPL-2.1-or-later" -LICENSE_FLAGS = "commercial" LIC_FILES_CHKSUM = "file://COPYING;md5=4fbd65380cdd255951079008b364516c \ file://omx/gstomx.h;beginline=1;endline=21;md5=5c8e1fca32704488e76d2ba9ddfa935f"
The gstreamer OpenMAX IL plugin is completely LGPL licensed, the "commercial" marking should be removed. Signed-off-by: Attila Hannibal <attila.hannibal@heitec.hu> --- meta/recipes-multimedia/gstreamer/gstreamer1.0-omx_1.22.9.bb | 1 - 1 file changed, 1 deletion(-)