diff mbox series

pulseaudio: Update to 17.0

Message ID 20240123140833.1372704-1-festevam@gmail.com
State Accepted, archived
Commit 123c75bd87330a81ba5b929c35ae34710ddcc449
Headers show
Series pulseaudio: Update to 17.0 | expand

Commit Message

Fabio Estevam Jan. 23, 2024, 2:08 p.m. UTC 
From: Fabio Estevam <festevam@denx.de>

Update to pulseaudio 17.0 version.

Since pulseaudio commit e96d278bfc51 ("daemon/meson.build: Install
dbus policy in /usr, not /etc"), ${datadir} needs to be passed
in FILES, otherwise the following QA error is seen:

ERROR: pulseaudio-17.0-r0 do_package: QA Issue: pulseaudio: Files/directories were installed but not shipped in any package:
  /usr/share/dbus-1
  /usr/share/dbus-1/system.d
  /usr/share/dbus-1/system.d/pulseaudio-system.conf

Signed-off-by: Fabio Estevam <festevam@denx.de>
---
 meta/recipes-multimedia/pulseaudio/pulseaudio.inc               | 2 +-
 .../pulseaudio/{pulseaudio_16.1.bb => pulseaudio_17.0.bb}       | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
 rename meta/recipes-multimedia/pulseaudio/{pulseaudio_16.1.bb => pulseaudio_17.0.bb} (84%)

Comments

Ross Burton Jan. 24, 2024, 12:48 p.m. UTC | #1 
On 23 Jan 2024, at 14:08, Fabio Estevam via lists.openembedded.org <festevam=gmail.com@lists.openembedded.org> wrote:
> +FILES:${PN}-server = "${bindir}/pulseaudio ${bindir}/start-* ${datadir} ${sysconfdir} ${bindir}/pactl */udev/rules.d/*.rules */*/udev/rules.d/*.rules ${systemd_user_unitdir}/*”

It’s best not to add entire trees like ${datadir} to files, as there may be unexpected consequences.

If you run buildhistory-diff to verify the packaging changes, then you’ll see this did not do what you wanted:

packages/cortexa57-poky-linux/pulseaudio/pulseaudio-doc: PKGSIZE changed from 70855 to 0 (-100%)
packages/cortexa57-poky-linux/pulseaudio/pulseaudio-locale-af: FILELIST: removed all items "/usr/share/locale/af/LC_MESSAGES/pulseaudio.mo"
packages/cortexa57-poky-linux/pulseaudio/pulseaudio-locale-af: PKGSIZE changed from 10401 to 0 (-100%)
packages/cortexa57-poky-linux/pulseaudio/pulseaudio-locale-as: FILELIST: removed all items "/usr/share/locale/as/LC_MESSAGES/pulseaudio.mo"
packages/cortexa57-poky-linux/pulseaudio/pulseaudio-locale-as: PKGSIZE changed from 39885 to 0 (-100%)
packages/cortexa57-poky-linux/pulseaudio/pulseaudio-locale-be: FILELIST: removed all items "/usr/share/locale/be/LC_MESSAGES/pulseaudio.mo"
packages/cortexa57-poky-linux/pulseaudio/pulseaudio-locale-be: PKGSIZE changed from 60632 to 0 (-100%)
packages/cortexa57-poky-linux/pulseaudio/pulseaudio-locale-bg: FILELIST: removed all items "/usr/share/locale/bg/LC_MESSAGES/pulseaudio.mo"
packages/cortexa57-poky-linux/pulseaudio/pulseaudio-locale-bg: PKGSIZE changed from 1937 to 0 (-100%)
[ skip tens more locale packages ]
packages/cortexa57-poky-linux/pulseaudio/pulseaudio-locale-zh-tw: FILELIST: removed all items "/usr/share/locale/zh_TW/LC_MESSAGES/pulseaudio.mo"
packages/cortexa57-poky-linux/pulseaudio/pulseaudio-locale-zh-tw: PKGSIZE changed from 57726 to 0 (-100%)
packages/cortexa57-poky-linux/pulseaudio/pulseaudio-server: FILELIST: directory renamed /etc/dbus-1/system.d -> /usr/share/dbus-1/system.d, added "/usr/share/locale/sv/LC_MESSAGES/pulseaudio.mo /usr/share/bash-completion/completions/pulseaudio /usr/share/locale/el/LC_MESSAGES/pulseaudio.mo /usr/share/locale/uk/LC_MESSAGES/pulseaudio.mo /usr/share/locale/be/LC_MESSAGES/pulseaudio.mo /usr/share/man/man1/start-pulseaudio-x11.1 /usr/share/locale/nl/LC_MESSAGES/pulseaudio.mo /usr/share/man/man1/pamon.1 /usr/share/bash-completion/completions/pactl /usr/share/vala/vapi/libpulse-simple.deps /usr/share/locale/he/LC_MESSAGES/pulseaudio.mo /usr/share/locale/ja/LC_MESSAGES/pulseaudio.mo /usr/share/locale/nn/LC_MESSAGES/pulseaudio.mo /usr/share/locale/pl/LC_MESSAGES/pulseaudio.mo /usr/share/locale/pt_BR/LC_MESSAGES/pulseaudio.mo /usr/share/bash-completion/completions/pasuspender /usr/share/locale/kk/LC_MESSAGES/pulseaudio.mo /usr/share/locale/eu/LC_MESSAGES/pulseaudio.mo /usr/share/locale/bg/LC_MESSAGES/pulseaudio.mo /usr/share/locale/kn/LC_MESSAGES/pulseaudio.mo /usr/share/locale/hu/LC_MESSAGES/pulseaudio.mo /usr/share/locale/oc/LC_MESSAGES/pulseaudio.mo /usr/share/man/man1/pax11publish.1 /usr/share/man/man5/pulse-daemon.conf.5 /usr/share/locale/sr/LC_MESSAGES/pulseaudio.mo /usr/share/locale/pt/LC_MESSAGES/pulseaudio.mo /usr/share/locale/id/LC_MESSAGES/pulseaudio.mo /usr/share/locale/gl/LC_MESSAGES/pulseaudio.mo /usr/share/locale/hi/LC_MESSAGES/pulseaudio.mo /usr/share/man/man5/default.pa.5 /usr/share/bash-completion/completions/paplay /usr/share/locale/hr/LC_MESSAGES/pulseaudio.mo /usr/share/vala/vapi/libpulse.vapi /usr/share/locale/pa/LC_MESSAGES/pulseaudio.mo /usr/share/locale/zh_CN/LC_MESSAGES/pulseaudio.mo /usr/share/locale/de/LC_MESSAGES/pulseaudio.mo /usr/share/locale/as/LC_MESSAGES/pulseaudio.mo /usr/share/man/man1/padsp.1 /usr/share/locale/es/LC_MESSAGES/pulseaudio.mo /usr/share/man/man1/parec.1 /usr/share/locale/af/LC_MESSAGES/pulseaudio.mo /usr/share/locale/ml/LC_MESSAGES/pulseaudio.mo /usr/share/man/man1/pacat.1 /usr/share/locale/ru/LC_MESSAGES/pulseaudio.mo /usr/share/locale/it/LC_MESSAGES/pulseaudio.mo /usr/share/bash-completion/completions/parecord /usr/share/man/man5/pulse-cli-syntax.5 /usr/share/locale/lt/LC_MESSAGES/pulseaudio.mo /usr/share/man/man1/parecord.1 /usr/share/bash-completion/completions/pacmd /usr/share/locale/da/LC_MESSAGES/pulseaudio.mo /usr/share/man/man1/pactl.1 /usr/share/locale/tr/LC_MESSAGES/pulseaudio.mo /usr/share/locale/de_CH/LC_MESSAGES/pulseaudio.mo /usr/share/locale/si/LC_MESSAGES/pulseaudio.mo /usr/share/locale/zh_TW/LC_MESSAGES/pulseaudio.mo /usr/share/locale/gu/LC_MESSAGES/pulseaudio.mo /usr/share/locale/fr/LC_MESSAGES/pulseaudio.mo /usr/share/man/man1/pacmd.1 /usr/share/man/man1/paplay.1 /usr/share/locale/sk/LC_MESSAGES/pulseaudio.mo /usr/share/bash-completion/completions/padsp /usr/share/locale/ca/LC_MESSAGES/pulseaudio.mo /usr/share/locale/eo/LC_MESSAGES/pulseaudio.mo /usr/share/locale/mr/LC_MESSAGES/pulseaudio.mo /usr/share/vala/vapi/libpulse-mainloop-glib.deps /usr/share/man/man1/pasuspender.1 /usr/share/locale/sr@latin/LC_MESSAGES/pulseaudio.mo /usr/share/locale/cs/LC_MESSAGES/pulseaudio.mo /usr/share/locale/te/LC_MESSAGES/pulseaudio.mo /usr/share/vala/vapi/libpulse.deps /usr/share/locale/bn_IN/LC_MESSAGES/pulseaudio.mo /usr/share/locale/ka/LC_MESSAGES/pulseaudio.mo /usr/share/bash-completion/completions/pacat /usr/share/man/man1/pulseaudio.1 /usr/share/locale/ko/LC_MESSAGES/pulseaudio.mo /usr/share/locale/or/LC_MESSAGES/pulseaudio.mo /usr/share/locale/fi/LC_MESSAGES/pulseaudio.mo /usr/share/man/man5/pulse-client.conf.5 /usr/share/vala/vapi/libpulse-mainloop-glib.vapi /usr/share/bash-completion/completions/parec /usr/share/vala/vapi/libpulse-simple.vapi /usr/share/locale/ta/LC_MESSAGES/pulseaudio.mo"
packages/cortexa57-poky-linux/pulseaudio/pulseaudio-server: PKGSIZE changed from 301327 to 2990540 (+892%)

All of the locales, the bash completion, the vapi files, and the documentation is now in the pulseaudio-server package.

When changing packaging rules, please remember to verify the packaging.

Ross
Fabio Estevam Jan. 24, 2024, 1 p.m. UTC | #2 
Hi Ross,

On Wed, Jan 24, 2024 at 9:48 AM Ross Burton <Ross.Burton@arm.com> wrote:
>
> On 23 Jan 2024, at 14:08, Fabio Estevam via lists.openembedded.org <festevam=gmail.com@lists.openembedded.org> wrote:
> > +FILES:${PN}-server = "${bindir}/pulseaudio ${bindir}/start-* ${datadir} ${sysconfdir} ${bindir}/pactl */udev/rules.d/*.rules */*/udev/rules.d/*.rules ${systemd_user_unitdir}/*”
>
> It’s best not to add entire trees like ${datadir} to files, as there may be unexpected consequences.

Thanks for the feedback.

I will send v2 that only adds the specific file instead:

FILES:${PN}-server += "${datadir}/dbus-1/system.d/pulseaudio-system.conf"
diff mbox series

Patch

diff --git a/meta/recipes-multimedia/pulseaudio/pulseaudio.inc b/meta/recipes-multimedia/pulseaudio/pulseaudio.inc
index 2245a73392..a55b5d12eb 100644
--- a/meta/recipes-multimedia/pulseaudio/pulseaudio.inc
+++ b/meta/recipes-multimedia/pulseaudio/pulseaudio.inc
@@ -186,7 +186,7 @@  FILES:libpulse-mainloop-glib = "${libdir}/libpulse-mainloop-glib.so.*"
 FILES:${PN}-dev += "${libdir}/pulse-${PV}/modules/*.la ${datadir}/vala"
 FILES:${PN}-bin += "${sysconfdir}/default/volatiles/04_pulse"
 FILES:${PN}-pa-info = "${bindir}/pa-info"
-FILES:${PN}-server = "${bindir}/pulseaudio ${bindir}/start-* ${sysconfdir} ${bindir}/pactl */udev/rules.d/*.rules */*/udev/rules.d/*.rules ${systemd_user_unitdir}/*"
+FILES:${PN}-server = "${bindir}/pulseaudio ${bindir}/start-* ${datadir} ${sysconfdir} ${bindir}/pactl */udev/rules.d/*.rules */*/udev/rules.d/*.rules ${systemd_user_unitdir}/*"
 
 #SYSTEMD_PACKAGES = "${PN}-server"
 SYSTEMD_SERVICE:${PN}-server = "pulseaudio.service"
diff --git a/meta/recipes-multimedia/pulseaudio/pulseaudio_16.1.bb b/meta/recipes-multimedia/pulseaudio/pulseaudio_17.0.bb
similarity index 84%
rename from meta/recipes-multimedia/pulseaudio/pulseaudio_16.1.bb
rename to meta/recipes-multimedia/pulseaudio/pulseaudio_17.0.bb
index 64002cd1cc..54c79b4097 100644
--- a/meta/recipes-multimedia/pulseaudio/pulseaudio_16.1.bb
+++ b/meta/recipes-multimedia/pulseaudio/pulseaudio_17.0.bb
@@ -6,5 +6,5 @@  SRC_URI = "http://freedesktop.org/software/pulseaudio/releases/${BP}.tar.xz \
            file://volatiles.04_pulse \
            file://0001-doxygen-meson.build-remove-dependency-on-doxygen-bin.patch \
            "
-SRC_URI[sha256sum] = "8eef32ce91d47979f95fd9a935e738cd7eb7463430dabc72863251751e504ae4"
+SRC_URI[sha256sum] = "053794d6671a3e397d849e478a80b82a63cb9d8ca296bd35b73317bb5ceb87b5"
 UPSTREAM_CHECK_REGEX = "pulseaudio-(?P<pver>\d+(\.(?!99)\d+)+)\.tar"