| Message ID | 20240119073509.934362-1-changqing.li@windriver.com |
|---|---|
| State | New |
| Headers | show |
| Series | tcmode-default.inc: use ?= to set PREFERRED_VERSION_llvm/llvm-native/nativesdk-llvm | expand |
On Fri, 2024-01-19 at 15:35 +0800, Changqing Li wrote: > From: Changqing Li <changqing.li@windriver.com> > > use ?= to set following configs in order to allow user > to override the default settings: > PREFERRED_VERSION_llvm > PREFERRED_VERSION_llvm-native > PREFERRED_VERSION_nativesdk-llvm > > Signed-off-by: Changqing Li <changqing.li@windriver.com> > --- > meta/conf/distro/include/tcmode-default.inc | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) You're said what this does but not *why*. I'm not against doing this but I do want to make it clear it is actually quite risky as others often rely on the existing behaviour. Cheers, Richard
Do you need to override the PREFERRED_VERSION_? instead of overriding LLVMVERSION? Aren't you trying to fix what was fixed in proposed change a while ago: https://patchwork.yoctoproject.org/project/oe-core/patch/20230401163241.354257-1-Martin.Jansa@gmail.com/ On Fri, Jan 19, 2024 at 8:35 AM Changqing Li <changqing.li@eng.windriver.com> wrote: > From: Changqing Li <changqing.li@windriver.com> > > use ?= to set following configs in order to allow user > to override the default settings: > PREFERRED_VERSION_llvm > PREFERRED_VERSION_llvm-native > PREFERRED_VERSION_nativesdk-llvm > > Signed-off-by: Changqing Li <changqing.li@windriver.com> > --- > meta/conf/distro/include/tcmode-default.inc | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/meta/conf/distro/include/tcmode-default.inc > b/meta/conf/distro/include/tcmode-default.inc > index 3720a4c5b8..0de858d3af 100644 > --- a/meta/conf/distro/include/tcmode-default.inc > +++ b/meta/conf/distro/include/tcmode-default.inc > @@ -77,9 +77,9 @@ PREFERRED_VERSION_go-runtime ?= "${GOVERSION}" > PREFERRED_VERSION_nativesdk-go ?= "${GOVERSION}" > PREFERRED_VERSION_nativesdk-go-runtime ?= "${GOVERSION}" > > -PREFERRED_VERSION_llvm = "${LLVMVERSION}" > -PREFERRED_VERSION_llvm-native = "${LLVMVERSION}" > -PREFERRED_VERSION_nativesdk-llvm = "${LLVMVERSION}" > +PREFERRED_VERSION_llvm ?= "${LLVMVERSION}" > +PREFERRED_VERSION_llvm-native ?= "${LLVMVERSION}" > +PREFERRED_VERSION_nativesdk-llvm ?= "${LLVMVERSION}" > > # Rust toolchain preferred versions: > > -- > 2.25.1 > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#194017): > https://lists.openembedded.org/g/openembedded-core/message/194017 > Mute This Topic: https://lists.openembedded.org/mt/103826050/3617156 > Group Owner: openembedded-core+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [ > martin.jansa@gmail.com] > -=-=-=-=-=-=-=-=-=-=-=- > >
On 1/19/24 17:29, Richard Purdie wrote: > CAUTION: This email comes from a non Wind River email account! > Do not click links or open attachments unless you recognize the sender and know the content is safe. > > On Fri, 2024-01-19 at 15:35 +0800, Changqing Li wrote: >> From: Changqing Li<changqing.li@windriver.com> >> >> use ?= to set following configs in order to allow user >> to override the default settings: >> PREFERRED_VERSION_llvm >> PREFERRED_VERSION_llvm-native >> PREFERRED_VERSION_nativesdk-llvm >> >> Signed-off-by: Changqing Li<changqing.li@windriver.com> >> --- >> meta/conf/distro/include/tcmode-default.inc | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) > You're said what this does but not *why*. I'm not against doing this > but I do want to make it clear it is actually quite risky as others > often rely on the existing behaviour. OK, I will send a V2, add more detail commit messages. The reason is that LLVMVERSION is set to a higher version in meta-clang's layer.conf, and set PREFERRED_PROVIDER_llvm = "clang", so llvm is actually provided by clang. but this PREFERRED_VERSION_llvm setting makes bitbake llvm-native have this warning: WARNING: preferred version 16.0.1 of llvm-native not available (for item llvm-native) WARNING: versions of llvm-native available: 15.0.7 I want to set this PREFERRED_VERSION_xxx to ?=, so that is meta-clang is included, this PREFERRED_VERSION_xxx can be override to fix above warning. Regards Sandy > > Cheers, > > Richard
Yes On 1/19/24 19:57, Martin Jansa wrote: > ** > *CAUTION: This email comes from a non Wind River email account!* > Do not click links or open attachments unless you recognize the sender > and know the content is safe. > Do you need to override the PREFERRED_VERSION_? instead of overriding > LLVMVERSION? > > Aren't you trying to fix what was fixed in proposed change a while ago: > https://patchwork.yoctoproject.org/project/oe-core/patch/20230401163241.354257-1-Martin.Jansa@gmail.com/ > <https://urldefense.com/v3/__https://patchwork.yoctoproject.org/project/oe-core/patch/20230401163241.354257-1-Martin.Jansa@gmail.com/__;!!AjveYdw8EvQ!fHtiSeYD8TPEVNtjfDtPZrodZY3GykPPupY5y-fmJHKZ6GInFWbYKkRN5UpNDB4pdgdmAzzT-aah4fEExz_0nBedyN8m3FE$> > > On Fri, Jan 19, 2024 at 8:35 AM Changqing Li > <changqing.li@eng.windriver.com> wrote: > > From: Changqing Li <changqing.li@windriver.com> > > use ?= to set following configs in order to allow user > to override the default settings: > PREFERRED_VERSION_llvm > PREFERRED_VERSION_llvm-native > PREFERRED_VERSION_nativesdk-llvm > > Signed-off-by: Changqing Li <changqing.li@windriver.com> > --- > meta/conf/distro/include/tcmode-default.inc > <https://urldefense.com/v3/__http://tcmode-default.inc__;!!AjveYdw8EvQ!fHtiSeYD8TPEVNtjfDtPZrodZY3GykPPupY5y-fmJHKZ6GInFWbYKkRN5UpNDB4pdgdmAzzT-aah4fEExz_0nBedwNSyZRE$> > | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/meta/conf/distro/include/tcmode-default.inc > <https://urldefense.com/v3/__http://tcmode-default.inc__;!!AjveYdw8EvQ!fHtiSeYD8TPEVNtjfDtPZrodZY3GykPPupY5y-fmJHKZ6GInFWbYKkRN5UpNDB4pdgdmAzzT-aah4fEExz_0nBedwNSyZRE$> > b/meta/conf/distro/include/tcmode-default.inc > <https://urldefense.com/v3/__http://tcmode-default.inc__;!!AjveYdw8EvQ!fHtiSeYD8TPEVNtjfDtPZrodZY3GykPPupY5y-fmJHKZ6GInFWbYKkRN5UpNDB4pdgdmAzzT-aah4fEExz_0nBedwNSyZRE$> > index 3720a4c5b8..0de858d3af 100644 > --- a/meta/conf/distro/include/tcmode-default.inc > <https://urldefense.com/v3/__http://tcmode-default.inc__;!!AjveYdw8EvQ!fHtiSeYD8TPEVNtjfDtPZrodZY3GykPPupY5y-fmJHKZ6GInFWbYKkRN5UpNDB4pdgdmAzzT-aah4fEExz_0nBedwNSyZRE$> > +++ b/meta/conf/distro/include/tcmode-default.inc > <https://urldefense.com/v3/__http://tcmode-default.inc__;!!AjveYdw8EvQ!fHtiSeYD8TPEVNtjfDtPZrodZY3GykPPupY5y-fmJHKZ6GInFWbYKkRN5UpNDB4pdgdmAzzT-aah4fEExz_0nBedwNSyZRE$> > @@ -77,9 +77,9 @@ PREFERRED_VERSION_go-runtime ?= "${GOVERSION}" > PREFERRED_VERSION_nativesdk-go ?= "${GOVERSION}" > PREFERRED_VERSION_nativesdk-go-runtime ?= "${GOVERSION}" > > -PREFERRED_VERSION_llvm = "${LLVMVERSION}" > -PREFERRED_VERSION_llvm-native = "${LLVMVERSION}" > -PREFERRED_VERSION_nativesdk-llvm = "${LLVMVERSION}" > +PREFERRED_VERSION_llvm ?= "${LLVMVERSION}" > +PREFERRED_VERSION_llvm-native ?= "${LLVMVERSION}" > +PREFERRED_VERSION_nativesdk-llvm ?= "${LLVMVERSION}" > > # Rust toolchain preferred versions: > > -- > 2.25.1 > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#194017): > https://lists.openembedded.org/g/openembedded-core/message/194017 > <https://urldefense.com/v3/__https://lists.openembedded.org/g/openembedded-core/message/194017__;!!AjveYdw8EvQ!fHtiSeYD8TPEVNtjfDtPZrodZY3GykPPupY5y-fmJHKZ6GInFWbYKkRN5UpNDB4pdgdmAzzT-aah4fEExz_0nBednypl0Xw$> > Mute This Topic: > https://lists.openembedded.org/mt/103826050/3617156 > <https://urldefense.com/v3/__https://lists.openembedded.org/mt/103826050/3617156__;!!AjveYdw8EvQ!fHtiSeYD8TPEVNtjfDtPZrodZY3GykPPupY5y-fmJHKZ6GInFWbYKkRN5UpNDB4pdgdmAzzT-aah4fEExz_0nBed8jl75qI$> > Group Owner: openembedded-core+owner@lists.openembedded.org > <mailto:openembedded-core%2Bowner@lists.openembedded.org> > Unsubscribe: > https://lists.openembedded.org/g/openembedded-core/unsub > <https://urldefense.com/v3/__https://lists.openembedded.org/g/openembedded-core/unsub__;!!AjveYdw8EvQ!fHtiSeYD8TPEVNtjfDtPZrodZY3GykPPupY5y-fmJHKZ6GInFWbYKkRN5UpNDB4pdgdmAzzT-aah4fEExz_0nBed3Rcbu4Y$> > [martin.jansa@gmail.com] > -=-=-=-=-=-=-=-=-=-=-=- >
So please suggest a variable name which Richard will accept as I think it's easier to use separate variable than overriding all 3 PREFERRED_VERSION_llvm* to version currently in oe-core whenever someone wants to use meta-clang. On Mon, Jan 22, 2024 at 1:58 AM Changqing Li <changqing.li@windriver.com> wrote: > Yes > On 1/19/24 19:57, Martin Jansa wrote: > > *CAUTION: This email comes from a non Wind River email account!* > Do not click links or open attachments unless you recognize the sender and > know the content is safe. > Do you need to override the PREFERRED_VERSION_? instead of overriding > LLVMVERSION? > > Aren't you trying to fix what was fixed in proposed change a while ago: > > https://patchwork.yoctoproject.org/project/oe-core/patch/20230401163241.354257-1-Martin.Jansa@gmail.com/ > <https://urldefense.com/v3/__https://patchwork.yoctoproject.org/project/oe-core/patch/20230401163241.354257-1-Martin.Jansa@gmail.com/__;!!AjveYdw8EvQ!fHtiSeYD8TPEVNtjfDtPZrodZY3GykPPupY5y-fmJHKZ6GInFWbYKkRN5UpNDB4pdgdmAzzT-aah4fEExz_0nBedyN8m3FE$> > > On Fri, Jan 19, 2024 at 8:35 AM Changqing Li < > changqing.li@eng.windriver.com> wrote: > >> From: Changqing Li <changqing.li@windriver.com> >> >> use ?= to set following configs in order to allow user >> to override the default settings: >> PREFERRED_VERSION_llvm >> PREFERRED_VERSION_llvm-native >> PREFERRED_VERSION_nativesdk-llvm >> >> Signed-off-by: Changqing Li <changqing.li@windriver.com> >> --- >> meta/conf/distro/include/tcmode-default.inc >> <https://urldefense.com/v3/__http://tcmode-default.inc__;!!AjveYdw8EvQ!fHtiSeYD8TPEVNtjfDtPZrodZY3GykPPupY5y-fmJHKZ6GInFWbYKkRN5UpNDB4pdgdmAzzT-aah4fEExz_0nBedwNSyZRE$> >> | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/meta/conf/distro/include/tcmode-default.inc >> <https://urldefense.com/v3/__http://tcmode-default.inc__;!!AjveYdw8EvQ!fHtiSeYD8TPEVNtjfDtPZrodZY3GykPPupY5y-fmJHKZ6GInFWbYKkRN5UpNDB4pdgdmAzzT-aah4fEExz_0nBedwNSyZRE$> >> b/meta/conf/distro/include/tcmode-default.inc >> <https://urldefense.com/v3/__http://tcmode-default.inc__;!!AjveYdw8EvQ!fHtiSeYD8TPEVNtjfDtPZrodZY3GykPPupY5y-fmJHKZ6GInFWbYKkRN5UpNDB4pdgdmAzzT-aah4fEExz_0nBedwNSyZRE$> >> index 3720a4c5b8..0de858d3af 100644 >> --- a/meta/conf/distro/include/tcmode-default.inc >> <https://urldefense.com/v3/__http://tcmode-default.inc__;!!AjveYdw8EvQ!fHtiSeYD8TPEVNtjfDtPZrodZY3GykPPupY5y-fmJHKZ6GInFWbYKkRN5UpNDB4pdgdmAzzT-aah4fEExz_0nBedwNSyZRE$> >> +++ b/meta/conf/distro/include/tcmode-default.inc >> <https://urldefense.com/v3/__http://tcmode-default.inc__;!!AjveYdw8EvQ!fHtiSeYD8TPEVNtjfDtPZrodZY3GykPPupY5y-fmJHKZ6GInFWbYKkRN5UpNDB4pdgdmAzzT-aah4fEExz_0nBedwNSyZRE$> >> @@ -77,9 +77,9 @@ PREFERRED_VERSION_go-runtime ?= "${GOVERSION}" >> PREFERRED_VERSION_nativesdk-go ?= "${GOVERSION}" >> PREFERRED_VERSION_nativesdk-go-runtime ?= "${GOVERSION}" >> >> -PREFERRED_VERSION_llvm = "${LLVMVERSION}" >> -PREFERRED_VERSION_llvm-native = "${LLVMVERSION}" >> -PREFERRED_VERSION_nativesdk-llvm = "${LLVMVERSION}" >> +PREFERRED_VERSION_llvm ?= "${LLVMVERSION}" >> +PREFERRED_VERSION_llvm-native ?= "${LLVMVERSION}" >> +PREFERRED_VERSION_nativesdk-llvm ?= "${LLVMVERSION}" >> >> # Rust toolchain preferred versions: >> >> -- >> 2.25.1 >> >> >> -=-=-=-=-=-=-=-=-=-=-=- >> Links: You receive all messages sent to this group. >> View/Reply Online (#194017): >> https://lists.openembedded.org/g/openembedded-core/message/194017 >> <https://urldefense.com/v3/__https://lists.openembedded.org/g/openembedded-core/message/194017__;!!AjveYdw8EvQ!fHtiSeYD8TPEVNtjfDtPZrodZY3GykPPupY5y-fmJHKZ6GInFWbYKkRN5UpNDB4pdgdmAzzT-aah4fEExz_0nBednypl0Xw$> >> Mute This Topic: https://lists.openembedded.org/mt/103826050/3617156 >> <https://urldefense.com/v3/__https://lists.openembedded.org/mt/103826050/3617156__;!!AjveYdw8EvQ!fHtiSeYD8TPEVNtjfDtPZrodZY3GykPPupY5y-fmJHKZ6GInFWbYKkRN5UpNDB4pdgdmAzzT-aah4fEExz_0nBed8jl75qI$> >> Group Owner: openembedded-core+owner@lists.openembedded.org >> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub >> <https://urldefense.com/v3/__https://lists.openembedded.org/g/openembedded-core/unsub__;!!AjveYdw8EvQ!fHtiSeYD8TPEVNtjfDtPZrodZY3GykPPupY5y-fmJHKZ6GInFWbYKkRN5UpNDB4pdgdmAzzT-aah4fEExz_0nBed3Rcbu4Y$> >> [martin.jansa@gmail.com] >> -=-=-=-=-=-=-=-=-=-=-=- >> >>
diff --git a/meta/conf/distro/include/tcmode-default.inc b/meta/conf/distro/include/tcmode-default.inc index 3720a4c5b8..0de858d3af 100644 --- a/meta/conf/distro/include/tcmode-default.inc +++ b/meta/conf/distro/include/tcmode-default.inc @@ -77,9 +77,9 @@ PREFERRED_VERSION_go-runtime ?= "${GOVERSION}" PREFERRED_VERSION_nativesdk-go ?= "${GOVERSION}" PREFERRED_VERSION_nativesdk-go-runtime ?= "${GOVERSION}" -PREFERRED_VERSION_llvm = "${LLVMVERSION}" -PREFERRED_VERSION_llvm-native = "${LLVMVERSION}" -PREFERRED_VERSION_nativesdk-llvm = "${LLVMVERSION}" +PREFERRED_VERSION_llvm ?= "${LLVMVERSION}" +PREFERRED_VERSION_llvm-native ?= "${LLVMVERSION}" +PREFERRED_VERSION_nativesdk-llvm ?= "${LLVMVERSION}" # Rust toolchain preferred versions: