| Message ID | 20230923204507.882395-2-raj.khem@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | [1/2] glib-2.0: Enable possible locales with musl for ptests | expand |
Wait, shouldn't the reason for the failures be at least mentioned, if not addressed? "Remove test because it fails" is never a valid change. Alex On Sat, 23 Sept 2023 at 22:45, Khem Raj <raj.khem@gmail.com> wrote: > > FAIL: glib/convert.test (Child process killed by signal 6) > FAIL: glib/collate.test (Child process killed by signal 6) > FAIL: glib/gdatetime.test (Child process killed by signal 6) > FAIL: glib/date.test (Child process killed by signal 6) > FAIL: glib/converter-stream.test (Child process killed by signal 6) > FAIL: glib/option-context.test (Child process killed by signal 6) > > Signed-off-by: Khem Raj <raj.khem@gmail.com> > --- > meta/recipes-core/glib-2.0/glib.inc | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/meta/recipes-core/glib-2.0/glib.inc b/meta/recipes-core/glib-2.0/glib.inc > index 5183f37a6ef..c508990ee8c 100644 > --- a/meta/recipes-core/glib-2.0/glib.inc > +++ b/meta/recipes-core/glib-2.0/glib.inc > @@ -134,7 +134,12 @@ do_install:append:class-target () { > # https://gitlab.gnome.org/GNOME/glib/-/issues/2810 > rm -f ${D}${datadir}/installed-tests/glib/thread-pool-slow.test > } > - > +do_install:append:class-target:libc-musl () { > + # Remove failing tests on musl libc systems > + for t in convert.test collate.test gdatetime.test date.test converter-stream.test option-context.test; do > + rm -rf ${D}${datadir}/installed-tests/glib/$t > + done > +} > # As we do not build python3 for windows, makes no sense to ship the script that's using it > do_install:append:mingw32() { > rm -f ${D}${bindir}/gtester-report > -- > 2.42.0 > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#188154): https://lists.openembedded.org/g/openembedded-core/message/188154 > Mute This Topic: https://lists.openembedded.org/mt/101546413/1686489 > Group Owner: openembedded-core+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [alex.kanavin@gmail.com] > -=-=-=-=-=-=-=-=-=-=-=- >
On Mon, Sep 25, 2023 at 12:42 AM Alexander Kanavin <alex.kanavin@gmail.com> wrote: > > Wait, shouldn't the reason for the failures be at least mentioned, if > not addressed? "Remove test because it fails" is never a valid change. > They are not triaged so no root cause reason is mentioned. The failures are listed in commit with some details that ptest shows. > Alex > > > On Sat, 23 Sept 2023 at 22:45, Khem Raj <raj.khem@gmail.com> wrote: > > > > FAIL: glib/convert.test (Child process killed by signal 6) > > FAIL: glib/collate.test (Child process killed by signal 6) > > FAIL: glib/gdatetime.test (Child process killed by signal 6) > > FAIL: glib/date.test (Child process killed by signal 6) > > FAIL: glib/converter-stream.test (Child process killed by signal 6) > > FAIL: glib/option-context.test (Child process killed by signal 6) > > > > Signed-off-by: Khem Raj <raj.khem@gmail.com> > > --- > > meta/recipes-core/glib-2.0/glib.inc | 7 ++++++- > > 1 file changed, 6 insertions(+), 1 deletion(-) > > > > diff --git a/meta/recipes-core/glib-2.0/glib.inc b/meta/recipes-core/glib-2.0/glib.inc > > index 5183f37a6ef..c508990ee8c 100644 > > --- a/meta/recipes-core/glib-2.0/glib.inc > > +++ b/meta/recipes-core/glib-2.0/glib.inc > > @@ -134,7 +134,12 @@ do_install:append:class-target () { > > # https://gitlab.gnome.org/GNOME/glib/-/issues/2810 > > rm -f ${D}${datadir}/installed-tests/glib/thread-pool-slow.test > > } > > - > > +do_install:append:class-target:libc-musl () { > > + # Remove failing tests on musl libc systems > > + for t in convert.test collate.test gdatetime.test date.test converter-stream.test option-context.test; do > > + rm -rf ${D}${datadir}/installed-tests/glib/$t > > + done > > +} > > # As we do not build python3 for windows, makes no sense to ship the script that's using it > > do_install:append:mingw32() { > > rm -f ${D}${bindir}/gtester-report > > -- > > 2.42.0 > > > > > > -=-=-=-=-=-=-=-=-=-=-=- > > Links: You receive all messages sent to this group. > > View/Reply Online (#188154): https://lists.openembedded.org/g/openembedded-core/message/188154 > > Mute This Topic: https://lists.openembedded.org/mt/101546413/1686489 > > Group Owner: openembedded-core+owner@lists.openembedded.org > > Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [alex.kanavin@gmail.com] > > -=-=-=-=-=-=-=-=-=-=-=- > >
On Mon, 25 Sept 2023 at 19:21, Khem Raj <raj.khem@gmail.com> wrote: > They are not triaged so no root cause reason is mentioned. > The failures are listed in commit with some details that ptest shows. I still don't understand why the failing tests should be removed. Just let them fail, or exclude glib ptest from musl CI altogether. No one wants a fake green status. Alex
On Mon, Sep 25, 2023 at 10:53 AM Alexander Kanavin <alex.kanavin@gmail.com> wrote: > > On Mon, 25 Sept 2023 at 19:21, Khem Raj <raj.khem@gmail.com> wrote: > > They are not triaged so no root cause reason is mentioned. > > The failures are listed in commit with some details that ptest shows. > > I still don't understand why the failing tests should be removed. Just > let them fail, or exclude glib ptest from musl CI altogether. No one > wants a fake green status. This helps in creating a baseline so it does not regress further, while the information is still maintained in the recipe if it needs to be triaged further. > > Alex
On Mon, 25 Sept 2023 at 20:01, Khem Raj <raj.khem@gmail.com> wrote: > > On Mon, 25 Sept 2023 at 19:21, Khem Raj <raj.khem@gmail.com> wrote: > > > They are not triaged so no root cause reason is mentioned. > > > The failures are listed in commit with some details that ptest shows. > > > > I still don't understand why the failing tests should be removed. Just > > let them fail, or exclude glib ptest from musl CI altogether. No one > > wants a fake green status. > > This helps in creating a baseline so it does not regress further, > while the information > is still maintained in the recipe if it needs to be triaged further. This I can agree with. But can you write a better comment in the recipe itself? Alex
diff --git a/meta/recipes-core/glib-2.0/glib.inc b/meta/recipes-core/glib-2.0/glib.inc index 5183f37a6ef..c508990ee8c 100644 --- a/meta/recipes-core/glib-2.0/glib.inc +++ b/meta/recipes-core/glib-2.0/glib.inc @@ -134,7 +134,12 @@ do_install:append:class-target () { # https://gitlab.gnome.org/GNOME/glib/-/issues/2810 rm -f ${D}${datadir}/installed-tests/glib/thread-pool-slow.test } - +do_install:append:class-target:libc-musl () { + # Remove failing tests on musl libc systems + for t in convert.test collate.test gdatetime.test date.test converter-stream.test option-context.test; do + rm -rf ${D}${datadir}/installed-tests/glib/$t + done +} # As we do not build python3 for windows, makes no sense to ship the script that's using it do_install:append:mingw32() { rm -f ${D}${bindir}/gtester-report
FAIL: glib/convert.test (Child process killed by signal 6) FAIL: glib/collate.test (Child process killed by signal 6) FAIL: glib/gdatetime.test (Child process killed by signal 6) FAIL: glib/date.test (Child process killed by signal 6) FAIL: glib/converter-stream.test (Child process killed by signal 6) FAIL: glib/option-context.test (Child process killed by signal 6) Signed-off-by: Khem Raj <raj.khem@gmail.com> --- meta/recipes-core/glib-2.0/glib.inc | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)