diff mbox series

removing PN from BB_HASH_CODEPARSER_VALS

Message ID 20230914105052.112829-1-m.schoepfer@rethinkrobotics.com
State New
Headers show
Series removing PN from BB_HASH_CODEPARSER_VALS | expand

Commit Message

Matthias Schoepfer Sept. 14, 2023, 10:50 a.m. UTC
When using icecc.bbclass for builds, the build will break
due to the fact, that during parsing stage, PN is set to
no-pn, which leads to the issue that the ICECC_RECIPE_DISABLE
recipes (appended or within icecc.bbclass) are no longer
parsed / ignored correctly. This will lead to an error.

Unfortunately, it is not sufficient to set the
BB_HASH_CODEPARSER_VALS in the local.conf.

Fixes [YOCTO #15213]

Signed-off-by: Matthias Schoepfer <m.schoepfer@rethinkrobotics.com>
---
 meta/conf/bitbake.conf | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Richard Purdie Sept. 14, 2023, 12:25 p.m. UTC | #1
On Thu, 2023-09-14 at 12:50 +0200, Matthias Schoepfer via
lists.openembedded.org wrote:
> When using icecc.bbclass for builds, the build will break
> due to the fact, that during parsing stage, PN is set to
> no-pn, which leads to the issue that the ICECC_RECIPE_DISABLE
> recipes (appended or within icecc.bbclass) are no longer
> parsed / ignored correctly. This will lead to an error.
> 
> Unfortunately, it is not sufficient to set the
> BB_HASH_CODEPARSER_VALS in the local.conf.
> 
> Fixes [YOCTO #15213]
> 
> Signed-off-by: Matthias Schoepfer <m.schoepfer@rethinkrobotics.com>
> ---
>  meta/conf/bitbake.conf | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
> index 8b26461874..a9d851c87c 100644
> --- a/meta/conf/bitbake.conf
> +++ b/meta/conf/bitbake.conf
> @@ -961,7 +961,7 @@ BB_SIGNATURE_EXCLUDE_FLAGS ?= "doc deps depends \
>      sstate-lockfile-shared prefuncs postfuncs export_func deptask rdeptask \
>      recrdeptask nodeprrecs stamp-extra-info sstate-outputdirs filename lineno \
>      progress mcdepends number_threads"
> -BB_HASH_CODEPARSER_VALS = "LOGFIFO=/ T=/ WORKDIR=/ DATE=1234 TIME=1234 PV=0.0-1 PN=no-pn METADATA_REVISION=1234 SRC_URI="
> +BB_HASH_CODEPARSER_VALS = "LOGFIFO=/ T=/ WORKDIR=/ DATE=1234 TIME=1234 PV=0.0-1 METADATA_REVISION=1234 SRC_URI="
>  
>  MLPREFIX ??= ""
>  MULTILIB_VARIANTS ??= ""

I'd like to understand a little bit more detail about what/where/why
this is breaking.

What this implies is that there is code changing it's dependencies
depending on the value of PN which is a little bit worrying and
potentially suggests a deeper issue.

Cheers,

Richard
diff mbox series

Patch

diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
index 8b26461874..a9d851c87c 100644
--- a/meta/conf/bitbake.conf
+++ b/meta/conf/bitbake.conf
@@ -961,7 +961,7 @@  BB_SIGNATURE_EXCLUDE_FLAGS ?= "doc deps depends \
     sstate-lockfile-shared prefuncs postfuncs export_func deptask rdeptask \
     recrdeptask nodeprrecs stamp-extra-info sstate-outputdirs filename lineno \
     progress mcdepends number_threads"
-BB_HASH_CODEPARSER_VALS = "LOGFIFO=/ T=/ WORKDIR=/ DATE=1234 TIME=1234 PV=0.0-1 PN=no-pn METADATA_REVISION=1234 SRC_URI="
+BB_HASH_CODEPARSER_VALS = "LOGFIFO=/ T=/ WORKDIR=/ DATE=1234 TIME=1234 PV=0.0-1 METADATA_REVISION=1234 SRC_URI="
 
 MLPREFIX ??= ""
 MULTILIB_VARIANTS ??= ""