| Message ID | 20230712122558.711029-1-p.lobacz@welotec.com |
|---|---|
| State | New |
| Headers | show |
| Series | [v4,1/5] bitbake.conf: add acl and xattr distro native features support | expand |
On Wed, 2023-07-12 at 14:25 +0200, Piotr Łobacz wrote: > Include support for ACLs and extended file attributes for native > builds, depending on which distro target features has been turned > on. > > Signed-off-by: Piotr Łobacz <p.lobacz@welotec.com> > --- > meta/conf/bitbake.conf | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf > index 9625a6fef4..20684a5126 100644 > --- a/meta/conf/bitbake.conf > +++ b/meta/conf/bitbake.conf > @@ -904,12 +904,12 @@ IMAGE_FEATURES += "${EXTRA_IMAGE_FEATURES}" > > # Native distro features (will always be used for -native, even if they > # are not enabled for target) > -DISTRO_FEATURES_NATIVE ?= "x11 ipv6 xattr" > +DISTRO_FEATURES_NATIVE ?= "x11 ipv6" > DISTRO_FEATURES_NATIVESDK ?= "x11" > > # Normally target distro features will not be applied to native builds: > # Native distro features on this list will use the target feature value > -DISTRO_FEATURES_FILTER_NATIVE ?= "api-documentation debuginfod opengl wayland" > +DISTRO_FEATURES_FILTER_NATIVE ?= "acl api-documentation debuginfod opengl wayland xattr" > DISTRO_FEATURES_FILTER_NATIVESDK ?= "api-documentation debuginfod opengl wayland" > > DISTRO_FEATURES_BACKFILL = "pulseaudio sysvinit gobject-introspection-data ldconfig" Just to be clear, I know what Alex said but after further thought, acl needs to move into DISTRO_FEATURES_NATIVE in my opinion (and Ross' too). I suspect Alex will agree with that too after thinking about the arguments I put forward about simplifying sstate reuse. Cheers, Richard
On Wed, 12 Jul 2023 at 19:04, Richard Purdie <richard.purdie@linuxfoundation.org> wrote: > Just to be clear, I know what Alex said but after further thought, acl > needs to move into DISTRO_FEATURES_NATIVE in my opinion (and Ross' > too). > > I suspect Alex will agree with that too after thinking about the > arguments I put forward about simplifying sstate reuse. My comment was strictly about using the best syntactic sugar, and not about the merits of conditional (or not) enabling of these features. I'm fine if they're always enabled. Alex
OK, I have set in v5 patches set, these acl and xattr attributes by default in DISTRO_FEATURES_NATIVE, without any checks, if it exists in DISTRO_FEATURES. Is that ok for all of you? BR Piotr
On Wed, 2023-07-12 at 19:08 +0000, Piotr Łobacz wrote: > OK, I have set in v5 patches set, these acl and xattr attributes by > default in DISTRO_FEATURES_NATIVE, without any checks, if it exists > in DISTRO_FEATURES. Is that ok for all of you? No, don't check DISTRO_FEATURES. Just add acl unconditionally. Cheers, Richard
Richard, but that is exactly, what I have written… wirhout anu checks. Cheers Piotr
Sorry for typo. It should be any, not anu. I’m typing from mobile… Wysyłane z aplikacji Outlook dla systemu iOS<https://aka.ms/o0ukef>
On Wed, 2023-07-12 at 20:48 +0000, Piotr Łobacz wrote: > Richard, but that is exactly, what I have written… wirhout any > checks. No, I mean that the right patch should be: -DISTRO_FEATURES_NATIVE ?= "x11 ipv6 xattr" +DISTRO_FEATURES_NATIVE ?= "x11 ipv6 xattr acl" i.e. add acl to DISTRO_FEATURES_NATIVE and leave xattr there. Cheers, Richard
But I have sent already v5 with this change… BR Piotr Wysyłane z aplikacji Outlook dla systemu iOS<https://aka.ms/o0ukef>
diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf index 9625a6fef4..20684a5126 100644 --- a/meta/conf/bitbake.conf +++ b/meta/conf/bitbake.conf @@ -904,12 +904,12 @@ IMAGE_FEATURES += "${EXTRA_IMAGE_FEATURES}" # Native distro features (will always be used for -native, even if they # are not enabled for target) -DISTRO_FEATURES_NATIVE ?= "x11 ipv6 xattr" +DISTRO_FEATURES_NATIVE ?= "x11 ipv6" DISTRO_FEATURES_NATIVESDK ?= "x11" # Normally target distro features will not be applied to native builds: # Native distro features on this list will use the target feature value -DISTRO_FEATURES_FILTER_NATIVE ?= "api-documentation debuginfod opengl wayland" +DISTRO_FEATURES_FILTER_NATIVE ?= "acl api-documentation debuginfod opengl wayland xattr" DISTRO_FEATURES_FILTER_NATIVESDK ?= "api-documentation debuginfod opengl wayland" DISTRO_FEATURES_BACKFILL = "pulseaudio sysvinit gobject-introspection-data ldconfig"
Include support for ACLs and extended file attributes for native builds, depending on which distro target features has been turned on. Signed-off-by: Piotr Łobacz <p.lobacz@welotec.com> --- meta/conf/bitbake.conf | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)