diff mbox series

perl-version: remove PERL* assignments

Message ID 20230428160757.192046-1-patrick@stwcx.xyz
State Accepted, archived
Commit 9351b6e7fab5669340bb062b9c84fb4faa3dce0b
Headers show
Series perl-version: remove PERL* assignments | expand

Commit Message

Patrick Williams April 28, 2023, 4:07 p.m. UTC
The perl-version.bbclass executes functions which can depend on
variables potentially populated by native, such as `libdir`.  The
sanity `native-last` suggests that recipes should `inherit native`
last, but when that is done the variables like PERLVERSION end up
as `None`, since `${STAGING_LIBDIR}` needs `${libdir}` which is not
yet populated (by native).

All recipes in poky and widely used meta-layers have already been
updated to use the functions directly instead of relying on these
problematic variables.  Delete the variables so that future recipes
do not make the mistake of using them.

Related: openbmc/openbmc#3770
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
---
 meta/classes-recipe/perl-version.bbclass | 6 ------
 1 file changed, 6 deletions(-)
diff mbox series

Patch

diff --git a/meta/classes-recipe/perl-version.bbclass b/meta/classes-recipe/perl-version.bbclass
index 269ac9eb31..74e33175d9 100644
--- a/meta/classes-recipe/perl-version.bbclass
+++ b/meta/classes-recipe/perl-version.bbclass
@@ -26,9 +26,6 @@  def get_perl_version(d):
             return m.group(1)
     return None
 
-PERLVERSION := "${@get_perl_version(d)}"
-PERLVERSION[vardepvalue] = ""
-
 
 # Determine the staged arch of perl from the perl configuration file
 # Assign vardepvalue, because otherwise signature is changed before and after
@@ -49,9 +46,6 @@  def get_perl_arch(d):
             return m.group(1)
     return None
 
-PERLARCH := "${@get_perl_arch(d)}"
-PERLARCH[vardepvalue] = ""
-
 # Determine the staged arch of perl-native from the perl configuration file
 # Assign vardepvalue, because otherwise signature is changed before and after
 # perl is built (from None to real version in config.sh).