diff mbox series

mirrors.bbclass: use shallow tarball for nativesdk-binutils

Message ID 20221104142443.1728589-1-ecordonnier@snap.com
State Accepted, archived
Commit 18624a89cb09bab78f9200a7c63406c75845e3e3
Headers show
Series mirrors.bbclass: use shallow tarball for nativesdk-binutils | expand

Commit Message

Etienne Cordonnier Nov. 4, 2022, 2:24 p.m. UTC
This is useful e.g. when using meta-clang, which introduces a dependency to nativesdk-binutils when
populating the SDK, and then a full tarball of binutils is fetched additionally to a shallow tarball.

Signed-off-by: Etienne Cordonnier <ecordonnier@snap.com>
---
 meta/classes-global/mirrors.bbclass | 2 ++
 1 file changed, 2 insertions(+)

Comments

Alexandre Belloni Nov. 6, 2022, 4:01 p.m. UTC | #1
On 04/11/2022 15:24:43+0100, Etienne Cordonnier via lists.openembedded.org wrote:
> This is useful e.g. when using meta-clang, which introduces a dependency to nativesdk-binutils when
> populating the SDK, and then a full tarball of binutils is fetched additionally to a shallow tarball.
> 
> Signed-off-by: Etienne Cordonnier <ecordonnier@snap.com>

The SoB needs to match the author and sender. You are using two
different addresses here.

> ---
>  meta/classes-global/mirrors.bbclass | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/meta/classes-global/mirrors.bbclass b/meta/classes-global/mirrors.bbclass
> index 81fef7f660..8b984de3bf 100644
> --- a/meta/classes-global/mirrors.bbclass
> +++ b/meta/classes-global/mirrors.bbclass
> @@ -91,6 +91,8 @@ BB_GIT_SHALLOW:pn-binutils-cross-canadian-${TRANSLATED_TARGET_ARCH} = "1"
>  BB_GIT_SHALLOW:pn-binutils-cross-testsuite = "1"
>  BB_GIT_SHALLOW:pn-binutils-crosssdk-${SDK_SYS} = "1"
>  BB_GIT_SHALLOW:pn-binutils-native = "1"
> +BB_GIT_SHALLOW:pn-nativesdk-binutils = "1"
> +
>  BB_GIT_SHALLOW:pn-glibc = "1"
>  PREMIRRORS += "git://sourceware.org/git/glibc.git https://downloads.yoctoproject.org/mirror/sources/ \
>                git://sourceware.org/git/binutils-gdb.git https://downloads.yoctoproject.org/mirror/sources/"
> -- 
> 2.36.1.vfs.0.0
> 

> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#172714): https://lists.openembedded.org/g/openembedded-core/message/172714
> Mute This Topic: https://lists.openembedded.org/mt/94806491/3617179
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [alexandre.belloni@bootlin.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
Etienne Cordonnier Nov. 7, 2022, 9:55 a.m. UTC | #2
I've resent the patch and changed git's sendemail.envelopesender option so
that the From field matches the email used in the SOB field.

On Sun, Nov 6, 2022 at 5:02 PM Alexandre Belloni <
alexandre.belloni@bootlin.com> wrote:

> On 04/11/2022 15:24:43+0100, Etienne Cordonnier via lists.openembedded.org
> wrote:
> > This is useful e.g. when using meta-clang, which introduces a dependency
> to nativesdk-binutils when
> > populating the SDK, and then a full tarball of binutils is fetched
> additionally to a shallow tarball.
> >
> > Signed-off-by: Etienne Cordonnier <ecordonnier@snap.com>
>
> The SoB needs to match the author and sender. You are using two
> different addresses here.
>
> > ---
> >  meta/classes-global/mirrors.bbclass | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/meta/classes-global/mirrors.bbclass
> b/meta/classes-global/mirrors.bbclass
> > index 81fef7f660..8b984de3bf 100644
> > --- a/meta/classes-global/mirrors.bbclass
> > +++ b/meta/classes-global/mirrors.bbclass
> > @@ -91,6 +91,8 @@
> BB_GIT_SHALLOW:pn-binutils-cross-canadian-${TRANSLATED_TARGET_ARCH} = "1"
> >  BB_GIT_SHALLOW:pn-binutils-cross-testsuite = "1"
> >  BB_GIT_SHALLOW:pn-binutils-crosssdk-${SDK_SYS} = "1"
> >  BB_GIT_SHALLOW:pn-binutils-native = "1"
> > +BB_GIT_SHALLOW:pn-nativesdk-binutils = "1"
> > +
> >  BB_GIT_SHALLOW:pn-glibc = "1"
> >  PREMIRRORS += "git://sourceware.org/git/glibc.git
> https://urldefense.proofpoint.com/v2/url?u=https-3A__downloads.yoctoproject.org_mirror_sources_&d=DwIBAg&c=ncDTmphkJTvjIDPh0hpF_4vCHvabgGkICC2epckfdiw&r=AhkbNonVuMIGRfPx_Qj9TsRih1DULJTKUkSGa66m67E&m=ItIZIiBFvPUc7ha-blv_xFb0FMnb2T_GL7CNoIiQdZKZOHxwxi75uwo6Hol3J3TA&s=hk4_w8STTvGIN0VNAn2uzyYG_oOrycryBPA5-pYHAPg&e=
> \
> >                git://sourceware.org/git/binutils-gdb.git
> https://urldefense.proofpoint.com/v2/url?u=https-3A__downloads.yoctoproject.org_mirror_sources_&d=DwIBAg&c=ncDTmphkJTvjIDPh0hpF_4vCHvabgGkICC2epckfdiw&r=AhkbNonVuMIGRfPx_Qj9TsRih1DULJTKUkSGa66m67E&m=ItIZIiBFvPUc7ha-blv_xFb0FMnb2T_GL7CNoIiQdZKZOHxwxi75uwo6Hol3J3TA&s=hk4_w8STTvGIN0VNAn2uzyYG_oOrycryBPA5-pYHAPg&e=
> "
> > --
> > 2.36.1.vfs.0.0
> >
>
> >
> > -=-=-=-=-=-=-=-=-=-=-=-
> > Links: You receive all messages sent to this group.
> > View/Reply Online (#172714):
> https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.openembedded.org_g_openembedded-2Dcore_message_172714&d=DwIBAg&c=ncDTmphkJTvjIDPh0hpF_4vCHvabgGkICC2epckfdiw&r=AhkbNonVuMIGRfPx_Qj9TsRih1DULJTKUkSGa66m67E&m=ItIZIiBFvPUc7ha-blv_xFb0FMnb2T_GL7CNoIiQdZKZOHxwxi75uwo6Hol3J3TA&s=C08MKSdkpczwMDUBLU0lDwc6-divmgE89AHm-eHFcy0&e=
> > Mute This Topic:
> https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.openembedded.org_mt_94806491_3617179&d=DwIBAg&c=ncDTmphkJTvjIDPh0hpF_4vCHvabgGkICC2epckfdiw&r=AhkbNonVuMIGRfPx_Qj9TsRih1DULJTKUkSGa66m67E&m=ItIZIiBFvPUc7ha-blv_xFb0FMnb2T_GL7CNoIiQdZKZOHxwxi75uwo6Hol3J3TA&s=aWDi_0FtVYrz0eG_bPJO0tqup8a5jLutsSoTa3Pynwk&e=
> > Group Owner: openembedded-core+owner@lists.openembedded.org
> > Unsubscribe:
> https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.openembedded.org_g_openembedded-2Dcore_unsub&d=DwIBAg&c=ncDTmphkJTvjIDPh0hpF_4vCHvabgGkICC2epckfdiw&r=AhkbNonVuMIGRfPx_Qj9TsRih1DULJTKUkSGa66m67E&m=ItIZIiBFvPUc7ha-blv_xFb0FMnb2T_GL7CNoIiQdZKZOHxwxi75uwo6Hol3J3TA&s=FpYs9M88TVaCf1Ibbm3mKpHzyHV_ihvwGydOexSfF2s&e=
> [alexandre.belloni@bootlin.com]
> > -=-=-=-=-=-=-=-=-=-=-=-
> >
>
>
> --
> Alexandre Belloni, co-owner and COO, Bootlin
> Embedded Linux and Kernel engineering
>
> https://urldefense.proofpoint.com/v2/url?u=https-3A__bootlin.com&d=DwIBAg&c=ncDTmphkJTvjIDPh0hpF_4vCHvabgGkICC2epckfdiw&r=AhkbNonVuMIGRfPx_Qj9TsRih1DULJTKUkSGa66m67E&m=ItIZIiBFvPUc7ha-blv_xFb0FMnb2T_GL7CNoIiQdZKZOHxwxi75uwo6Hol3J3TA&s=Lu5F2iWAYyxz6ynKWLlP56TD2uUQTBZBQSCOpzaMaRI&e=
>
diff mbox series

Patch

diff --git a/meta/classes-global/mirrors.bbclass b/meta/classes-global/mirrors.bbclass
index 81fef7f660..8b984de3bf 100644
--- a/meta/classes-global/mirrors.bbclass
+++ b/meta/classes-global/mirrors.bbclass
@@ -91,6 +91,8 @@  BB_GIT_SHALLOW:pn-binutils-cross-canadian-${TRANSLATED_TARGET_ARCH} = "1"
 BB_GIT_SHALLOW:pn-binutils-cross-testsuite = "1"
 BB_GIT_SHALLOW:pn-binutils-crosssdk-${SDK_SYS} = "1"
 BB_GIT_SHALLOW:pn-binutils-native = "1"
+BB_GIT_SHALLOW:pn-nativesdk-binutils = "1"
+
 BB_GIT_SHALLOW:pn-glibc = "1"
 PREMIRRORS += "git://sourceware.org/git/glibc.git https://downloads.yoctoproject.org/mirror/sources/ \
               git://sourceware.org/git/binutils-gdb.git https://downloads.yoctoproject.org/mirror/sources/"