diff mbox series

rust: submit a rewritten version of crossbeam_atomic.patch upstream

Message ID 20221101201044.1034019-1-alex@linutronix.de
State Accepted, archived
Commit 4bbfd7427092063dd612d2ca9e466cb819f5a3e3
Headers show
Series rust: submit a rewritten version of crossbeam_atomic.patch upstream | expand

Commit Message

Alexander Kanavin Nov. 1, 2022, 8:10 p.m. UTC
Signed-off-by: Alexander Kanavin <alex@linutronix.de>
---
 meta/recipes-devtools/rust/rust/crossbeam_atomic.patch | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Richard Purdie Nov. 2, 2022, 9:29 a.m. UTC | #1
On Tue, 2022-11-01 at 21:10 +0100, Alexander Kanavin wrote:
> Signed-off-by: Alexander Kanavin <alex@linutronix.de>
> ---
>  meta/recipes-devtools/rust/rust/crossbeam_atomic.patch | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/recipes-devtools/rust/rust/crossbeam_atomic.patch b/meta/recipes-devtools/rust/rust/crossbeam_atomic.patch
> index 2f3f985243..13719ee9dc 100644
> --- a/meta/recipes-devtools/rust/rust/crossbeam_atomic.patch
> +++ b/meta/recipes-devtools/rust/rust/crossbeam_atomic.patch
> @@ -14,7 +14,7 @@ Someone with more rust knowledge could split up the triplets in no_atmoics.rs
>  and compare against the architecture/processor, or replace -unknown with a glob
>  to create a patch that upstream might accept.
>  
> -Upstream-Status: Inappropriate [OE Specific tweak  but could be rewritten]
> +Upstream-Status: Submitted [https://github.com/crossbeam-rs/crossbeam/pull/922]
>  Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
>  
>  Index: rustc-1.64.0-src/vendor/crossbeam-utils/build.rs

Should we not update the patch here to match the one we're asking be
merged?

Thanks for sorting that btw, I kept meaning to but hadn't quite had
enough time to learn enough rust! :)

Cheers,

Richard
Alexander Kanavin Nov. 2, 2022, 9:44 a.m. UTC | #2
On Wed, 2 Nov 2022 at 10:29, Richard Purdie
<richard.purdie@linuxfoundation.org> wrote:

> Should we not update the patch here to match the one we're asking be
> merged?

I would rather see it through actual merge (where further changes may
happen) and update to the official backport. Updating this particular
patch is a *royal* pita.

> Thanks for sorting that btw, I kept meaning to but hadn't quite had
> enough time to learn enough rust! :)

I wouldn't say I 'learned rust' either; I merely fumbled through
compiler errors and stackoverflow search results until I arrived at
something that builds and behaves as expected. :-)
Going through https://doc.rust-lang.org/book/ is a pressing matter for
all of us I suppose.

Alex
diff mbox series

Patch

diff --git a/meta/recipes-devtools/rust/rust/crossbeam_atomic.patch b/meta/recipes-devtools/rust/rust/crossbeam_atomic.patch
index 2f3f985243..13719ee9dc 100644
--- a/meta/recipes-devtools/rust/rust/crossbeam_atomic.patch
+++ b/meta/recipes-devtools/rust/rust/crossbeam_atomic.patch
@@ -14,7 +14,7 @@  Someone with more rust knowledge could split up the triplets in no_atmoics.rs
 and compare against the architecture/processor, or replace -unknown with a glob
 to create a patch that upstream might accept.
 
-Upstream-Status: Inappropriate [OE Specific tweak  but could be rewritten]
+Upstream-Status: Submitted [https://github.com/crossbeam-rs/crossbeam/pull/922]
 Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
 
 Index: rustc-1.64.0-src/vendor/crossbeam-utils/build.rs