diff mbox series

[V2] bluez5: change configuration directory mode

Message ID 20221005135921.4167614-1-liu.ming50@gmail.com
State New
Headers show
Series [V2] bluez5: change configuration directory mode | expand

Commit Message

Ming Liu Oct. 5, 2022, 1:59 p.m. UTC
From: Ming Liu <liu.ming50@gmail.com>

Change configuration directory mode from 0755 to 0555, this fixes a
following warning when bluetoothd starts:
| ConfigurationDirectory 'bluetooth' already exists but the mode is different.
| (File system: 755 ConfigurationDirectoryMode: 555)

Signed-off-by: Ming Liu <liu.ming50@gmail.com>
---
 meta/recipes-connectivity/bluez5/bluez5.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Peter Kjellerstedt Oct. 5, 2022, 3:09 p.m. UTC | #1
> -----Original Message-----
> From: openembedded-core@lists.openembedded.org <openembedded-core@lists.openembedded.org> On Behalf Of Ming Liu
> Sent: den 5 oktober 2022 15:59
> To: openembedded-core@lists.openembedded.org
> Cc: Ming Liu <liu.ming50@gmail.com>
> Subject: [OE-core] [PATCH V2] bluez5: change configuration directory mode
> 
> From: Ming Liu <liu.ming50@gmail.com>
> 
> Change configuration directory mode from 0755 to 0555, this fixes a
> following warning when bluetoothd starts:
> | ConfigurationDirectory 'bluetooth' already exists but the mode is different.
> | (File system: 755 ConfigurationDirectoryMode: 555)
> 
> Signed-off-by: Ming Liu <liu.ming50@gmail.com>
> ---
>  meta/recipes-connectivity/bluez5/bluez5.inc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/recipes-connectivity/bluez5/bluez5.inc b/meta/recipes-connectivity/bluez5/bluez5.inc
> index 79d4645ca8..48b8bcbe75 100644
> --- a/meta/recipes-connectivity/bluez5/bluez5.inc
> +++ b/meta/recipes-connectivity/bluez5/bluez5.inc
> @@ -82,7 +82,7 @@ do_install:append() {
>  	install -d ${D}${INIT_D_DIR}
>  	install -m 0755 ${WORKDIR}/init ${D}${INIT_D_DIR}/bluetooth
> 
> -	install -d ${D}${sysconfdir}/bluetooth/
> +	install -m 0755 -d ${D}${sysconfdir}/bluetooth/

The default mode used by `install` if not specified is 0755. 
The above change should not make any difference...

>  	if [ -f ${S}/profiles/network/network.conf ]; then
>  		install -m 0644 ${S}/profiles/network/network.conf ${D}/${sysconfdir}/bluetooth/
>  	fi
> --
> 2.25.1

//Peter
Ming Liu Oct. 5, 2022, 3:24 p.m. UTC | #2
Hi, Peter:

You are absolutely right, I also noticed that, it’s a typo, it should be
0555, will send a V3 soon.

//Ming Liu

> -----Original Message-----
> > From: openembedded-core@lists.openembedded.org <
> openembedded-core@lists.openembedded.org> On Behalf Of Ming Liu
> > Sent: den 5 oktober 2022 15:59
> > To: openembedded-core@lists.openembedded.org
> > Cc: Ming Liu <liu.ming50@gmail.com>
> > Subject: [OE-core] [PATCH V2] bluez5: change configuration directory mode
> >
> > From: Ming Liu <liu.ming50@gmail.com>
> >
> > Change configuration directory mode from 0755 to 0555, this fixes a
> > following warning when bluetoothd starts:
> > | ConfigurationDirectory 'bluetooth' already exists but the mode is
> different.
> > | (File system: 755 ConfigurationDirectoryMode: 555)
> >
> > Signed-off-by: Ming Liu <liu.ming50@gmail.com>
> > ---
> >  meta/recipes-connectivity/bluez5/bluez5.inc | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/meta/recipes-connectivity/bluez5/bluez5.inc
> b/meta/recipes-connectivity/bluez5/bluez5.inc
> > index 79d4645ca8..48b8bcbe75 100644
> > --- a/meta/recipes-connectivity/bluez5/bluez5.inc
> > +++ b/meta/recipes-connectivity/bluez5/bluez5.inc
> > @@ -82,7 +82,7 @@ do_install:append() {
> >       install -d ${D}${INIT_D_DIR}
> >       install -m 0755 ${WORKDIR}/init ${D}${INIT_D_DIR}/bluetooth
> >
> > -     install -d ${D}${sysconfdir}/bluetooth/
> > +     install -m 0755 -d ${D}${sysconfdir}/bluetooth/
>
> The default mode used by `install` if not specified is 0755.
> The above change should not make any difference...
>
> >       if [ -f ${S}/profiles/network/network.conf ]; then
> >               install -m 0644 ${S}/profiles/network/network.conf
> ${D}/${sysconfdir}/bluetooth/
> >       fi
> > --
> > 2.25.1
>
> //Peter
>
>
diff mbox series

Patch

diff --git a/meta/recipes-connectivity/bluez5/bluez5.inc b/meta/recipes-connectivity/bluez5/bluez5.inc
index 79d4645ca8..48b8bcbe75 100644
--- a/meta/recipes-connectivity/bluez5/bluez5.inc
+++ b/meta/recipes-connectivity/bluez5/bluez5.inc
@@ -82,7 +82,7 @@  do_install:append() {
 	install -d ${D}${INIT_D_DIR}
 	install -m 0755 ${WORKDIR}/init ${D}${INIT_D_DIR}/bluetooth
 
-	install -d ${D}${sysconfdir}/bluetooth/
+	install -m 0755 -d ${D}${sysconfdir}/bluetooth/
 	if [ -f ${S}/profiles/network/network.conf ]; then
 		install -m 0644 ${S}/profiles/network/network.conf ${D}/${sysconfdir}/bluetooth/
 	fi