diff mbox series

kernel: Use consistent make flags for menuconfig

Message ID 20220902163043.323903-1-richard.purdie@linuxfoundation.org
State Accepted, archived
Commit 8c616bc090d1834a21073a33209323220c05d2e5
Headers show
Series kernel: Use consistent make flags for menuconfig | expand

Commit Message

Richard Purdie Sept. 2, 2022, 4:30 p.m. UTC
We're currently only passing in a subset of the kernel make flags to
menuconfig. Fix this to be consistent with all the other kernel
operations since these are becomming increasingly reliant on host
compilers and flags and target toolchains as well.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---
 meta/classes-recipe/kernel.bbclass | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Bruce Ashfield Sept. 2, 2022, 11:29 p.m. UTC | #1
On Fri, Sep 2, 2022 at 1:30 PM Richard Purdie
<richard.purdie@linuxfoundation.org> wrote:
>
> We're currently only passing in a subset of the kernel make flags to
> menuconfig. Fix this to be consistent with all the other kernel
> operations since these are becomming increasingly reliant on host
> compilers and flags and target toolchains as well.

Looks good to me!

Bruce

>
> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> ---
>  meta/classes-recipe/kernel.bbclass | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/meta/classes-recipe/kernel.bbclass b/meta/classes-recipe/kernel.bbclass
> index e752874177e..fca673dd48d 100644
> --- a/meta/classes-recipe/kernel.bbclass
> +++ b/meta/classes-recipe/kernel.bbclass
> @@ -650,7 +650,8 @@ addtask savedefconfig after do_configure
>
>  inherit cml1
>
> -KCONFIG_CONFIG_COMMAND:append = " PAHOLE=false LD='${KERNEL_LD}' HOSTLDFLAGS='${BUILD_LDFLAGS}'"
> +# Need LD, HOSTLDFLAGS and more for config operations
> +KCONFIG_CONFIG_COMMAND:append = " ${EXTRA_OEMAKE}"
>
>  EXPORT_FUNCTIONS do_compile do_transform_kernel do_transform_bundled_initramfs do_install do_configure
>
> --
> 2.34.1
>
diff mbox series

Patch

diff --git a/meta/classes-recipe/kernel.bbclass b/meta/classes-recipe/kernel.bbclass
index e752874177e..fca673dd48d 100644
--- a/meta/classes-recipe/kernel.bbclass
+++ b/meta/classes-recipe/kernel.bbclass
@@ -650,7 +650,8 @@  addtask savedefconfig after do_configure
 
 inherit cml1
 
-KCONFIG_CONFIG_COMMAND:append = " PAHOLE=false LD='${KERNEL_LD}' HOSTLDFLAGS='${BUILD_LDFLAGS}'"
+# Need LD, HOSTLDFLAGS and more for config operations
+KCONFIG_CONFIG_COMMAND:append = " ${EXTRA_OEMAKE}"
 
 EXPORT_FUNCTIONS do_compile do_transform_kernel do_transform_bundled_initramfs do_install do_configure