diff mbox series

qemux86-64: Allow higher tunes

Message ID 20220811154005.4084669-1-trini@konsulko.com
State Accepted, archived
Commit a7411f5964f2e8384768b0a5e67817b3adc0ae8c
Headers show
Series qemux86-64: Allow higher tunes | expand

Commit Message

Tom Rini Aug. 11, 2022, 3:40 p.m. UTC
Back in 0be64e54a0e6 ("qemux86: Allow higher tunes") we moved the
qemux86 machine to using the core-i7 tune file, for maximum flexibility
and to allow for enabling advanced processor features if desired or
required by various packagess, without changing the default tune. Do the
same now for qemux86-64.

Cc: Joshua Watt <JPEWhacker@gmail.com>
Cc: Richard Purdie <richard.purdie@linuxfoundation.org>
Signed-off-by: Tom Rini <trini@konsulko.com>
---
 meta/conf/machine/qemux86-64.conf | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Alexander Kanavin Aug. 11, 2022, 3:51 p.m. UTC | #1
This is less useful than it may seem, and merely moves the supported
CPU from circa-2006 core 2 to circa-2008 core i7. You won't get AVX or
anything newer, which requires adding these instructions to qemu
usermode (a project I'd like to do if I had the time).

Alex

On Thu, 11 Aug 2022 at 17:40, Tom Rini <trini@konsulko.com> wrote:
>
> Back in 0be64e54a0e6 ("qemux86: Allow higher tunes") we moved the
> qemux86 machine to using the core-i7 tune file, for maximum flexibility
> and to allow for enabling advanced processor features if desired or
> required by various packagess, without changing the default tune. Do the
> same now for qemux86-64.
>
> Cc: Joshua Watt <JPEWhacker@gmail.com>
> Cc: Richard Purdie <richard.purdie@linuxfoundation.org>
> Signed-off-by: Tom Rini <trini@konsulko.com>
> ---
>  meta/conf/machine/qemux86-64.conf | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/conf/machine/qemux86-64.conf b/meta/conf/machine/qemux86-64.conf
> index 901353499c81..864086791179 100644
> --- a/meta/conf/machine/qemux86-64.conf
> +++ b/meta/conf/machine/qemux86-64.conf
> @@ -10,7 +10,7 @@ PREFERRED_PROVIDER_virtual/libgles3 ?= "mesa"
>
>  require conf/machine/include/qemu.inc
>  DEFAULTTUNE ?= "core2-64"
> -require conf/machine/include/x86/tune-core2.inc
> +require conf/machine/include/x86/tune-corei7.inc
>  require conf/machine/include/x86/qemuboot-x86.inc
>
>  UBOOT_MACHINE ?= "qemu-x86_64_defconfig"
> --
> 2.25.1
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#169248): https://lists.openembedded.org/g/openembedded-core/message/169248
> Mute This Topic: https://lists.openembedded.org/mt/92961093/1686489
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [alex.kanavin@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
Tom Rini Aug. 11, 2022, 4:04 p.m. UTC | #2
On Thu, Aug 11, 2022 at 05:51:52PM +0200, Alexander Kanavin wrote:

> This is less useful than it may seem, and merely moves the supported
> CPU from circa-2006 core 2 to circa-2008 core i7. You won't get AVX or
> anything newer, which requires adding these instructions to qemu
> usermode (a project I'd like to do if I had the time).

True but it's also the case that tune-corei7.conf is the newest one in
oe-core, yes? I had previously peeked in meta-intel which has a
skylake tune, but bringing that in is something I'd leave to Intel/WR
folks to take care of.
Alexander Kanavin Aug. 11, 2022, 4:07 p.m. UTC | #3
On Thu, 11 Aug 2022 at 18:04, Tom Rini <trini@konsulko.com> wrote:
> > This is less useful than it may seem, and merely moves the supported
> > CPU from circa-2006 core 2 to circa-2008 core i7. You won't get AVX or
> > anything newer, which requires adding these instructions to qemu
> > usermode (a project I'd like to do if I had the time).
>
> True but it's also the case that tune-corei7.conf is the newest one in
> oe-core, yes? I had previously peeked in meta-intel which has a
> skylake tune, but bringing that in is something I'd leave to Intel/WR
> folks to take care of.

Yes, from making things consistent perspective this change is fine.

The skylake tune in meta-intel gives its users two less than great
choices: disable qemu usermode, or disable everything that qemu
doesn't support (AVX and up).

Alex
Mittal, Anuj Aug. 11, 2022, 4:42 p.m. UTC | #4
On Thu, 2022-08-11 at 17:51 +0200, Alexander Kanavin wrote:
> You won't get AVX or
> anything newer, which requires adding these instructions to qemu
> usermode (a project I'd like to do if I had the time).

https://lore.kernel.org/all/20220418173904.3746036-1-paul@nowt.org/

I didn't notice any v3 or an update on the bug.

Thanks,

Anuj
Alexander Kanavin Dec. 9, 2022, 10:23 p.m. UTC | #5
On Thu, 11 Aug 2022 at 18:42, Mittal, Anuj <anuj.mittal@intel.com> wrote:
>
> On Thu, 2022-08-11 at 17:51 +0200, Alexander Kanavin wrote:
> > You won't get AVX or
> > anything newer, which requires adding these instructions to qemu
> > usermode (a project I'd like to do if I had the time).
>
> https://lore.kernel.org/all/20220418173904.3746036-1-paul@nowt.org/
>
> I didn't notice any v3 or an update on the bug.

This is now merged in qemu:
https://lists.nongnu.org/archive/html/qemu-devel/2022-10/msg02253.html

7.2 will be out shortly, so then we can look into adding skylake tunes
and perhaps moving qemux86_64 to them. Making skylake a fully
supported default in meta-intel would be nice too.

Alex
diff mbox series

Patch

diff --git a/meta/conf/machine/qemux86-64.conf b/meta/conf/machine/qemux86-64.conf
index 901353499c81..864086791179 100644
--- a/meta/conf/machine/qemux86-64.conf
+++ b/meta/conf/machine/qemux86-64.conf
@@ -10,7 +10,7 @@  PREFERRED_PROVIDER_virtual/libgles3 ?= "mesa"
 
 require conf/machine/include/qemu.inc
 DEFAULTTUNE ?= "core2-64"
-require conf/machine/include/x86/tune-core2.inc
+require conf/machine/include/x86/tune-corei7.inc
 require conf/machine/include/x86/qemuboot-x86.inc
 
 UBOOT_MACHINE ?= "qemu-x86_64_defconfig"