diff mbox series

insane: Reword staging to refer to populate_sysroot

Message ID 20220701115253.770729-1-richard.purdie@linuxfoundation.org
State Accepted, archived
Commit 5753b6bc5b106ab5fd3652c24ef6a1f94f983424
Headers show
Series insane: Reword staging to refer to populate_sysroot | expand

Commit Message

Richard Purdie July 1, 2022, 11:52 a.m. UTC 
'staging' is a term lost in time. This code now operates on the sysroots,
adjust the naming and messages to be more correct/appropriate.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---
 meta/classes/insane.bbclass | 11 ++++-------
 1 file changed, 4 insertions(+), 7 deletions(-)
diff mbox series

Patch

diff --git a/meta/classes/insane.bbclass b/meta/classes/insane.bbclass
index e6b0f081e61..fc7bb431e09 100644
--- a/meta/classes/insane.bbclass
+++ b/meta/classes/insane.bbclass
@@ -1149,13 +1149,14 @@  python do_package_qa_setscene () {
 }
 addtask do_package_qa_setscene
 
-python do_qa_staging() {
-    bb.note("QA checking staging")
+python do_qa_sysroot() {
+    bb.note("QA checking do_populate_sysroot")
     sysroot_destdir = d.expand('${SYSROOT_DESTDIR}')
     for sysroot_dir in d.expand('${SYSROOT_DIRS}').split():
         qa_check_staged(sysroot_destdir + sysroot_dir, d)
-    oe.qa.exit_with_message_if_errors("QA staging was broken by the package built above", d)
+    oe.qa.exit_with_message_if_errors("do_populate_sysroot for this recipe installed files with QA issues", d)
 }
+do_populate_sysroot[postfuncs] += "do_qa_sysroot"
 
 python do_qa_patch() {
     import subprocess
@@ -1347,10 +1348,6 @@  python do_qa_unpack() {
     unpack_check_src_uri(d.getVar('PN'), d)
 }
 
-# The Staging Func, to check all staging
-#addtask qa_staging after do_populate_sysroot before do_build
-do_populate_sysroot[postfuncs] += "do_qa_staging "
-
 # Check for patch fuzz
 do_patch[postfuncs] += "do_qa_patch "