[v2] gstreamer1.0-plugins-bad: add libavtp packageconfig

Message ID 20220531213624.7414-1-marcel@ziswiler.com
State Accepted, archived
Commit 5c143bfbad46bf68f70f0d6693caf48bea9fda32
Headers show
Series [v2] gstreamer1.0-plugins-bad: add libavtp packageconfig | expand

Commit Message

Marcel Ziswiler May 31, 2022, 9:36 p.m. UTC
From: Marcel Ziswiler <marcel.ziswiler@toradex.com>

Add avtp resp. libavtp PACKAGECONFIG. This allows building them
GStreamer Audio Video Transport Protocol (AVTP) Plugins which rely on
Avnu's libavtp.

Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>

---
End-to-end tested on Verdin iMX8M Plus.
Will talk about it at the Embedded World Conference in the TSN & Linux
track next month [1].

[1] https://events.weka-fachmedien.de/embedded-world-conference/program/

Changes in v2:
- Rename avtp to libavtp in the subject to make this more clear.

 .../gstreamer/gstreamer1.0-plugins-bad_1.20.2.bb                | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Marcel Ziswiler June 8, 2022, 7:07 a.m. UTC | #1
On Tue, 2022-05-31 at 23:36 +0200, Marcel Ziswiler wrote:
> From: Marcel Ziswiler <marcel.ziswiler@toradex.com>
> 
> Add avtp resp. libavtp PACKAGECONFIG. This allows building them
> GStreamer Audio Video Transport Protocol (AVTP) Plugins which rely on
> Avnu's libavtp.

Gentle ping on this one now with the other two related patches having been pulled to master [1] resp. meta-
openembedded/master-next [2].

Thanks!

[1] https://github.com/openembedded/openembedded-core/commit/8824d91fe2063195014c38c134b97946d3b429c2
[2] https://github.com/openembedded/meta-openembedded/commit/bb575718e146b66f23f2fc151fbb1e453b9f89ae

> Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
> 
> ---
> End-to-end tested on Verdin iMX8M Plus.
> Will talk about it at the Embedded World Conference in the TSN & Linux
> track next month [1].
> 
> [1] https://events.weka-fachmedien.de/embedded-world-conference/program/
> 
> Changes in v2:
> - Rename avtp to libavtp in the subject to make this more clear.
> 
>  .../gstreamer/gstreamer1.0-plugins-bad_1.20.2.bb                | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.20.2.bb b/meta/recipes-
> multimedia/gstreamer/gstreamer1.0-plugins-bad_1.20.2.bb
> index bb33e3822e..53c78d4366 100644
> --- a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.20.2.bb
> +++ b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.20.2.bb
> @@ -35,6 +35,7 @@ PACKAGECONFIG ??= " \
>  
>  PACKAGECONFIG[aom]             = "-Daom=enabled,-Daom=disabled,aom"
>  PACKAGECONFIG[assrender]       = "-Dassrender=enabled,-Dassrender=disabled,libass"
> +PACKAGECONFIG[avtp]            = "-Davtp=enabled,-Davtp=disabled,libavtp"
>  PACKAGECONFIG[bluez]           = "-Dbluez=enabled,-Dbluez=disabled,bluez5"
>  PACKAGECONFIG[bz2]             = "-Dbz2=enabled,-Dbz2=disabled,bzip2"
>  PACKAGECONFIG[closedcaption]   = "-Dclosedcaption=enabled,-Dclosedcaption=disabled,pango cairo"
> @@ -112,7 +113,6 @@ EXTRA_OEMESON += " \
>      -Dandroidmedia=disabled \
>      -Dapplemedia=disabled \
>      -Dasio=disabled \
> -    -Davtp=disabled \
>      -Dbs2b=disabled \
>      -Dchromaprint=disabled \
>      -Dd3dvideosink=disabled \
Luca Ceresoli June 8, 2022, 7:57 a.m. UTC | #2
Hi Marcel,

On Wed, 08 Jun 2022 09:07:17 +0200
"Marcel Ziswiler" <marcel@ziswiler.com> wrote:

> On Tue, 2022-05-31 at 23:36 +0200, Marcel Ziswiler wrote:
> > From: Marcel Ziswiler <marcel.ziswiler@toradex.com>
> > 
> > Add avtp resp. libavtp PACKAGECONFIG. This allows building them
> > GStreamer Audio Video Transport Protocol (AVTP) Plugins which rely on
> > Avnu's libavtp.  
> 
> Gentle ping on this one now with the other two related patches having been pulled to master [1] resp. meta-
> openembedded/master-next [2].

Good news, this patch is on master since yesterday! :)
Marcel Ziswiler June 8, 2022, 9:15 a.m. UTC | #3
On Wed, 2022-06-08 at 09:57 +0200, Luca Ceresoli wrote:
> Hi Marcel,
> 
> On Wed, 08 Jun 2022 09:07:17 +0200
> "Marcel Ziswiler" <marcel@ziswiler.com> wrote:
> 
> > On Tue, 2022-05-31 at 23:36 +0200, Marcel Ziswiler wrote:
> > > From: Marcel Ziswiler <marcel.ziswiler@toradex.com>
> > > 
> > > Add avtp resp. libavtp PACKAGECONFIG. This allows building them
> > > GStreamer Audio Video Transport Protocol (AVTP) Plugins which rely on
> > > Avnu's libavtp.  
> > 
> > Gentle ping on this one now with the other two related patches having been pulled to master [1] resp. meta-
> > openembedded/master-next [2].
> 
> Good news, this patch is on master since yesterday! :)

Indeed, sorry, missed that one resp. I checked earlier yesterday :)

Thanks!

Patch

diff --git a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.20.2.bb b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.20.2.bb
index bb33e3822e..53c78d4366 100644
--- a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.20.2.bb
+++ b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.20.2.bb
@@ -35,6 +35,7 @@  PACKAGECONFIG ??= " \
 
 PACKAGECONFIG[aom]             = "-Daom=enabled,-Daom=disabled,aom"
 PACKAGECONFIG[assrender]       = "-Dassrender=enabled,-Dassrender=disabled,libass"
+PACKAGECONFIG[avtp]            = "-Davtp=enabled,-Davtp=disabled,libavtp"
 PACKAGECONFIG[bluez]           = "-Dbluez=enabled,-Dbluez=disabled,bluez5"
 PACKAGECONFIG[bz2]             = "-Dbz2=enabled,-Dbz2=disabled,bzip2"
 PACKAGECONFIG[closedcaption]   = "-Dclosedcaption=enabled,-Dclosedcaption=disabled,pango cairo"
@@ -112,7 +113,6 @@  EXTRA_OEMESON += " \
     -Dandroidmedia=disabled \
     -Dapplemedia=disabled \
     -Dasio=disabled \
-    -Davtp=disabled \
     -Dbs2b=disabled \
     -Dchromaprint=disabled \
     -Dd3dvideosink=disabled \