local.conf.sample: https and no newline for SSTATE_MIRRORS

Message ID 20220309102850.607681-1-michael.opdenacker@bootlin.com
State Accepted, archived
Commit 85695054ee9fe194d8b5cb3e8ad5b04ac99f6c29
Headers show
Series local.conf.sample: https and no newline for SSTATE_MIRRORS | expand

Commit Message

Michael Opdenacker March 9, 2022, 10:28 a.m. UTC
Both http and https work, but we will get fewer user questions with https

Remove no longer necessary \n character in the sample definition

Signed-off-by: Michael Opdenacker <michael.opdenacker@bootlin.com>
---
 meta/conf/local.conf.sample | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Quentin Schulz March 10, 2022, 10:20 a.m. UTC | #1
Hi Michael,

On 3/9/22 11:28, Michael Opdenacker via lists.openembedded.org wrote:
> Both http and https work, but we will get fewer user questions with https
> 
> Remove no longer necessary \n character in the sample definition
> 
> Signed-off-by: Michael Opdenacker <michael.opdenacker@bootlin.com>

Reviewed-by: Quentin Schulz <foss+yocto@0leil.net>

Thanks!
Quentin

Patch

diff --git a/meta/conf/local.conf.sample b/meta/conf/local.conf.sample
index 82efc2c4f5..4d0883302b 100644
--- a/meta/conf/local.conf.sample
+++ b/meta/conf/local.conf.sample
@@ -185,7 +185,7 @@  BB_DISKMON_DIRS ??= "\
 # used to accelerate build time. This variable can be used to configure the system
 # to search other mirror locations for these objects before it builds the data itself.
 #
-# This can be a filesystem directory, or a remote url such as http or ftp. These
+# This can be a filesystem directory, or a remote url such as https or ftp. These
 # would contain the sstate-cache results from previous builds (possibly from other
 # machines). This variable works like fetcher MIRRORS/PREMIRRORS and points to the
 # cache locations to check for the shared objects.
@@ -193,7 +193,7 @@  BB_DISKMON_DIRS ??= "\
 # at the end as shown in the examples below. This will be substituted with the
 # correct path within the directory structure.
 #SSTATE_MIRRORS ?= "\
-#file://.* http://someserver.tld/share/sstate/PATH;downloadfilename=PATH \n \
+#file://.* https://someserver.tld/share/sstate/PATH;downloadfilename=PATH \
 #file://.* file:///some/local/dir/sstate/PATH"