python3-dbusmock: Add native recipe

Message ID 20220124181219.2764108-1-raj.khem@gmail.com
State New
Headers show
Series python3-dbusmock: Add native recipe | expand

Commit Message

Khem Raj Jan. 24, 2022, 6:12 p.m. UTC
Needed by apps like folks

Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
 meta/recipes-devtools/python/python3-dbusmock_0.25.0.bb | 2 ++
 1 file changed, 2 insertions(+)

Comments

Ross Burton Jan. 24, 2022, 7:38 p.m. UTC | #1
Seems like a workaround for a bad dependency.  Can this be disabled in folks?

Ross

On Mon, 24 Jan 2022 at 18:12, Khem Raj <raj.khem@gmail.com> wrote:
>
> Needed by apps like folks
>
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
>  meta/recipes-devtools/python/python3-dbusmock_0.25.0.bb | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/meta/recipes-devtools/python/python3-dbusmock_0.25.0.bb b/meta/recipes-devtools/python/python3-dbusmock_0.25.0.bb
> index e64e343a1e0..4a857eaf5ae 100644
> --- a/meta/recipes-devtools/python/python3-dbusmock_0.25.0.bb
> +++ b/meta/recipes-devtools/python/python3-dbusmock_0.25.0.bb
> @@ -16,3 +16,5 @@ RDEPENDS:${PN} += "\
>      ${PYTHON_PN}-unittest \
>      ${PYTHON_PN}-xml \
>      "
> +
> +BBCLASSEXTEND = "native"
> --
> 2.34.1
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#160891): https://lists.openembedded.org/g/openembedded-core/message/160891
> Mute This Topic: https://lists.openembedded.org/mt/88653359/1676615
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [ross@burtonini.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
Markus Volk Jan. 25, 2022, 5:53 a.m. UTC | #2
https://gitlab.gnome.org/GNOME/folks/-/blob/master/meson.build#L112

it's needed for the bluez test

Am 24.01.22 um 20:38 schrieb Ross Burton:
> Seems like a workaround for a bad dependency.  Can this be disabled in folks?
>
> Ross
>
> On Mon, 24 Jan 2022 at 18:12, Khem Raj <raj.khem@gmail.com> wrote:
>> Needed by apps like folks
>>
>> Signed-off-by: Khem Raj <raj.khem@gmail.com>
>> ---
>>   meta/recipes-devtools/python/python3-dbusmock_0.25.0.bb | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/meta/recipes-devtools/python/python3-dbusmock_0.25.0.bb b/meta/recipes-devtools/python/python3-dbusmock_0.25.0.bb
>> index e64e343a1e0..4a857eaf5ae 100644
>> --- a/meta/recipes-devtools/python/python3-dbusmock_0.25.0.bb
>> +++ b/meta/recipes-devtools/python/python3-dbusmock_0.25.0.bb
>> @@ -16,3 +16,5 @@ RDEPENDS:${PN} += "\
>>       ${PYTHON_PN}-unittest \
>>       ${PYTHON_PN}-xml \
>>       "
>> +
>> +BBCLASSEXTEND = "native"
>> --
>> 2.34.1
>>
>>
>>
>>
>>
>> -=-=-=-=-=-=-=-=-=-=-=-
>> Links: You receive all messages sent to this group.
>> View/Reply Online (#160895): https://lists.openembedded.org/g/openembedded-core/message/160895
>> Mute This Topic: https://lists.openembedded.org/mt/88653359/3618223
>> Group Owner: openembedded-core+owner@lists.openembedded.org
>> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [f_l_k@t-online.de]
>> -=-=-=-=-=-=-=-=-=-=-=-
>>
Markus Volk Jan. 25, 2022, 6:25 a.m. UTC | #3
The python3-dbusmock dependency could be dropped if folks is build with

EXTRA_OEMESON += "-Dtests=false"

Am 25.01.22 um 06:53 schrieb Markus Volk:
>
> https://gitlab.gnome.org/GNOME/folks/-/blob/master/meson.build#L112
>
> it's needed for the bluez test
>
> Am 24.01.22 um 20:38 schrieb Ross Burton:
>> Seems like a workaround for a bad dependency.  Can this be disabled in folks?
>>
>> Ross
>>
>> On Mon, 24 Jan 2022 at 18:12, Khem Raj<raj.khem@gmail.com>  wrote:
>>> Needed by apps like folks
>>>
>>> Signed-off-by: Khem Raj<raj.khem@gmail.com>
>>> ---
>>>   meta/recipes-devtools/python/python3-dbusmock_0.25.0.bb | 2 ++
>>>   1 file changed, 2 insertions(+)
>>>
>>> diff --git a/meta/recipes-devtools/python/python3-dbusmock_0.25.0.bb b/meta/recipes-devtools/python/python3-dbusmock_0.25.0.bb
>>> index e64e343a1e0..4a857eaf5ae 100644
>>> --- a/meta/recipes-devtools/python/python3-dbusmock_0.25.0.bb
>>> +++ b/meta/recipes-devtools/python/python3-dbusmock_0.25.0.bb
>>> @@ -16,3 +16,5 @@ RDEPENDS:${PN} += "\
>>>       ${PYTHON_PN}-unittest \
>>>       ${PYTHON_PN}-xml \
>>>       "
>>> +
>>> +BBCLASSEXTEND = "native"
>>> --
>>> 2.34.1
>>>
>>>
>>>
>>>
>>>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#160910): https://lists.openembedded.org/g/openembedded-core/message/160910
> Mute This Topic: https://lists.openembedded.org/mt/88653359/3618223
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [f_l_k@t-online.de]
> -=-=-=-=-=-=-=-=-=-=-=-
>
Richard Purdie Jan. 25, 2022, 12:08 p.m. UTC | #4
On Tue, 2022-01-25 at 07:25 +0100, Markus Volk wrote:
> The python3-dbusmock dependency could be dropped if folks is build with
> EXTRA_OEMESON += "-Dtests=false"

What you can often do is make it a PACKAGECONFIG and then change the
PACKAGECONFIG for the native version of the recipe to something more minimal?

Cheers,

Richard
Khem Raj Jan. 25, 2022, 4:24 p.m. UTC | #5
On Tue, Jan 25, 2022 at 4:08 AM Richard Purdie <
richard.purdie@linuxfoundation.org> wrote:

> On Tue, 2022-01-25 at 07:25 +0100, Markus Volk wrote:
> > The python3-dbusmock dependency could be dropped if folks is build with
> > EXTRA_OEMESON += "-Dtests=false"
>
> What you can often do is make it a PACKAGECONFIG and then change the
> PACKAGECONFIG for the native version of the recipe to something more
> minimal?


Still having a native variant will be required to enable them so this patch
should definitely help in that case

>
>
> Cheers,
>
> Richard
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#160917):
> https://lists.openembedded.org/g/openembedded-core/message/160917
> Mute This Topic: https://lists.openembedded.org/mt/88653359/1997914
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [
> raj.khem@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
>

Patch

diff --git a/meta/recipes-devtools/python/python3-dbusmock_0.25.0.bb b/meta/recipes-devtools/python/python3-dbusmock_0.25.0.bb
index e64e343a1e0..4a857eaf5ae 100644
--- a/meta/recipes-devtools/python/python3-dbusmock_0.25.0.bb
+++ b/meta/recipes-devtools/python/python3-dbusmock_0.25.0.bb
@@ -16,3 +16,5 @@  RDEPENDS:${PN} += "\
     ${PYTHON_PN}-unittest \
     ${PYTHON_PN}-xml \
     "
+
+BBCLASSEXTEND = "native"