[2/2] libical: build gobject and vala introspection

Signed-off-by: Markus Volk <f_l_k@t-online.de>
---
 meta/recipes-support/libical/libical_3.0.12.bb | 18 +++++++++++++++++-
 1 file changed, 17 insertions(+), 1 deletion(-)

On Fri, 21 Jan 2022 at 00:41, Markus Volk <f_l_k@t-online.de> wrote:

> +EXTRA_OECMAKE += "-DGOBJECT_INTROSPECTION=ON"
>

This needs to be conditionally enabled similar to webkitgtk recipe:
                ${@bb.utils.contains('GI_DATA_ENABLED', 'True',
'-DENABLE_INTROSPECTION=ON', '-DENABLE_INTROSPECTION=OFF', d)} \


+do_configure:append () {

> +    # fix abs path for g-ir-scanner-wrapper
> +    sed  -i ${B}/build.ninja \
> +        -e 's: ${bindir}/g-ir-scanner-wrapper:
> ${STAGING_BINDIR}/g-ir-scanner-wrapper:g'
> +
> +    # fix abs path for g-ir-compiler-wrapper
> +    sed  -i ${B}/build.ninja \
> +        -e 's: ${bindir}/g-ir-compiler-wrapper:
> ${STAGING_BINDIR}/g-ir-compiler-wrapper:g'
> +
> +    # fix abs path for vapigen
> +    sed  -i ${B}/build.ninja \
> +        -e 's: ${STAGING_BINDIR}/vapigen:
> ${STAGING_BINDIR_NATIVE}/vapigen:g'
> +}
>

This needs to be done with a patch and not by patching generated files with
sed after the fact; the binary names should be provided from calling
pkg-config.

Alex

> This needs to be conditionally enabled similar to webkitgtk recipe:
>                 ${@bb.utils.contains('GI_DATA_ENABLED', 'True', 
> '-DENABLE_INTROSPECTION=ON', '-DENABLE_INTROSPECTION=OFF', d)} \

Most Gnome Projects meanwhile consider gobject-introspection to be 
mandatory. Are you sure this needs to be optional. The generated files 
are really small in size and you just cant build the complete Gnome Code 
if you allow to make it optional.

> This needs to be done with a patch and not by patching generated files 
> with sed after the fact; the binary names should be provided from 
> calling pkg-config.
Yes, i know, you are right. But that whole introspection thing is to 
some point a big mess. Found that hack in the evolution-data-server 
recipe. Not sure if i'm able to sort that out, but i'll have a look at.

Am 21.01.22 um 00:50 schrieb Alexander Kanavin:
> On Fri, 21 Jan 2022 at 00:41, Markus Volk <f_l_k@t-online.de 
> <mailto:f_l_k@t-online.de>> wrote:
>
>     +EXTRA_OECMAKE += "-DGOBJECT_INTROSPECTION=ON"
>
>
> This needs to be conditionally enabled similar to webkitgtk recipe:
>                 ${@bb.utils.contains('GI_DATA_ENABLED', 'True', 
> '-DENABLE_INTROSPECTION=ON', '-DENABLE_INTROSPECTION=OFF', d)} \
>
>
> +do_configure:append () {
>
>     +    # fix abs path for g-ir-scanner-wrapper
>     +    sed  -i ${B}/build.ninja \
>     +        -e 's: ${bindir}/g-ir-scanner-wrapper:
>     ${STAGING_BINDIR}/g-ir-scanner-wrapper:g'
>     +
>     +    # fix abs path for g-ir-compiler-wrapper
>     +    sed  -i ${B}/build.ninja \
>     +        -e 's: ${bindir}/g-ir-compiler-wrapper:
>     ${STAGING_BINDIR}/g-ir-compiler-wrapper:g'
>     +
>     +    # fix abs path for vapigen
>     +    sed  -i ${B}/build.ninja \
>     +        -e 's: ${STAGING_BINDIR}/vapigen:
>     ${STAGING_BINDIR_NATIVE}/vapigen:g'
>     +}
>
>
> This needs to be done with a patch and not by patching generated files 
> with sed after the fact; the binary names should be provided from 
> calling pkg-config.
>
> Alex

On Fri, 21 Jan 2022 at 01:01, Markus Volk <f_l_k@t-online.de> wrote:

> This needs to be conditionally enabled similar to webkitgtk recipe:
>                 ${@bb.utils.contains('GI_DATA_ENABLED', 'True',
> '-DENABLE_INTROSPECTION=ON', '-DENABLE_INTROSPECTION=OFF', d)} \
>
> Most Gnome Projects meanwhile consider gobject-introspection to be
> mandatory. Are you sure this needs to be optional. The generated files are
> really small in size and you just cant build the complete Gnome Code if you
> allow to make it optional.
>

Absolutely. Gobject introspection in cross-compile requires running a
target executable through qemu usermode, and that is not guaranteed to
work. If qemu errors out, then the whole recipe build breaks.

Alex