mesa: Avoid PACKAGECONFIG warning for broadcom entry

Message ID 20211209153839.2322513-1-andrei@gherzan.com
State New
Headers show
Series mesa: Avoid PACKAGECONFIG warning for broadcom entry | expand

Commit Message

Andrei Gherzan Dec. 9, 2021, 3:38 p.m. UTC
From: Andrei Gherzan <andrei.gherzan@huawei.com>

Signed-off-by: Andrei Gherzan <andrei.gherzan@huawei.com>
---
 meta/recipes-graphics/mesa/mesa.inc | 1 +
 1 file changed, 1 insertion(+)

Comments

Konrad Weihmann Dec. 9, 2021, 3:41 p.m. UTC | #1
On 09.12.21 16:38, Andrei Gherzan wrote:
> From: Andrei Gherzan <andrei.gherzan@huawei.com>
> 
> Signed-off-by: Andrei Gherzan <andrei.gherzan@huawei.com>
> ---
>   meta/recipes-graphics/mesa/mesa.inc | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/meta/recipes-graphics/mesa/mesa.inc b/meta/recipes-graphics/mesa/mesa.inc
> index c894c2dab5..8db91a7b2e 100644
> --- a/meta/recipes-graphics/mesa/mesa.inc
> +++ b/meta/recipes-graphics/mesa/mesa.inc
> @@ -128,6 +128,7 @@ PACKAGECONFIG[egl] = "-Degl=enabled, -Degl=disabled"
>   PACKAGECONFIG[broadcom] = ""

Isn't that the very same as this one ^^^?

>   PACKAGECONFIG[etnaviv] = ""
>   PACKAGECONFIG[freedreno] = ""
> +PACKAGECONFIG[broadcom] = ""

The indent doesn't really match the others

>   PACKAGECONFIG[kmsro] = ""
>   PACKAGECONFIG[vc4] = ""
>   PACKAGECONFIG[v3d] = ""
> 

Could you please highlight what kind of warning you're seeing as part of 
the commit message

> 
> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#159456): https://lists.openembedded.org/g/openembedded-core/message/159456
> Mute This Topic: https://lists.openembedded.org/mt/87614068/3647476
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [kweihmann@outlook.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
Andrei Gherzan Dec. 9, 2021, 3:43 p.m. UTC | #2
Hi,

On Thu, 9 Dec 2021, at 15:41, Konrad Weihmann wrote:
> On 09.12.21 16:38, Andrei Gherzan wrote:
>> From: Andrei Gherzan <andrei.gherzan@huawei.com>
>> 
>> Signed-off-by: Andrei Gherzan <andrei.gherzan@huawei.com>
>> ---
>>   meta/recipes-graphics/mesa/mesa.inc | 1 +
>>   1 file changed, 1 insertion(+)
>> 
>> diff --git a/meta/recipes-graphics/mesa/mesa.inc b/meta/recipes-graphics/mesa/mesa.inc
>> index c894c2dab5..8db91a7b2e 100644
>> --- a/meta/recipes-graphics/mesa/mesa.inc
>> +++ b/meta/recipes-graphics/mesa/mesa.inc
>> @@ -128,6 +128,7 @@ PACKAGECONFIG[egl] = "-Degl=enabled, -Degl=disabled"
>>   PACKAGECONFIG[broadcom] = ""
>
> Isn't that the very same as this one ^^^?

It is indeed. Khem was faster and I haven't seen his patch. Can be ignored.

It was fixes as part of

commit 6add96e4af46eaabb6c70e3ce3a27a4b198d7cb6
Author: Khem Raj <raj.khem@gmail.com>
Date:   Tue Dec 7 12:16:43 2021 -0800
    mesa: Define broadcom packageconfig knob

--
Andrei

Patch

diff --git a/meta/recipes-graphics/mesa/mesa.inc b/meta/recipes-graphics/mesa/mesa.inc
index c894c2dab5..8db91a7b2e 100644
--- a/meta/recipes-graphics/mesa/mesa.inc
+++ b/meta/recipes-graphics/mesa/mesa.inc
@@ -128,6 +128,7 @@  PACKAGECONFIG[egl] = "-Degl=enabled, -Degl=disabled"
 PACKAGECONFIG[broadcom] = ""
 PACKAGECONFIG[etnaviv] = ""
 PACKAGECONFIG[freedreno] = ""
+PACKAGECONFIG[broadcom] = ""
 PACKAGECONFIG[kmsro] = ""
 PACKAGECONFIG[vc4] = ""
 PACKAGECONFIG[v3d] = ""