xdpyinfo: upgrade 1.3.2 -> 1.3.3

Message ID 1650427819-28266-3-git-send-email-wangmy@fujitsu.com
State Accepted, archived
Commit 712552b5cc427d7be1258c45886de9b57f7272c9
Headers show
Series xdpyinfo: upgrade 1.3.2 -> 1.3.3 | expand

Commit Message

Mingyu Wang (Fujitsu) April 20, 2022, 4:10 a.m. UTC
temporarily override SRC_URI which is hard-coded in xorg-app-common.inc
since new versions of packages use a new compression format - .tar.xz

Signed-off-by: Wang Mingyu <wangmy@fujitsu.com>
---
 .../xorg-app/{xdpyinfo_1.3.2.bb => xdpyinfo_1.3.3.bb}        | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
 rename meta/recipes-graphics/xorg-app/{xdpyinfo_1.3.2.bb => xdpyinfo_1.3.3.bb} (80%)

Comments

Ross Burton April 20, 2022, 10:19 a.m. UTC | #1
On Wed, 20 Apr 2022 at 05:10, wangmy <wangmy@fujitsu.com> wrote:
> temporarily override SRC_URI which is hard-coded in xorg-app-common.inc
> since new versions of packages use a new compression format - .tar.xz

Why would this be temporary?  Do you expect xorg to stop using tar.xz,
or do you expect *every* package to move to .xz?  I don't see either
happening in the short term, so I'd say the solution here would be to
parameterise the compression in xorg-app-common.inc.  For now default
to .gz but in the long run if the majority are .xz that can change.

Ross
Richard Purdie April 20, 2022, 11:55 a.m. UTC | #2
On Wed, 2022-04-20 at 11:19 +0100, Ross Burton wrote:
> On Wed, 20 Apr 2022 at 05:10, wangmy <wangmy@fujitsu.com> wrote:
> > temporarily override SRC_URI which is hard-coded in xorg-app-common.inc
> > since new versions of packages use a new compression format - .tar.xz
> 
> Why would this be temporary?  Do you expect xorg to stop using tar.xz,
> or do you expect *every* package to move to .xz?  I don't see either
> happening in the short term, so I'd say the solution here would be to
> parameterise the compression in xorg-app-common.inc.  For now default
> to .gz but in the long run if the majority are .xz that can change.

I've sent a patch which makes it a variable recipes can change.

Cheers,

Richard

Patch

diff --git a/meta/recipes-graphics/xorg-app/xdpyinfo_1.3.2.bb b/meta/recipes-graphics/xorg-app/xdpyinfo_1.3.3.bb
similarity index 80%
rename from meta/recipes-graphics/xorg-app/xdpyinfo_1.3.2.bb
rename to meta/recipes-graphics/xorg-app/xdpyinfo_1.3.3.bb
index 2d10b7acca..fa0fe36451 100644
--- a/meta/recipes-graphics/xorg-app/xdpyinfo_1.3.2.bb
+++ b/meta/recipes-graphics/xorg-app/xdpyinfo_1.3.3.bb
@@ -8,13 +8,14 @@  predefined values for various parameters used in communicating between \
 clients and the server, and the different types of screens and visuals \
 that are available."
 
+SRC_URI = "${XORG_MIRROR}/individual/app/${BPN}-${PV}.tar.xz"
+
 LIC_FILES_CHKSUM = "file://COPYING;md5=f3d09e6b9e203a1af489e16c708f4fb3"
 DEPENDS += "libxtst libxext libxxf86vm libxi libxrender libxinerama libdmx libxau libxcomposite"
 PE = "1"
 
 SRC_URI += "file://disable-xkb.patch"
 
-SRC_URI[md5sum] = "8809037bd48599af55dad81c508b6b39"
-SRC_URI[sha256sum] = "30238ed915619e06ceb41721e5f747d67320555cc38d459e954839c189ccaf51"
+SRC_URI[sha256sum] = "356d5fd62f3e98ee36d6becf1b32d4ab6112d618339fb4b592ccffbd9e0fc206"
 
 EXTRA_OECONF = "--disable-xkb"