| Message ID | 20240215170422.659073-1-enguerrand.de-ribaucourt@savoirfairelinux.com |
|---|---|
| Headers | show |
| Series | devtool: ide: Improve VSCode support | expand |
On Thu, 2024-02-15 at 18:04 +0100, Enguerrand de Ribaucourt wrote: > These patches improve the VSCode support in devtool ide-sdk from > Adrian Freihofer. > > I added a generic C++ configuration for the VScode > extension while awaiting for autotools support. > > A refactoring is proposed for the meson class. Without absolute compiler > paths, the linter inside VSCode will not be able to find the > cross-compiler. Let me know if you have any concerns about this > refactoring. > > The other bug fixes are relatively minor and make the tool work for some edge > cases. I noticed none of the patches in this series have Signed-off-by lines which needs to be fixed before we can merge them. Patchtest should be along shortly to say that too! I need to think about and test the meson one a bit more as absolute paths can be a source of problems. I've not looked into the others in detail yet. Cheers, Richard
> -----Original Message----- > From: openembedded-core@lists.openembedded.org <openembedded-core@lists.openembedded.org> On Behalf Of Richard Purdie > Sent: den 15 februari 2024 18:11 > To: Enguerrand de Ribaucourt <enguerrand.de-ribaucourt@savoirfairelinux.com>; openembedded-core@lists.openembedded.org > Cc: adrian.freihofer@gmail.com; Ross.Burton@arm.com; mohammed.raza@savoirfairelinux.com > Subject: Re: [OE-core] [PATCH 0/6] devtool: ide: Improve VSCode support > > On Thu, 2024-02-15 at 18:04 +0100, Enguerrand de Ribaucourt wrote: > > These patches improve the VSCode support in devtool ide-sdk from > > Adrian Freihofer. > > > > I added a generic C++ configuration for the VScode > > extension while awaiting for autotools support. > > > > A refactoring is proposed for the meson class. Without absolute compiler > > paths, the linter inside VSCode will not be able to find the > > cross-compiler. Let me know if you have any concerns about this > > refactoring. > > > > The other bug fixes are relatively minor and make the tool work for some edge > > cases. > > I noticed none of the patches in this series have Signed-off-by lines > which needs to be fixed before we can merge them. Patchtest should be > along shortly to say that too! Actually, there does not seem to be any messages about this from patchtest. There have been other inconsistencies reported by it since, but not these... > > I need to think about and test the meson one a bit more as absolute > paths can be a source of problems. I've not looked into the others in > detail yet. > > Cheers, > > Richard //Peter