mbox series

[0/6] devtool: add support of submodules

Message ID 20231122110818.932618-1-jstephan@baylibre.com
Headers show
Series devtool: add support of submodules | expand

Message

Julien Stephan Nov. 22, 2023, 11:08 a.m. UTC
This series adds the support of git submodules, so we can use devtool
modify with gitsm recipes to create modify and export patches using
devtool finish.

This series also adds support of git submodules defined inside SRC_URI
(i.e extracting a secondary git tree inside S)

My dev branch is available here : [1].

It passed full recipetool/devtool oeselftest locally

Cheers
Julien

[1]: https://git.yoctoproject.org/poky-contrib/log/?h=jstephan/devtool-submodule-fix


Julien Stephan (6):
  devtool: fix update-recipe dry-run mode
  devtool: finish/update-recipe: restrict mode srcrev to recipes fetched
    from SCM
  devtool: tag all submodules
  devtool: add support for git submodules
  oeqa/selftest/devtool: add test for git submodules
  lib/oe/recipeutils.py: remove trailing white-spaces

 meta/classes/devtool-source.bbclass     |   3 +
 meta/lib/oe/patch.py                    |  64 +++---
 meta/lib/oe/recipeutils.py              |  29 ++-
 meta/lib/oeqa/selftest/cases/devtool.py |  47 ++++
 scripts/lib/devtool/__init__.py         |  24 ++
 scripts/lib/devtool/standard.py         | 284 +++++++++++++++---------
 scripts/lib/devtool/upgrade.py          |  51 +++--
 scripts/lib/recipetool/append.py        |   4 +-
 8 files changed, 333 insertions(+), 173 deletions(-)

--
2.42.0

Comments

Alexander Kanavin Nov. 23, 2023, 8:12 a.m. UTC | #1
Thanks for working on this. I'm a little worried about the central
patch as it's large and changes things all over the place, but if
oe-selftest passes, there's no reason to not merge it. If AUH breaks,
we'll deal with it :)

Alex

On Wed, 22 Nov 2023 at 12:08, Julien Stephan <jstephan@baylibre.com> wrote:
>
> This series adds the support of git submodules, so we can use devtool
> modify with gitsm recipes to create modify and export patches using
> devtool finish.
>
> This series also adds support of git submodules defined inside SRC_URI
> (i.e extracting a secondary git tree inside S)
>
> My dev branch is available here : [1].
>
> It passed full recipetool/devtool oeselftest locally
>
> Cheers
> Julien
>
> [1]: https://git.yoctoproject.org/poky-contrib/log/?h=jstephan/devtool-submodule-fix
>
>
> Julien Stephan (6):
>   devtool: fix update-recipe dry-run mode
>   devtool: finish/update-recipe: restrict mode srcrev to recipes fetched
>     from SCM
>   devtool: tag all submodules
>   devtool: add support for git submodules
>   oeqa/selftest/devtool: add test for git submodules
>   lib/oe/recipeutils.py: remove trailing white-spaces
>
>  meta/classes/devtool-source.bbclass     |   3 +
>  meta/lib/oe/patch.py                    |  64 +++---
>  meta/lib/oe/recipeutils.py              |  29 ++-
>  meta/lib/oeqa/selftest/cases/devtool.py |  47 ++++
>  scripts/lib/devtool/__init__.py         |  24 ++
>  scripts/lib/devtool/standard.py         | 284 +++++++++++++++---------
>  scripts/lib/devtool/upgrade.py          |  51 +++--
>  scripts/lib/recipetool/append.py        |   4 +-
>  8 files changed, 333 insertions(+), 173 deletions(-)
>
> --
> 2.42.0
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#191061): https://lists.openembedded.org/g/openembedded-core/message/191061
> Mute This Topic: https://lists.openembedded.org/mt/102746727/1686489
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [alex.kanavin@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
Julien Stephan Nov. 23, 2023, 10:35 a.m. UTC | #2
Le jeu. 23 nov. 2023 à 09:12, Alexander Kanavin
<alex.kanavin@gmail.com> a écrit :
>
> Thanks for working on this. I'm a little worried about the central
> patch as it's large and changes things all over the place, but if
> oe-selftest passes, there's no reason to not merge it. If AUH breaks,
> we'll deal with it :)
>

Hi Alex,

yes I do agree.. but I was not able to split it, because I didn't want
to introduce "non working" commits in the middle of the series :/

Let me know if some rework is needed!

Cheers
Julien

> Alex
>
> On Wed, 22 Nov 2023 at 12:08, Julien Stephan <jstephan@baylibre.com> wrote:
> >
> > This series adds the support of git submodules, so we can use devtool
> > modify with gitsm recipes to create modify and export patches using
> > devtool finish.
> >
> > This series also adds support of git submodules defined inside SRC_URI
> > (i.e extracting a secondary git tree inside S)
> >
> > My dev branch is available here : [1].
> >
> > It passed full recipetool/devtool oeselftest locally
> >
> > Cheers
> > Julien
> >
> > [1]: https://git.yoctoproject.org/poky-contrib/log/?h=jstephan/devtool-submodule-fix
> >
> >
> > Julien Stephan (6):
> >   devtool: fix update-recipe dry-run mode
> >   devtool: finish/update-recipe: restrict mode srcrev to recipes fetched
> >     from SCM
> >   devtool: tag all submodules
> >   devtool: add support for git submodules
> >   oeqa/selftest/devtool: add test for git submodules
> >   lib/oe/recipeutils.py: remove trailing white-spaces
> >
> >  meta/classes/devtool-source.bbclass     |   3 +
> >  meta/lib/oe/patch.py                    |  64 +++---
> >  meta/lib/oe/recipeutils.py              |  29 ++-
> >  meta/lib/oeqa/selftest/cases/devtool.py |  47 ++++
> >  scripts/lib/devtool/__init__.py         |  24 ++
> >  scripts/lib/devtool/standard.py         | 284 +++++++++++++++---------
> >  scripts/lib/devtool/upgrade.py          |  51 +++--
> >  scripts/lib/recipetool/append.py        |   4 +-
> >  8 files changed, 333 insertions(+), 173 deletions(-)
> >
> > --
> > 2.42.0
> >
> >
> > -=-=-=-=-=-=-=-=-=-=-=-
> > Links: You receive all messages sent to this group.
> > View/Reply Online (#191061): https://lists.openembedded.org/g/openembedded-core/message/191061
> > Mute This Topic: https://lists.openembedded.org/mt/102746727/1686489
> > Group Owner: openembedded-core+owner@lists.openembedded.org
> > Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [alex.kanavin@gmail.com]
> > -=-=-=-=-=-=-=-=-=-=-=-
> >