mbox series

[kirkstone,PATCHv2,0/8] Backport all weston-init qol updates

Message ID 20230623162448.3162089-1-rs@ti.com
Headers show
Series Backport all weston-init qol updates | expand

Message

Randolph Sapp June 23, 2023, 4:24 p.m. UTC 
From: Randolph Sapp <rs@ti.com>

Backport all the weston-init QOL updates. Getting closer to the point
where we can actually drop our distro specific weston-init bbappend. May
submit a few more QOL patches sooner or later to completely drop it.

Resubmitting this because I forgot to CC Steve and myself on this
series.

Ming Liu (1):
  weston-init: introduce xwayland PACKAGECONFIG

Randolph Sapp (6):
  weston-init: make sure the render group exists
  weston-init: add weston user to the render group
  weston-init: add the weston user to the wayland group
  weston-init: fix the mixed indentation
  weston-init: guard against systemd configs
  weston-init: add profile to point users to global socket

ssuesens (1):
  weston.init: enabled xwayland

 meta/recipes-graphics/wayland/weston-init.bb  | 53 ++++++++++++-------
 .../wayland/weston-init/weston-socket.sh      | 20 +++++++
 2 files changed, 53 insertions(+), 20 deletions(-)
 create mode 100755 meta/recipes-graphics/wayland/weston-init/weston-socket.sh

Comments

Steve Sakoman June 27, 2023, 4 p.m. UTC | #1 
Hi Randolph,

Unfortunately this patch series results in oe-selftest failures on the
autobuilder, three examples below:

https://errors.yoctoproject.org/Errors/Details/710122/
https://errors.yoctoproject.org/Errors/Details/710127/
https://errors.yoctoproject.org/Errors/Details/710125/

Note in particular:

AssertionError: 1 != 0 : Log:
/home/pokybuild/yocto-worker/oe-selftest-centos/build/build-st-1203856/tmp/work/qemux86_64-poky-linux/core-image-weston/1.0-r0/target_logs/dmesg_output.log
-----------------------
Central error: [    2.392519] weston[373]: segfault at 28 ip
00007fad628102aa sp 00007ffff5bf2410 error 4 in
libwayland-server.so.0.20.0[7fad6280c000+8000]
***********************
[    1.742836]   with environment:
[    1.742837]     HOME=/
[    1.742838]     TERM=linux
[    1.800627] udevd[167]: starting version 3.2.10
[    1.806665] udevd[168]: starting eudev-3.2.10
[    1.964586] EXT4-fs (vda): re-mounted. Opts: (null). Quota mode: disabled.
[    2.020081] IPv6: ADDRCONF(NETDEV_CHANGE): eth0: link becomes ready
[    2.223651] Bluetooth: BNEP (Ethernet Emulation) ver 1.3
[    2.224563] Bluetooth: BNEP filters: protocol multicast
[    2.225490] Bluetooth: BNEP socket layer initialized
[    2.392519] weston[373]: segfault at 28 ip 00007fad628102aa sp
00007ffff5bf2410 error 4 in
libwayland-server.so.0.20.0[7fad6280c000+8000]
[    2.394037] Code: 48 8b 47 08 48 8d 77 10 48 8b 78 08 e9 1f c3 ff
ff 66 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 41 54 55 48 89 fd 48
83 ec 08 <8b> 57 28 4c 8b 67 08 85 d2 79 3b 48 8d 05 64 b0 00 00 48 39
07 0f

***********************
1 errors found in logs.

Steve

On Fri, Jun 23, 2023 at 6:24 AM <rs@ti.com> wrote:
>
> From: Randolph Sapp <rs@ti.com>
>
> Backport all the weston-init QOL updates. Getting closer to the point
> where we can actually drop our distro specific weston-init bbappend. May
> submit a few more QOL patches sooner or later to completely drop it.
>
> Resubmitting this because I forgot to CC Steve and myself on this
> series.
>
> Ming Liu (1):
>   weston-init: introduce xwayland PACKAGECONFIG
>
> Randolph Sapp (6):
>   weston-init: make sure the render group exists
>   weston-init: add weston user to the render group
>   weston-init: add the weston user to the wayland group
>   weston-init: fix the mixed indentation
>   weston-init: guard against systemd configs
>   weston-init: add profile to point users to global socket
>
> ssuesens (1):
>   weston.init: enabled xwayland
>
>  meta/recipes-graphics/wayland/weston-init.bb  | 53 ++++++++++++-------
>  .../wayland/weston-init/weston-socket.sh      | 20 +++++++
>  2 files changed, 53 insertions(+), 20 deletions(-)
>  create mode 100755 meta/recipes-graphics/wayland/weston-init/weston-socket.sh
>
> --
> 2.41.0
>
Randolph Sapp June 27, 2023, 6:24 p.m. UTC | #2 
On 6/27/23 11:00, Steve Sakoman wrote:
> Hi Randolph,
> 
> Unfortunately this patch series results in oe-selftest failures on the
> autobuilder, three examples below:
> 
> https://errors.yoctoproject.org/Errors/Details/710122/
> https://errors.yoctoproject.org/Errors/Details/710127/
> https://errors.yoctoproject.org/Errors/Details/710125/
> 
> Note in particular:
> 
> AssertionError: 1 != 0 : Log:
> /home/pokybuild/yocto-worker/oe-selftest-centos/build/build-st-1203856/tmp/work/qemux86_64-poky-linux/core-image-weston/1.0-r0/target_logs/dmesg_output.log
> -----------------------
> Central error: [    2.392519] weston[373]: segfault at 28 ip
> 00007fad628102aa sp 00007ffff5bf2410 error 4 in
> libwayland-server.so.0.20.0[7fad6280c000+8000]
> ***********************
> [    1.742836]   with environment:
> [    1.742837]     HOME=/
> [    1.742838]     TERM=linux
> [    1.800627] udevd[167]: starting version 3.2.10
> [    1.806665] udevd[168]: starting eudev-3.2.10
> [    1.964586] EXT4-fs (vda): re-mounted. Opts: (null). Quota mode: disabled.
> [    2.020081] IPv6: ADDRCONF(NETDEV_CHANGE): eth0: link becomes ready
> [    2.223651] Bluetooth: BNEP (Ethernet Emulation) ver 1.3
> [    2.224563] Bluetooth: BNEP filters: protocol multicast
> [    2.225490] Bluetooth: BNEP socket layer initialized
> [    2.392519] weston[373]: segfault at 28 ip 00007fad628102aa sp
> 00007ffff5bf2410 error 4 in
> libwayland-server.so.0.20.0[7fad6280c000+8000]
> [    2.394037] Code: 48 8b 47 08 48 8d 77 10 48 8b 78 08 e9 1f c3 ff
> ff 66 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 41 54 55 48 89 fd 48
> 83 ec 08 <8b> 57 28 4c 8b 67 08 85 d2 79 3b 48 8d 05 64 b0 00 00 48 39
> 07 0f
> 
> ***********************
> 1 errors found in logs.
> 
> Steve

Rats. I'm concerned what could have caused a segfault in 
libwayland-server in this series. This only tweaked Weston launch 
parameters and the only time I've seen that result in instability is 
when you ask Weston to load a module that isn't present. Even that only 
results in a safely handled runtime failure.

I hate to bother you with this, but where is the source code for this 
test? I'd like to poke around a bit more...

Randolph
Steve Sakoman June 27, 2023, 6:49 p.m. UTC | #3 
On Tue, Jun 27, 2023 at 8:25 AM Randolph Sapp <rs@ti.com> wrote:
>
> On 6/27/23 11:00, Steve Sakoman wrote:
> > Hi Randolph,
> >
> > Unfortunately this patch series results in oe-selftest failures on the
> > autobuilder, three examples below:
> >
> > https://errors.yoctoproject.org/Errors/Details/710122/
> > https://errors.yoctoproject.org/Errors/Details/710127/
> > https://errors.yoctoproject.org/Errors/Details/710125/
> >
> > Note in particular:
> >
> > AssertionError: 1 != 0 : Log:
> > /home/pokybuild/yocto-worker/oe-selftest-centos/build/build-st-1203856/tmp/work/qemux86_64-poky-linux/core-image-weston/1.0-r0/target_logs/dmesg_output.log
> > -----------------------
> > Central error: [    2.392519] weston[373]: segfault at 28 ip
> > 00007fad628102aa sp 00007ffff5bf2410 error 4 in
> > libwayland-server.so.0.20.0[7fad6280c000+8000]
> > ***********************
> > [    1.742836]   with environment:
> > [    1.742837]     HOME=/
> > [    1.742838]     TERM=linux
> > [    1.800627] udevd[167]: starting version 3.2.10
> > [    1.806665] udevd[168]: starting eudev-3.2.10
> > [    1.964586] EXT4-fs (vda): re-mounted. Opts: (null). Quota mode: disabled.
> > [    2.020081] IPv6: ADDRCONF(NETDEV_CHANGE): eth0: link becomes ready
> > [    2.223651] Bluetooth: BNEP (Ethernet Emulation) ver 1.3
> > [    2.224563] Bluetooth: BNEP filters: protocol multicast
> > [    2.225490] Bluetooth: BNEP socket layer initialized
> > [    2.392519] weston[373]: segfault at 28 ip 00007fad628102aa sp
> > 00007ffff5bf2410 error 4 in
> > libwayland-server.so.0.20.0[7fad6280c000+8000]
> > [    2.394037] Code: 48 8b 47 08 48 8d 77 10 48 8b 78 08 e9 1f c3 ff
> > ff 66 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 41 54 55 48 89 fd 48
> > 83 ec 08 <8b> 57 28 4c 8b 67 08 85 d2 79 3b 48 8d 05 64 b0 00 00 48 39
> > 07 0f
> >
> > ***********************
> > 1 errors found in logs.
> >
> > Steve
>
> Rats. I'm concerned what could have caused a segfault in
> libwayland-server in this series. This only tweaked Weston launch
> parameters and the only time I've seen that result in instability is
> when you ask Weston to load a module that isn't present. Even that only
> results in a safely handled runtime failure.
>
> I hate to bother you with this, but where is the source code for this
> test? I'd like to poke around a bit more...

I've already dropped your patch series from my test queue, but you
could duplicate what I tested by adding your patch series to the
stable/kirkstone-nut branch on oe-core-contrib:

https://git.openembedded.org/openembedded-core-contrib/log/?h=stable/kirkstone-nut

Good luck!

Steve