[AUH] alsa-lib: upgrading to 1.2.10 FAILED

Hello,

this email is a notification from the Auto Upgrade Helper
that the automatic attempt to upgrade the recipe *alsa-lib* to *1.2.10* has Failed(do_compile).

Detailed error information:

do_compile failed



Next steps:
    - apply the patch: git am 0001-alsa-lib-upgrade-1.2.9-1.2.10.patch
    - check the changes to upstream patches and summarize them in the commit message,
    - compile an image that contains the package
    - perform some basic sanity tests
    - amend the patch and sign it off: git commit -s --reset-author --amend
    - send it to the appropriate mailing list

Alternatively, if you believe the recipe should not be upgraded at this time,
you can fill RECIPE_NO_UPDATE_REASON in respective recipe file so that
automatic upgrades would no longer be attempted.

Please review the attached files for further information and build/update failures.
Any problem please file a bug at https://bugzilla.yoctoproject.org/enter_bug.cgi?product=Automated%20Update%20Handler

Regards,
The Upgrade Helper

-- >8 --
From 59fe7771c04ba1bb89e4492c01f93e194bc290de Mon Sep 17 00:00:00 2001
From: Upgrade Helper <auh@yoctoproject.org>
Date: Fri, 15 Sep 2023 16:55:32 +0000
Subject: [PATCH] alsa-lib: upgrade 1.2.9 -> 1.2.10

---
 .../alsa/{alsa-lib_1.2.9.bb => alsa-lib_1.2.10.bb}              | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
 rename meta/recipes-multimedia/alsa/{alsa-lib_1.2.9.bb => alsa-lib_1.2.10.bb} (94%)

Greetings,

On 15.09.23 at 20:59, Auto Upgrade Helper wrote:
> Hello,
>
> this email is a notification from the Auto Upgrade Helper
> that the automatic attempt to upgrade the recipe *alsa-lib* to *1.2.10* has Failed(do_compile).
>
> Detailed error information:
>
> do_compile failed
>
Ouch, as far as I am concerned, the AUH patch didn't cause any failure 
on Poky "master".
After applying a fix to the alsa-utils 2.10 recipe, I could also build 
this recipe depending on alsa-lib 1.2.10 and check that "speaker-test" 
starts.

Any advice for cases when you can't reproduce the AUH failures?

Thanks in advance
Michael.

On Mon, 18 Sept 2023 at 18:28, Michael Opdenacker via
lists.openembedded.org
<michael.opdenacker=bootlin.com@lists.openembedded.org> wrote:
> > this email is a notification from the Auto Upgrade Helper
> > that the automatic attempt to upgrade the recipe *alsa-lib* to *1.2.10* has Failed(do_compile).
> >
> > Detailed error information:
> >
> > do_compile failed
> >
> Ouch, as far as I am concerned, the AUH patch didn't cause any failure
> on Poky "master".
> After applying a fix to the alsa-utils 2.10 recipe, I could also build
> this recipe depending on alsa-lib 1.2.10 and check that "speaker-test"
> starts.
>
> Any advice for cases when you can't reproduce the AUH failures?

The failure is with musl, and I easily reproduced it there. The main
report itself isn't saying it, but attached log file name should
indicate the failing configuration.

Alex

On 18.09.23 at 19:16, Alexander Kanavin wrote:
> On Mon, 18 Sept 2023 at 18:28, Michael Opdenacker via
> lists.openembedded.org
> <michael.opdenacker=bootlin.com@lists.openembedded.org> wrote:
>>> this email is a notification from the Auto Upgrade Helper
>>> that the automatic attempt to upgrade the recipe *alsa-lib* to *1.2.10* has Failed(do_compile).
>>>
>>> Detailed error information:
>>>
>>> do_compile failed
>>>
>> Ouch, as far as I am concerned, the AUH patch didn't cause any failure
>> on Poky "master".
>> After applying a fix to the alsa-utils 2.10 recipe, I could also build
>> this recipe depending on alsa-lib 1.2.10 and check that "speaker-test"
>> starts.
>>
>> Any advice for cases when you can't reproduce the AUH failures?
> The failure is with musl, and I easily reproduced it there. The main
> report itself isn't saying it, but attached log file name should
> indicate the failing configuration.


Ah, right, I should have paid attention to the file name.
I could reproduce it too.

Thanks a lot Alex :)
Michael.

On Mon, 18 Sept 2023 at 20:46, Michael Opdenacker
<michael.opdenacker@bootlin.com> wrote:
> Ah, right, I should have paid attention to the file name.
> I could reproduce it too.
>
> Thanks a lot Alex :)
> Michael.

I think this backport should help:
https://github.com/alsa-project/alsa-lib/commit/10bd599970acc71c92f85eb08943eb8d3d702a9c

Alex

Hi Alex

On 18.09.23 at 21:13, Alexander Kanavin wrote:
> On Mon, 18 Sept 2023 at 20:46, Michael Opdenacker
> <michael.opdenacker@bootlin.com> wrote:
>> Ah, right, I should have paid attention to the file name.
>> I could reproduce it too.
>>
>> Thanks a lot Alex :)
>> Michael.
> I think this backport should help:
> https://github.com/alsa-project/alsa-lib/commit/10bd599970acc71c92f85eb08943eb8d3d702a9c


Good catch. Indeed this fixes the issue.
I'll send a patch shortly.

Many thanks!
Michael.