[Consolidated,Pull,42/45] package.bbclass: Add additional debugging for dependencies

Submitted by Saul Wold on May 25, 2012, 6:42 a.m. | Patch ID: 28797


Message ID 4035cf44fa40222ae955c3883f8eb5ffc9fa3506.1337927956.git.sgw@linux.intel.com
State New
Headers show

Commit Message

Saul Wold May 25, 2012, 6:42 a.m.
From: Mark Hatle <mark.hatle@windriver.com>

When trying to understand why a QA wanring such as:

ERROR: QA Issue: foo rdepends on bar-dev

it is very difficult to figure out where the bar-dev dependency
comes from, since many of them are added dynamically.

This adds a debug statement that says which dependency adds an
rdepends to the system.

Also, while doing this work, it was noted that the same dependencies
were being scanned for over and over.  Instead we shorten the list
by only added to the dep list if the dependency was not already there.

Signed-off-by: Mark Hatle <mark.hatle@windriver.com>
 meta/classes/package.bbclass |    7 +++++--
 1 files changed, 5 insertions(+), 2 deletions(-)

Patch hide | download patch | download mbox

diff --git a/meta/classes/package.bbclass b/meta/classes/package.bbclass
index 6fba5b6..8b0ac55 100644
--- a/meta/classes/package.bbclass
+++ b/meta/classes/package.bbclass
@@ -1266,7 +1266,8 @@  python package_do_shlibs() {
 		for l in lines:
 			m = re.match("\s+NEEDED\s+([^\s]*)", l)
 			if m:
-				needed[pkg].append(m.group(1))
+				if m.group(1) not in needed[pkg]:
+					needed[pkg].append(m.group(1))
 			m = re.match("\s+SONAME\s+([^\s]*)", l)
 			if m:
 				this_soname = m.group(1)
@@ -1338,7 +1339,7 @@  python package_do_shlibs() {
 								name = dep.replace("-l", "lib")
 							if pkg not in needed:
 								needed[pkg] = []
-							if name:
+							if name and name not in needed[pkg]:
 								#bb.note("Adding %s for %s" % (name, pkg))
@@ -1443,6 +1444,8 @@  python package_do_shlibs() {
 			if n in shlib_provider.keys():
 				(dep_pkg, ver_needed) = shlib_provider[n]
+				bb.debug(2, '%s: Dependency %s requires package %s' % (pkg, n, dep_pkg))
 				if dep_pkg == pkg: