[4/4] mesa: Add PACKAGECONFIG "rusticl"

Signed-off-by: Zoltán Böszörményi <zboszor@gmail.com>
---
 meta/recipes-graphics/mesa/mesa.inc | 16 +++++++++++++---
 1 file changed, 13 insertions(+), 3 deletions(-)

> On 24 Feb 2023, at 09:38, Zoltan Boszormenyi via lists.openembedded.org <zboszor=gmail.com@lists.openembedded.org> wrote:
> -inherit meson pkgconfig python3native gettext features_check
> +inherit meson pkgconfig python3native gettext features_check rust

This forces a dependency on rust-native, even if rusticl is disabled.

Is it actually needed? If so, make the inherit conditional.

Ross

2023. 02. 24. 10:45 keltezéssel, Ross Burton írta:
>> On 24 Feb 2023, at 09:38, Zoltan Boszormenyi via lists.openembedded.org <zboszor=gmail.com@lists.openembedded.org> wrote:
>> -inherit meson pkgconfig python3native gettext features_check
>> +inherit meson pkgconfig python3native gettext features_check rust
> This forces a dependency on rust-native, even if rusticl is disabled.
>
> Is it actually needed? If so, make the inherit conditional.

I will do that, thanks.

>
> Ross

2023. 02. 24. 11:05 keltezéssel, Zoltan Boszormenyi via lists.openembedded.org írta:
> 2023. 02. 24. 10:45 keltezéssel, Ross Burton írta:
>>> On 24 Feb 2023, at 09:38, Zoltan Boszormenyi via lists.openembedded.org 
>>> <zboszor=gmail.com@lists.openembedded.org> wrote:
>>> -inherit meson pkgconfig python3native gettext features_check
>>> +inherit meson pkgconfig python3native gettext features_check rust
>> This forces a dependency on rust-native, even if rusticl is disabled.
>>
>> Is it actually needed? If so, make the inherit conditional.
>
> I will do that, thanks.

Problem is, now the configure stage fails with:

| ../mesa-23.0.0/meson.build:964: WARNING: add_languages is missing native:, assuming 
languages are wanted for both host and build.
| Compiler for language rust for the build machine not found.
|
| ../mesa-23.0.0/meson.build:964:2: ERROR: Rust compiler rustc -C 
linker=x86_64-oe-linux-gcc -C link-arg=-m64 -C link-arg=-march=nehalem -C 
link-arg=-mtune=generic -C link-arg=-mfpmath=sse -C link-arg=-msse4.2 -C 
link-arg=-fstack-protector-strong -C link-arg=-O2 -C link-arg=-D_FORTIFY_SOURCE=2 -C 
link-arg=-Wformat -C link-arg=-Wformat-security -C link-arg=-Werror=format-security -C 
link-arg=--sysroot=/data2/dtd-yocto-4.0/tmp-sicom-glibc/work/corei7-64-oe-linux/mesa/2_23.0.0-r0/recipe-sysroot 
can not compile programs.
|
| error: Error loading target specification: Could not find specification for target 
"x86_64-linux". Run `rustc --print target-list` for a list of built-in targets

I also tried it with moving the conditionally set rust
between or before the already inherited classes.

It succeeds when inherit rust is not conditional.

>
>>
>> Ross
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#177672): https://lists.openembedded.org/g/openembedded-core/message/177672
> Mute This Topic: https://lists.openembedded.org/mt/97202946/3617728
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [zboszor@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>

On Fri, 24 Feb 2023 at 11:34, Zoltan Boszormenyi <zboszor@gmail.com> wrote:
> Problem is, now the configure stage fails with:
>
> | ../mesa-23.0.0/meson.build:964: WARNING: add_languages is missing native:, assuming
> languages are wanted for both host and build.
> | Compiler for language rust for the build machine not found.
> |
> | ../mesa-23.0.0/meson.build:964:2: ERROR: Rust compiler rustc -C
> linker=x86_64-oe-linux-gcc -C link-arg=-m64 -C link-arg=-march=nehalem -C
> link-arg=-mtune=generic -C link-arg=-mfpmath=sse -C link-arg=-msse4.2 -C
> link-arg=-fstack-protector-strong -C link-arg=-O2 -C link-arg=-D_FORTIFY_SOURCE=2 -C
> link-arg=-Wformat -C link-arg=-Wformat-security -C link-arg=-Werror=format-security -C
> link-arg=--sysroot=/data2/dtd-yocto-4.0/tmp-sicom-glibc/work/corei7-64-oe-linux/mesa/2_23.0.0-r0/recipe-sysroot
> can not compile programs.
> |
> | error: Error loading target specification: Could not find specification for target
> "x86_64-linux". Run `rustc --print target-list` for a list of built-in targets
>
> I also tried it with moving the conditionally set rust
> between or before the already inherited classes.
>
> It succeeds when inherit rust is not conditional.

It also succeeds when there is no inherit rust at all, in the current
master branch recipe.

If inherit rust is conditional, and condition is false, then there is
some other change that triggers the failure, and that change should be
conditional as well.

Alex

On Fri, 24 Feb 2023 at 11:52, Alexander Kanavin via
lists.openembedded.org <alex.kanavin=gmail.com@lists.openembedded.org>
wrote:
> It also succeeds when there is no inherit rust at all, in the current
> master branch recipe.
>
> If inherit rust is conditional, and condition is false, then there is
> some other change that triggers the failure, and that change should be
> conditional as well.

Or is it the other way around - fails when condition should be true?
How did you write it?

Alex

2023. 02. 24. 12:12 keltezéssel, Alexander Kanavin írta:
> On Fri, 24 Feb 2023 at 11:52, Alexander Kanavin via
> lists.openembedded.org <alex.kanavin=gmail.com@lists.openembedded.org>
> wrote:
>> It also succeeds when there is no inherit rust at all, in the current
>> master branch recipe.
>>
>> If inherit rust is conditional, and condition is false, then there is
>> some other change that triggers the failure, and that change should be
>> conditional as well.
> Or is it the other way around - fails when condition should be true?
> How did you write it?

Copied from a different recipe and modified for this use case:

inherit ${@bb.utils.contains('PACKAGECONFIG', 'rusticl', 'rust', '', d)}


> Alex