| Message ID | 20230104122626.3472721-1-jan.kircher@leica-microsystems.com |
|---|---|
| State | New |
| Headers | show |
| Series | toolchain-scripts: compatibility with unbound variable protection | expand |
This also applies to langdale and kirkstone. Kirkstone has this recipe in meta/classes/toolchain-scripts.bbclass.
Hello, Can you set your git from address so git adds a From: line to your patch? git config --global sendemail.from "jan.kircher@leica-microsystems.com" Should be working fine. On 04/01/2023 13:26:26+0100, Jan Kircher via lists.openembedded.org wrote: > Fixed an error when Bash's unbound variable protection is enabled (set -u) and variable LD_LIBRARY_PATH does not exist. > > Signed-off-by: Jan Kircher <jan.kircher@leica-microsystems.com> > --- > meta/classes-recipe/toolchain-scripts.bbclass | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meta/classes-recipe/toolchain-scripts.bbclass b/meta/classes-recipe/toolchain-scripts.bbclass > index 3cc823fe63..fa658a6596 100644 > --- a/meta/classes-recipe/toolchain-scripts.bbclass > +++ b/meta/classes-recipe/toolchain-scripts.bbclass > @@ -37,7 +37,7 @@ toolchain_create_sdk_env_script () { > echo '# http://tldp.org/HOWTO/Program-Library-HOWTO/shared-libraries.html#AEN80' >> $script > echo '# http://xahlee.info/UnixResource_dir/_/ldpath.html' >> $script > echo '# Only disable this check if you are absolutely know what you are doing!' >> $script > - echo 'if [ ! -z "$LD_LIBRARY_PATH" ]; then' >> $script > + echo 'if [ ! -z "${LD_LIBRARY_PATH:-}" ]; then' >> $script Your smtp server is mangling the patch (space vs tab) and it is not possible to apply it. > echo " echo \"Your environment is misconfigured, you probably need to 'unset LD_LIBRARY_PATH'\"" >> $script > echo " echo \"but please check why this was set in the first place and that it's safe to unset.\"" >> $script > echo ' echo "The SDK will not operate correctly in most cases when LD_LIBRARY_PATH is set."' >> $script > -- > 2.38.1 > > Please be advised that this email may contain confidential information. If you are not the intended recipient, please notify us by email by replying to the sender and delete this message. The sender disclaims that the content of this email constitutes an offer to enter into, or the acceptance of, any agreement; provided that the foregoing does not invalidate the binding effect of any digital or other electronic reproduction of a manual signature that is included in any attachment. This is probably the cause of the issue. > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#175473): https://lists.openembedded.org/g/openembedded-core/message/175473 > Mute This Topic: https://lists.openembedded.org/mt/96048942/3617179 > Group Owner: openembedded-core+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [alexandre.belloni@bootlin.com] > -=-=-=-=-=-=-=-=-=-=-=- >
I resubmitted this patch from a different account: https://lists.openembedded.org/g/openembedded-core/topic/96180133
diff --git a/meta/classes-recipe/toolchain-scripts.bbclass b/meta/classes-recipe/toolchain-scripts.bbclass index 3cc823fe63..fa658a6596 100644 --- a/meta/classes-recipe/toolchain-scripts.bbclass +++ b/meta/classes-recipe/toolchain-scripts.bbclass @@ -37,7 +37,7 @@ toolchain_create_sdk_env_script () { echo '# http://tldp.org/HOWTO/Program-Library-HOWTO/shared-libraries.html#AEN80' >> $script echo '# http://xahlee.info/UnixResource_dir/_/ldpath.html' >> $script echo '# Only disable this check if you are absolutely know what you are doing!' >> $script - echo 'if [ ! -z "$LD_LIBRARY_PATH" ]; then' >> $script + echo 'if [ ! -z "${LD_LIBRARY_PATH:-}" ]; then' >> $script echo " echo \"Your environment is misconfigured, you probably need to 'unset LD_LIBRARY_PATH'\"" >> $script echo " echo \"but please check why this was set in the first place and that it's safe to unset.\"" >> $script echo ' echo "The SDK will not operate correctly in most cases when LD_LIBRARY_PATH is set."' >> $script
Fixed an error when Bash's unbound variable protection is enabled (set -u) and variable LD_LIBRARY_PATH does not exist. Signed-off-by: Jan Kircher <jan.kircher@leica-microsystems.com> --- meta/classes-recipe/toolchain-scripts.bbclass | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.38.1 Please be advised that this email may contain confidential information. If you are not the intended recipient, please notify us by email by replying to the sender and delete this message. The sender disclaims that the content of this email constitutes an offer to enter into, or the acceptance of, any agreement; provided that the foregoing does not invalidate the binding effect of any digital or other electronic reproduction of a manual signature that is included in any attachment.