diff mbox series

mirrors.bbclass: use shallow tarball for nativesdk-binutils

Message ID 20221107095119.965403-1-ecordonnier@snap.com
State Accepted, archived
Commit 18624a89cb09bab78f9200a7c63406c75845e3e3
Headers show
Series mirrors.bbclass: use shallow tarball for nativesdk-binutils | expand

Commit Message

Etienne Cordonnier Nov. 7, 2022, 9:51 a.m. UTC
This is useful e.g. when using meta-clang, which introduces a dependency to nativesdk-binutils when
populating the SDK, and then a full tarball of binutils is fetched additionally to a shallow tarball.

Signed-off-by: Etienne Cordonnier <ecordonnier@snap.com>
---
 meta/classes-global/mirrors.bbclass | 2 ++
 1 file changed, 2 insertions(+)

Comments

Michael Opdenacker Nov. 8, 2022, 10:36 a.m. UTC | #1
Hi Etienne

Many thanks for the patch!

On 11/7/22 10:51, Etienne Cordonnier via lists.openembedded.org wrote:
> This is useful e.g. when using meta-clang, which introduces a dependency to nativesdk-binutils when
> populating the SDK, and then a full tarball of binutils is fetched additionally to a shallow tarball.
>
> Signed-off-by: Etienne Cordonnier <ecordonnier@snap.com>

However, there's a problem with the way your patches are received on the 
Yocto Project mailing lists though. I used to have it too.

If I apply your patch through "git am", the author of the commit will be:
Etienne Cordonnier via lists.openembedded.org 
<ecordonnier=snapchat.com@lists.openembedded.org>
instead of
Etienne Cordonnier <ecordonnier@snap.com>

That's because of the configuration of the Yocto Project mailing lists, 
if I understood correctly.

Because of this issue, the maintainer has to manually fix this field 
when accepting your patch. Worse, if he doesn't catch this, that's 
harder to fix afterwards.

You should be able to fix this by running:
git config --global sendemail.from "ecordonnier@snap.com"

This should add a "From" field to the sent patch which "git am" should 
be able to match with your name.
At least this worked for me. See 
https://www.openembedded.org/wiki/How_to_submit_a_patch_to_OpenEmbedded#Sending_using_git-send-email

Could you try to send an update (don't hesitate to send a private one to 
me first)?

Thanks in advance
Michael.
Etienne Cordonnier Nov. 14, 2022, 9:38 a.m. UTC | #2
Hi Michael,
thanks for your reply and sorry about the wrong email. I changed the
configuration and added "sendemail.from" (I had used
sendemail.envelopesender previously). However this patch is already applied
to the master branch, so I didn't send an updated patch.

On Tue, Nov 8, 2022 at 11:36 AM Michael Opdenacker <
michael.opdenacker@bootlin.com> wrote:

> Hi Etienne
>
> Many thanks for the patch!
>
> On 11/7/22 10:51, Etienne Cordonnier via lists.openembedded.org wrote:
> > This is useful e.g. when using meta-clang, which introduces a dependency
> to nativesdk-binutils when
> > populating the SDK, and then a full tarball of binutils is fetched
> additionally to a shallow tarball.
> >
> > Signed-off-by: Etienne Cordonnier <ecordonnier@snap.com>
>
> However, there's a problem with the way your patches are received on the
> Yocto Project mailing lists though. I used to have it too.
>
> If I apply your patch through "git am", the author of the commit will be:
> Etienne Cordonnier via lists.openembedded.org
> <ecordonnier=snapchat.com@lists.openembedded.org>
> instead of
> Etienne Cordonnier <ecordonnier@snap.com>
>
> That's because of the configuration of the Yocto Project mailing lists,
> if I understood correctly.
>
> Because of this issue, the maintainer has to manually fix this field
> when accepting your patch. Worse, if he doesn't catch this, that's
> harder to fix afterwards.
>
> You should be able to fix this by running:
> git config --global sendemail.from "ecordonnier@snap.com"
>
> This should add a "From" field to the sent patch which "git am" should
> be able to match with your name.
> At least this worked for me. See
>
> https://urldefense.proofpoint.com/v2/url?u=https-3A__www.openembedded.org_wiki_How-5Fto-5Fsubmit-5Fa-5Fpatch-5Fto-5FOpenEmbedded-23Sending-5Fusing-5Fgit-2Dsend-2Demail&d=DwICaQ&c=ncDTmphkJTvjIDPh0hpF_4vCHvabgGkICC2epckfdiw&r=AhkbNonVuMIGRfPx_Qj9TsRih1DULJTKUkSGa66m67E&m=OATWj9fV3DIgh3gSYx7h1yPhVJlnNDVyzQschgNMU_R_oANac6LSiRo7KudX_voS&s=u9CUuyjhy1CAiQqvOo0blFXDVHF2H69Kkre3Sm8ViaY&e=
>
> Could you try to send an update (don't hesitate to send a private one to
> me first)?
>
> Thanks in advance
> Michael.
>
> --
> Michael Opdenacker, Bootlin
> Embedded Linux and Kernel engineering
>
> https://urldefense.proofpoint.com/v2/url?u=https-3A__bootlin.com&d=DwICaQ&c=ncDTmphkJTvjIDPh0hpF_4vCHvabgGkICC2epckfdiw&r=AhkbNonVuMIGRfPx_Qj9TsRih1DULJTKUkSGa66m67E&m=OATWj9fV3DIgh3gSYx7h1yPhVJlnNDVyzQschgNMU_R_oANac6LSiRo7KudX_voS&s=33HzPwa4N8A8AGPjlZNOGbTWftq-kFhbFm3OVBa0QXw&e=
>
>
diff mbox series

Patch

diff --git a/meta/classes-global/mirrors.bbclass b/meta/classes-global/mirrors.bbclass
index 81fef7f660..8b984de3bf 100644
--- a/meta/classes-global/mirrors.bbclass
+++ b/meta/classes-global/mirrors.bbclass
@@ -91,6 +91,8 @@  BB_GIT_SHALLOW:pn-binutils-cross-canadian-${TRANSLATED_TARGET_ARCH} = "1"
 BB_GIT_SHALLOW:pn-binutils-cross-testsuite = "1"
 BB_GIT_SHALLOW:pn-binutils-crosssdk-${SDK_SYS} = "1"
 BB_GIT_SHALLOW:pn-binutils-native = "1"
+BB_GIT_SHALLOW:pn-nativesdk-binutils = "1"
+
 BB_GIT_SHALLOW:pn-glibc = "1"
 PREMIRRORS += "git://sourceware.org/git/glibc.git https://downloads.yoctoproject.org/mirror/sources/ \
               git://sourceware.org/git/binutils-gdb.git https://downloads.yoctoproject.org/mirror/sources/"