diff mbox series

[meta-ti,dunfell,v4,1/6] conf: machine: Add J784S4 hs platform

Message ID 20221107092048.555881-2-m-chawdhry@ti.com
State Accepted
Delegated to: Ryan Eatmon
Headers show
Series J784S4 HS Support | expand

Commit Message

Manorit Chawdhry Nov. 7, 2022, 9:20 a.m. UTC 
Machine conf for J784S4 HS platform.
Used J721S2 hs as reference.

Signed-off-by: Manorit Chawdhry <m-chawdhry@ti.com>
---
 conf/machine/j784s4-hs-evm-k3r5.conf | 11 +++++++++++
 conf/machine/j784s4-hs-evm.conf      | 11 +++++++++++
 2 files changed, 22 insertions(+)
 create mode 100644 conf/machine/j784s4-hs-evm-k3r5.conf
 create mode 100644 conf/machine/j784s4-hs-evm.conf

Comments

Ryan Eatmon Nov. 8, 2022, 2:02 a.m. UTC | #1 
On 11/7/2022 3:20, Manorit Chawdhry wrote:
> Machine conf for J784S4 HS platform.
> Used J721S2 hs as reference.
> 
> Signed-off-by: Manorit Chawdhry <m-chawdhry@ti.com>
> ---
>   conf/machine/j784s4-hs-evm-k3r5.conf | 11 +++++++++++
>   conf/machine/j784s4-hs-evm.conf      | 11 +++++++++++
>   2 files changed, 22 insertions(+)
>   create mode 100644 conf/machine/j784s4-hs-evm-k3r5.conf
>   create mode 100644 conf/machine/j784s4-hs-evm.conf
> 
> diff --git a/conf/machine/j784s4-hs-evm-k3r5.conf b/conf/machine/j784s4-hs-evm-k3r5.conf
> new file mode 100644
> index 00000000..80a228a0
> --- /dev/null
> +++ b/conf/machine/j784s4-hs-evm-k3r5.conf
> @@ -0,0 +1,11 @@
> +#@TYPE: Machine
> +#@NAME: J784S4 HS EVM (R5F)
> +#@DESCRIPTION: Machine configuration for the TI J784S4 HS EVM (R5F core)
> +
> +require conf/machine/include/k3r5.inc
> +
> +SYSFW_SOC = "j784s4"
> +SYSFW_CONFIG = "evm"
> +SYSFW_SUFFIX = "hs"
> +
> +UBOOT_MACHINE = "j784s4_evm_r5_defconfig"

All of the previous RFC versions had the string 
"j784s4_hs_evm_r5_defconfig", but here it is changed...  And all of the 
other HS platforms include the _hs_ in the string.  Was this intentional?


> diff --git a/conf/machine/j784s4-hs-evm.conf b/conf/machine/j784s4-hs-evm.conf
> new file mode 100644
> index 00000000..62357d62
> --- /dev/null
> +++ b/conf/machine/j784s4-hs-evm.conf
> @@ -0,0 +1,11 @@
> +#@TYPE: Machine
> +#@NAME: J784S4 HS EVM
> +#@DESCRIPTION: Machine configuration for the TI J784S4 HS EVM
> +
> +require conf/machine/j784s4-evm.conf
> +
> +UBOOT_MACHINE = "j784s4_evm_a72_defconfig"

Same comment.


> +SPL_BINARY = "tispl.bin_HS"
> +UBOOT_BINARY = "u-boot.img_HS"
> +UBOOT_SYMLINK = "u-boot.img"
Manorit Chawdhry Nov. 8, 2022, 5:13 a.m. UTC | #2 
On 20:02-20221107, Ryan Eatmon wrote:
> 
> 
> On 11/7/2022 3:20, Manorit Chawdhry wrote:
> > Machine conf for J784S4 HS platform.
> > Used J721S2 hs as reference.
> > 
> > Signed-off-by: Manorit Chawdhry <m-chawdhry@ti.com>
> > ---
> >   conf/machine/j784s4-hs-evm-k3r5.conf | 11 +++++++++++
> >   conf/machine/j784s4-hs-evm.conf      | 11 +++++++++++
> >   2 files changed, 22 insertions(+)
> >   create mode 100644 conf/machine/j784s4-hs-evm-k3r5.conf
> >   create mode 100644 conf/machine/j784s4-hs-evm.conf
> > 
> > diff --git a/conf/machine/j784s4-hs-evm-k3r5.conf b/conf/machine/j784s4-hs-evm-k3r5.conf
> > new file mode 100644
> > index 00000000..80a228a0
> > --- /dev/null
> > +++ b/conf/machine/j784s4-hs-evm-k3r5.conf
> > @@ -0,0 +1,11 @@
> > +#@TYPE: Machine
> > +#@NAME: J784S4 HS EVM (R5F)
> > +#@DESCRIPTION: Machine configuration for the TI J784S4 HS EVM (R5F core)
> > +
> > +require conf/machine/include/k3r5.inc
> > +
> > +SYSFW_SOC = "j784s4"
> > +SYSFW_CONFIG = "evm"
> > +SYSFW_SUFFIX = "hs"
> > +
> > +UBOOT_MACHINE = "j784s4_evm_r5_defconfig"
> 
> All of the previous RFC versions had the string
> "j784s4_hs_evm_r5_defconfig", but here it is changed...  And all of the
> other HS platforms include the _hs_ in the string.  Was this intentional?
> 

Ah yes, sorry for not putting it in the changelog. The yocto patches had
dependency on the uboot patches that's why this also had to changed
based on the reviews there. This is intentional as we are trying to
combine the hs and gp builds for evms using a single defconfig.

Manorit

> 
> > diff --git a/conf/machine/j784s4-hs-evm.conf b/conf/machine/j784s4-hs-evm.conf
> > new file mode 100644
> > index 00000000..62357d62
> > --- /dev/null
> > +++ b/conf/machine/j784s4-hs-evm.conf
> > @@ -0,0 +1,11 @@
> > +#@TYPE: Machine
> > +#@NAME: J784S4 HS EVM
> > +#@DESCRIPTION: Machine configuration for the TI J784S4 HS EVM
> > +
> > +require conf/machine/j784s4-evm.conf
> > +
> > +UBOOT_MACHINE = "j784s4_evm_a72_defconfig"
> 
> Same comment.
> 
> 
> > +SPL_BINARY = "tispl.bin_HS"
> > +UBOOT_BINARY = "u-boot.img_HS"
> > +UBOOT_SYMLINK = "u-boot.img"
> 
> -- 
> Ryan Eatmon                reatmon@ti.com
> -----------------------------------------
> Texas Instruments, Inc.  -  LCPD  -  MGTS
Denys Dmytriyenko Nov. 8, 2022, 6:34 p.m. UTC | #3 
On Tue, Nov 08, 2022 at 10:43:44AM +0530, Manorit Chawdhry via lists.yoctoproject.org wrote:
> On 20:02-20221107, Ryan Eatmon wrote:
> > 
> > 
> > On 11/7/2022 3:20, Manorit Chawdhry wrote:
> > > Machine conf for J784S4 HS platform.
> > > Used J721S2 hs as reference.
> > > 
> > > Signed-off-by: Manorit Chawdhry <m-chawdhry@ti.com>
> > > ---
> > >   conf/machine/j784s4-hs-evm-k3r5.conf | 11 +++++++++++
> > >   conf/machine/j784s4-hs-evm.conf      | 11 +++++++++++
> > >   2 files changed, 22 insertions(+)
> > >   create mode 100644 conf/machine/j784s4-hs-evm-k3r5.conf
> > >   create mode 100644 conf/machine/j784s4-hs-evm.conf
> > > 
> > > diff --git a/conf/machine/j784s4-hs-evm-k3r5.conf b/conf/machine/j784s4-hs-evm-k3r5.conf
> > > new file mode 100644
> > > index 00000000..80a228a0
> > > --- /dev/null
> > > +++ b/conf/machine/j784s4-hs-evm-k3r5.conf
> > > @@ -0,0 +1,11 @@
> > > +#@TYPE: Machine
> > > +#@NAME: J784S4 HS EVM (R5F)
> > > +#@DESCRIPTION: Machine configuration for the TI J784S4 HS EVM (R5F core)
> > > +
> > > +require conf/machine/include/k3r5.inc
> > > +
> > > +SYSFW_SOC = "j784s4"
> > > +SYSFW_CONFIG = "evm"
> > > +SYSFW_SUFFIX = "hs"
> > > +
> > > +UBOOT_MACHINE = "j784s4_evm_r5_defconfig"
> > 
> > All of the previous RFC versions had the string
> > "j784s4_hs_evm_r5_defconfig", but here it is changed...  And all of the
> > other HS platforms include the _hs_ in the string.  Was this intentional?
> > 
> 
> Ah yes, sorry for not putting it in the changelog. The yocto patches had
> dependency on the uboot patches that's why this also had to changed
> based on the reviews there. This is intentional as we are trying to
> combine the hs and gp builds for evms using a single defconfig.

Should this be done through multiconfig then? Like am64xx-evm that supports 
GP, HS-FS and HS-SE.
Manorit Chawdhry Nov. 9, 2022, 7:30 a.m. UTC | #4 
On 13:34-20221108, Denys Dmytriyenko wrote:
> On Tue, Nov 08, 2022 at 10:43:44AM +0530, Manorit Chawdhry via lists.yoctoproject.org wrote:
> > On 20:02-20221107, Ryan Eatmon wrote:
> > > 
> > > 
> > > On 11/7/2022 3:20, Manorit Chawdhry wrote:
> > > > Machine conf for J784S4 HS platform.
> > > > Used J721S2 hs as reference.
> > > > 
> > > > Signed-off-by: Manorit Chawdhry <m-chawdhry@ti.com>
> > > > ---
> > > >   conf/machine/j784s4-hs-evm-k3r5.conf | 11 +++++++++++
> > > >   conf/machine/j784s4-hs-evm.conf      | 11 +++++++++++
> > > >   2 files changed, 22 insertions(+)
> > > >   create mode 100644 conf/machine/j784s4-hs-evm-k3r5.conf
> > > >   create mode 100644 conf/machine/j784s4-hs-evm.conf
> > > > 
> > > > diff --git a/conf/machine/j784s4-hs-evm-k3r5.conf b/conf/machine/j784s4-hs-evm-k3r5.conf
> > > > new file mode 100644
> > > > index 00000000..80a228a0
> > > > --- /dev/null
> > > > +++ b/conf/machine/j784s4-hs-evm-k3r5.conf
> > > > @@ -0,0 +1,11 @@
> > > > +#@TYPE: Machine
> > > > +#@NAME: J784S4 HS EVM (R5F)
> > > > +#@DESCRIPTION: Machine configuration for the TI J784S4 HS EVM (R5F core)
> > > > +
> > > > +require conf/machine/include/k3r5.inc
> > > > +
> > > > +SYSFW_SOC = "j784s4"
> > > > +SYSFW_CONFIG = "evm"
> > > > +SYSFW_SUFFIX = "hs"
> > > > +
> > > > +UBOOT_MACHINE = "j784s4_evm_r5_defconfig"
> > > 
> > > All of the previous RFC versions had the string
> > > "j784s4_hs_evm_r5_defconfig", but here it is changed...  And all of the
> > > other HS platforms include the _hs_ in the string.  Was this intentional?
> > > 
> > 
> > Ah yes, sorry for not putting it in the changelog. The yocto patches had
> > dependency on the uboot patches that's why this also had to changed
> > based on the reviews there. This is intentional as we are trying to
> > combine the hs and gp builds for evms using a single defconfig.
> 
> Should this be done through multiconfig then? Like am64xx-evm that supports 
> GP, HS-FS and HS-SE.
> 

AHP supports only HS-SE and GP uptil now so I don't think it should be required at
this point, we can still continue with j784s4-hs-evm and j784s4-evm for
the builds respectively. I have tested both ( with my local uboot ) and they seem to
be booting fine after flashing the wics.

Manorit

> -- 
> Denys
diff mbox series

Patch

diff --git a/conf/machine/j784s4-hs-evm-k3r5.conf b/conf/machine/j784s4-hs-evm-k3r5.conf
new file mode 100644
index 00000000..80a228a0
--- /dev/null
+++ b/conf/machine/j784s4-hs-evm-k3r5.conf
@@ -0,0 +1,11 @@ 
+#@TYPE: Machine
+#@NAME: J784S4 HS EVM (R5F)
+#@DESCRIPTION: Machine configuration for the TI J784S4 HS EVM (R5F core)
+
+require conf/machine/include/k3r5.inc
+
+SYSFW_SOC = "j784s4"
+SYSFW_CONFIG = "evm"
+SYSFW_SUFFIX = "hs"
+
+UBOOT_MACHINE = "j784s4_evm_r5_defconfig"
diff --git a/conf/machine/j784s4-hs-evm.conf b/conf/machine/j784s4-hs-evm.conf
new file mode 100644
index 00000000..62357d62
--- /dev/null
+++ b/conf/machine/j784s4-hs-evm.conf
@@ -0,0 +1,11 @@ 
+#@TYPE: Machine
+#@NAME: J784S4 HS EVM
+#@DESCRIPTION: Machine configuration for the TI J784S4 HS EVM
+
+require conf/machine/j784s4-evm.conf
+
+UBOOT_MACHINE = "j784s4_evm_a72_defconfig"
+
+SPL_BINARY = "tispl.bin_HS"
+UBOOT_BINARY = "u-boot.img_HS"
+UBOOT_SYMLINK = "u-boot.img"