| Message ID | 20230608183641.30832-1-reatmon@ti.com |
|---|---|
| State | Accepted |
| Delegated to: | Ryan Eatmon |
| Headers | show |
| Series | [meta-arago,master] kms++: Restore pybind11 support | expand |
On Thu, Jun 08, 2023 at 01:36:41PM -0500, Ryan Eatmon via lists.yoctoproject.org wrote: > Having this turned off is causing build errors and the errors that > disabling pybind11 solved do not appear to be in master any more. Yeah, I already had this change in my local queue for master, but have been fighting other upstream issues... > Signed-off-by: Ryan Eatmon <reatmon@ti.com> Tested-by: Denys Dmytriyenko <denys@konsulko.com> > --- > meta-arago-extras/recipes-graphics/kms++/kms++_git.bb | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/meta-arago-extras/recipes-graphics/kms++/kms++_git.bb b/meta-arago-extras/recipes-graphics/kms++/kms++_git.bb > index eb39736c..56b83c7a 100644 > --- a/meta-arago-extras/recipes-graphics/kms++/kms++_git.bb > +++ b/meta-arago-extras/recipes-graphics/kms++/kms++_git.bb > @@ -12,9 +12,8 @@ SRCREV = "5afc8d918f2c084acd65027604868dfde43395cf" > > DEPENDS = "drm fmt" > > -# New meson build system fails to find pybind11 in sysroot, disable for now > -#DEPENDS += "python3-pybind11" > -#EXTRA_OEMESON = "-Dsystem-pybind11=enabled" > +DEPENDS += "python3-pybind11" > +EXTRA_OEMESON = "-Dsystem-pybind11=enabled" > > PACKAGES =+ "${PN}-python"
On 6/8/2023 1:57 PM, Denys Dmytriyenko wrote: > On Thu, Jun 08, 2023 at 01:36:41PM -0500, Ryan Eatmon via lists.yoctoproject.org wrote: >> Having this turned off is causing build errors and the errors that >> disabling pybind11 solved do not appear to be in master any more. > > Yeah, I already had this change in my local queue for master, but have been > fighting other upstream issues... Do you have other fixes for the optee CFG_DT issues, and the binutils-cross-canadian qa errors? Or should I keep looking into those? > >> Signed-off-by: Ryan Eatmon <reatmon@ti.com> > > Tested-by: Denys Dmytriyenko <denys@konsulko.com> > > >> --- >> meta-arago-extras/recipes-graphics/kms++/kms++_git.bb | 5 ++--- >> 1 file changed, 2 insertions(+), 3 deletions(-) >> >> diff --git a/meta-arago-extras/recipes-graphics/kms++/kms++_git.bb b/meta-arago-extras/recipes-graphics/kms++/kms++_git.bb >> index eb39736c..56b83c7a 100644 >> --- a/meta-arago-extras/recipes-graphics/kms++/kms++_git.bb >> +++ b/meta-arago-extras/recipes-graphics/kms++/kms++_git.bb >> @@ -12,9 +12,8 @@ SRCREV = "5afc8d918f2c084acd65027604868dfde43395cf" >> >> DEPENDS = "drm fmt" >> >> -# New meson build system fails to find pybind11 in sysroot, disable for now >> -#DEPENDS += "python3-pybind11" >> -#EXTRA_OEMESON = "-Dsystem-pybind11=enabled" >> +DEPENDS += "python3-pybind11" >> +EXTRA_OEMESON = "-Dsystem-pybind11=enabled" >> >> PACKAGES =+ "${PN}-python"
On Thu, Jun 08, 2023 at 02:39:17PM -0500, Ryan Eatmon wrote: > > > On 6/8/2023 1:57 PM, Denys Dmytriyenko wrote: > >On Thu, Jun 08, 2023 at 01:36:41PM -0500, Ryan Eatmon via lists.yoctoproject.org wrote: > >>Having this turned off is causing build errors and the errors that > >>disabling pybind11 solved do not appear to be in master any more. > > > >Yeah, I already had this change in my local queue for master, but have been > >fighting other upstream issues... > > Do you have other fixes for the optee CFG_DT issues, and the > binutils-cross-canadian qa errors? Or should I keep looking into > those? Yes, I believe I did mention this on our call couple of days ago... optee issue is being discussed on meta-arm list and binutils on oe-core list. > >>Signed-off-by: Ryan Eatmon <reatmon@ti.com> > > > >Tested-by: Denys Dmytriyenko <denys@konsulko.com> > > > > > >>--- > >> meta-arago-extras/recipes-graphics/kms++/kms++_git.bb | 5 ++--- > >> 1 file changed, 2 insertions(+), 3 deletions(-) > >> > >>diff --git a/meta-arago-extras/recipes-graphics/kms++/kms++_git.bb b/meta-arago-extras/recipes-graphics/kms++/kms++_git.bb > >>index eb39736c..56b83c7a 100644 > >>--- a/meta-arago-extras/recipes-graphics/kms++/kms++_git.bb > >>+++ b/meta-arago-extras/recipes-graphics/kms++/kms++_git.bb > >>@@ -12,9 +12,8 @@ SRCREV = "5afc8d918f2c084acd65027604868dfde43395cf" > >> DEPENDS = "drm fmt" > >>-# New meson build system fails to find pybind11 in sysroot, disable for now > >>-#DEPENDS += "python3-pybind11" > >>-#EXTRA_OEMESON = "-Dsystem-pybind11=enabled" > >>+DEPENDS += "python3-pybind11" > >>+EXTRA_OEMESON = "-Dsystem-pybind11=enabled" > >> PACKAGES =+ "${PN}-python"
On 6/8/2023 3:49 PM, Denys Dmytriyenko wrote: > On Thu, Jun 08, 2023 at 02:39:17PM -0500, Ryan Eatmon wrote: >> >> >> On 6/8/2023 1:57 PM, Denys Dmytriyenko wrote: >>> On Thu, Jun 08, 2023 at 01:36:41PM -0500, Ryan Eatmon via lists.yoctoproject.org wrote: >>>> Having this turned off is causing build errors and the errors that >>>> disabling pybind11 solved do not appear to be in master any more. >>> >>> Yeah, I already had this change in my local queue for master, but have been >>> fighting other upstream issues... >> >> Do you have other fixes for the optee CFG_DT issues, and the >> binutils-cross-canadian qa errors? Or should I keep looking into >> those? > > Yes, I believe I did mention this on our call couple of days ago... > optee issue is being discussed on meta-arm list and binutils on oe-core list. Ah. I think I misunderstood and thought you were talking about something else... It's been a long week so far... >>>> Signed-off-by: Ryan Eatmon <reatmon@ti.com> >>> >>> Tested-by: Denys Dmytriyenko <denys@konsulko.com> >>> >>> >>>> --- >>>> meta-arago-extras/recipes-graphics/kms++/kms++_git.bb | 5 ++--- >>>> 1 file changed, 2 insertions(+), 3 deletions(-) >>>> >>>> diff --git a/meta-arago-extras/recipes-graphics/kms++/kms++_git.bb b/meta-arago-extras/recipes-graphics/kms++/kms++_git.bb >>>> index eb39736c..56b83c7a 100644 >>>> --- a/meta-arago-extras/recipes-graphics/kms++/kms++_git.bb >>>> +++ b/meta-arago-extras/recipes-graphics/kms++/kms++_git.bb >>>> @@ -12,9 +12,8 @@ SRCREV = "5afc8d918f2c084acd65027604868dfde43395cf" >>>> DEPENDS = "drm fmt" >>>> -# New meson build system fails to find pybind11 in sysroot, disable for now >>>> -#DEPENDS += "python3-pybind11" >>>> -#EXTRA_OEMESON = "-Dsystem-pybind11=enabled" >>>> +DEPENDS += "python3-pybind11" >>>> +EXTRA_OEMESON = "-Dsystem-pybind11=enabled" >>>> PACKAGES =+ "${PN}-python"
diff --git a/meta-arago-extras/recipes-graphics/kms++/kms++_git.bb b/meta-arago-extras/recipes-graphics/kms++/kms++_git.bb index eb39736c..56b83c7a 100644 --- a/meta-arago-extras/recipes-graphics/kms++/kms++_git.bb +++ b/meta-arago-extras/recipes-graphics/kms++/kms++_git.bb @@ -12,9 +12,8 @@ SRCREV = "5afc8d918f2c084acd65027604868dfde43395cf" DEPENDS = "drm fmt" -# New meson build system fails to find pybind11 in sysroot, disable for now -#DEPENDS += "python3-pybind11" -#EXTRA_OEMESON = "-Dsystem-pybind11=enabled" +DEPENDS += "python3-pybind11" +EXTRA_OEMESON = "-Dsystem-pybind11=enabled" PACKAGES =+ "${PN}-python"
Having this turned off is causing build errors and the errors that disabling pybind11 solved do not appear to be in master any more. Signed-off-by: Ryan Eatmon <reatmon@ti.com> --- meta-arago-extras/recipes-graphics/kms++/kms++_git.bb | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)