diff mbox series

packagegroup-core-boot: make init-ifupdown package a recommendation

Message ID 20230109-optional-ifupdown-v1-1-18a8f3aee85b@theobroma-systems.com
State Accepted, archived
Commit 719d1b74bfa85af47e0478ee57fb7855988e44ae
Headers show
Series packagegroup-core-boot: make init-ifupdown package a recommendation | expand

Commit Message

Quentin Schulz Jan. 9, 2023, 3:53 p.m. UTC 
From: Quentin Schulz <quentin.schulz@theobroma-systems.com>

init-ifupdown provides an /etc/network/interfaces, which disables
interface management with networkmanager for example. If a network
manager (such as networkmanager) is provided, there may not be a need
for network related init scripts provided by init-ifupdown, so let's
make it a recommendation so it can be easily removed in image recipes
via the NO_RECOMMENDATIONS/BAD_RECOMMENDATIONS mechanism.

Cc: Quentin Schulz <foss+yocto@0leil.net>
Signed-off-by: Quentin Schulz <quentin.schulz@theobroma-systems.com>
---
Signed-off-by: Quentin Schulz <quentin.schulz@theobroma-systems.com>
---
 meta/recipes-core/packagegroups/packagegroup-core-boot.bb | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)


---
base-commit: a134a7186b2266378bc0b08c134e169a943eedde
change-id: 20230109-optional-ifupdown-f25f75924f58

Best regards,
-- 
Quentin Schulz <quentin.schulz@theobroma-systems.com>
diff mbox series

Patch

diff --git a/meta/recipes-core/packagegroups/packagegroup-core-boot.bb b/meta/recipes-core/packagegroups/packagegroup-core-boot.bb
index faf7bc0026..a7bad81023 100644
--- a/meta/recipes-core/packagegroups/packagegroup-core-boot.bb
+++ b/meta/recipes-core/packagegroups/packagegroup-core-boot.bb
@@ -18,7 +18,6 @@  EFI_PROVIDER ??= "grub-efi"
 
 SYSVINIT_SCRIPTS = "${@bb.utils.contains('MACHINE_FEATURES', 'rtc', '${VIRTUAL-RUNTIME_base-utils-hwclock}', '', d)} \
                     modutils-initscripts \
-                    init-ifupdown \
                     ${VIRTUAL-RUNTIME_initscripts} \
                    "
 
@@ -38,4 +37,5 @@  RDEPENDS:${PN} = "\
 
 RRECOMMENDS:${PN} = "\
     ${VIRTUAL-RUNTIME_base-utils-syslog} \
-    ${MACHINE_ESSENTIAL_EXTRA_RRECOMMENDS}"
+    ${MACHINE_ESSENTIAL_EXTRA_RRECOMMENDS} \
+    ${@bb.utils.contains("DISTRO_FEATURES", "sysvinit", "init-ifupdown", "", d)}"